From: <ltaylorsimpson@gmail.com>
To: "'Anton Johansson'" <anjo@rev.ng>, <qemu-devel@nongnu.org>
Cc: <ale@rev.ng>, <bcain@quicinc.com>
Subject: RE: [PATCH v2 3/4] target/hexagon: idef-parser fix leak of init_list
Date: Mon, 20 May 2024 15:04:32 -0500 [thread overview]
Message-ID: <02ad01daaaf0$ee9d4c50$cbd7e4f0$@gmail.com> (raw)
In-Reply-To: <20240510145244.5615-4-anjo@rev.ng>
> -----Original Message-----
> From: Anton Johansson <anjo@rev.ng>
> Sent: Friday, May 10, 2024 9:53 AM
> To: qemu-devel@nongnu.org
> Cc: ale@rev.ng; ltaylorsimpson@gmail.com; bcain@quicinc.com
> Subject: [PATCH v2 3/4] target/hexagon: idef-parser fix leak of init_list
>
> gen_inst_init_args() is called for instructions using a predicate as an
rvalue.
> Upon first call, the list of arguments which might need initialization
init_list is
> freed to indicate that they have been processed. For instructions without
an
> rvalue predicate,
> gen_inst_init_args() isn't called and init_list will never be freed.
>
> Free init_list from free_instruction() if it hasn't already been freed.
> A comment in free_instruction is also updated.
>
> Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>
next prev parent reply other threads:[~2024-05-20 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:52 [PATCH v2 0/4] target/hexagon: Minor idef-parser cleanup Anton Johansson via
2024-05-10 14:52 ` [PATCH v2 1/4] target/hexagon: idef-parser remove unused defines Anton Johansson via
2024-05-10 14:52 ` [PATCH v2 2/4] target/hexagon: idef-parser remove undefined functions Anton Johansson via
2024-05-10 14:52 ` [PATCH v2 3/4] target/hexagon: idef-parser fix leak of init_list Anton Johansson via
2024-05-20 20:04 ` ltaylorsimpson [this message]
2024-05-10 14:52 ` [PATCH v2 4/4] target/hexagon: idef-parser simplify predicate init Anton Johansson via
2024-05-20 20:03 ` ltaylorsimpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02ad01daaaf0$ee9d4c50$cbd7e4f0$@gmail.com' \
--to=ltaylorsimpson@gmail.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.