From: Salih Erim <salih.erim@amd.com>
To: Guilherme Ivo Bozi <guilherme.bozi@usp.br>,
Conall O'Griofa <conall.ogriofa@amd.com>,
Jonathan Cameron <jic23@kernel.org>,
Michal Simek <michal.simek@amd.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3 2/3] iio: adc: xilinx-ams: use guard(mutex) for automatic locking
Date: Tue, 12 May 2026 15:25:04 +0100 [thread overview]
Message-ID: <02ae12fd-2a70-40fb-9c29-6b9b572e5119@amd.com> (raw)
In-Reply-To: <20260414224245.8493-3-guilherme.bozi@usp.br>
Hi,
On 4/14/2026 11:40 PM, Guilherme Ivo Bozi wrote:
> Replace open-coded mutex_lock()/mutex_unlock() pairs with
> guard(mutex) to simplify locking and ensure proper unlock on
> all control flow paths.
>
> This removes explicit unlock handling, reduces boilerplate,
> and avoids potential mistakes in error paths while keeping
> the behavior unchanged.
>
> Signed-off-by: Guilherme Ivo Bozi <guilherme.bozi@usp.br>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/iio/adc/xilinx-ams.c | 24 ++++++++----------------
> 1 file changed, 8 insertions(+), 16 deletions(-)
Same indentation issue -- spaces instead of tabs on all new lines.
Salih
next prev parent reply other threads:[~2026-05-12 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 22:40 [PATCH v3 0/3] iio: adc: xilinx-ams: refactor alarm handling to table-driven design Guilherme Ivo Bozi
2026-04-14 22:40 ` [PATCH v3 1/3] iio: adc: xilinx-ams: fix out-of-bounds channel lookup in event handling Guilherme Ivo Bozi
2026-05-12 14:22 ` Salih Erim
2026-05-12 15:40 ` Guilherme Ivo Bozi
2026-05-12 15:54 ` Jonathan Cameron
2026-05-12 18:05 ` Salih Erim
2026-04-14 22:40 ` [PATCH v3 2/3] iio: adc: xilinx-ams: use guard(mutex) for automatic locking Guilherme Ivo Bozi
2026-05-12 14:25 ` Salih Erim [this message]
2026-04-14 22:40 ` [PATCH v3 3/3] iio: adc: xilinx-ams: refactor alarm mapping to table-driven approach Guilherme Ivo Bozi
2026-05-12 14:34 ` Salih Erim
2026-05-12 15:46 ` Guilherme Ivo Bozi
2026-04-25 15:34 ` [PATCH v3 0/3] iio: adc: xilinx-ams: refactor alarm handling to table-driven design Jonathan Cameron
2026-05-12 11:00 ` Guilherme Ivo Bozi
2026-05-12 11:02 ` Michal Simek
2026-05-12 11:26 ` Erim, Salih
2026-05-12 14:18 ` Salih Erim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ae12fd-2a70-40fb-9c29-6b9b572e5119@amd.com \
--to=salih.erim@amd.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=dlechner@baylibre.com \
--cc=guilherme.bozi@usp.br \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.