RE: [RFC][PATCH] MPC832x_RDB: update dts to use spi, registermmc_spi stub

["Joakim Tjernlund" <joakim.tjernlund@transmode.se>]

 

> -----Original Message-----
> From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com] 
> Sent: den 26 juli 2007 17:48
> To: Joakim Tjernlund
> Cc: linuxppc-dev@ozlabs.org
> Subject: Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, 
> registermmc_spi stub
> 
> On Thu, Jul 26, 2007 at 05:36:06PM +0200, Joakim Tjernlund wrote:
> [...]
> > >  		spi@4c0 {
> > >  			device_type = "spi";
> > > +			device-id = <1>;
> > >  			compatible = "fsl_spi";
> > >  			reg = <4c0 40>;
> > >  			interrupts = <2>;
> > >  			interrupt-parent = <&qeic>;
> > > -			mode = "cpu";
> > > +			mode = "qe";
> > 
> > The driver is still using "cpu" mode. It just happens that 
> the cpu mode for QE
> > enabled CPUs isn't 100% compatible with the defacto cpu 
> mode used by other CPU:s.
> 
> Yup, indeed.
> 
> > So mode should probably be "cpu_qe" or, even better, if the 
> drver could
> 
> That's easy to change, thanks.
> 
> > autodetect that it is running on a QE enabled CPU and 
> adjust accordinly.
> > Maybe the Freescale guys have some ideas how to do that.
> 
> Ok. Well, for now could we use machine_is() for kind of autodetect?
> Or it's better leave it as is, and just rename mode to cpu_qe?

Unless the DTS guys thinks otherwise, just rename to "cpu_qe".
"qe" would then be reserved for true QE mode.

 Jocke