From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70041C433EF for ; Thu, 24 Feb 2022 09:03:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232463AbiBXJDn (ORCPT ); Thu, 24 Feb 2022 04:03:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232635AbiBXJDf (ORCPT ); Thu, 24 Feb 2022 04:03:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F0CA16E7E3 for ; Thu, 24 Feb 2022 01:03:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645693384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zu3JRAMZmyMFpfpAyWAwf1dFrNwpiFycwdVqnbkI0FA=; b=DIeywNb80+hm5wadloGax7yBqHxDcK8IX7uCzBS0ceKXdQcBEBc6PAC4IHr7KWRFOUSSFs 8oVuazjaeF8FUNJLzu+fG3XfIygsDWP7s+5Q619HsQCbCDJO2s6tVjaMrQqluKR5kuEgdj QrbhckZOHTp764pdezUMj045gpfFiVY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-396-JCHn4FVLPkKjSmhNixIVrQ-1; Thu, 24 Feb 2022 04:03:03 -0500 X-MC-Unique: JCHn4FVLPkKjSmhNixIVrQ-1 Received: by mail-wm1-f70.google.com with SMTP id w3-20020a7bc743000000b0037c5168b3c4so2409363wmk.7 for ; Thu, 24 Feb 2022 01:03:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Zu3JRAMZmyMFpfpAyWAwf1dFrNwpiFycwdVqnbkI0FA=; b=e3S/98FMmiJwCGFIQPYA2YFrNCQzvfjBP1uUz2xUqmQypBZBB76SNNvQFm0Ba9kaCi zM/UKje3dss0i3sWAo2o8NThnSFu52OQ6EOJPvogWTtuhZLE7jP1LyX29HruCAziinG7 0BiKsiRPh40w31yyqLSWAGKmNw1jYvDJo49tMFUj++3vUeHnYHBUTLxOj2cIwY8PzOfx Uwyz+kFfgrvx2Ac0f7XvVOhjB9hK38rVQGdhy/1vO50ygdZwgCUwcscRNiaF5vmhsxOG WrV4VnoVkGr19/g7r2uW3xgxNCRzKT9INqZ4MiwfDjVWVyS+lgZcDDRGZgxjDA7PBczE Lewg== X-Gm-Message-State: AOAM531KUNSHDlhd+4vVNQgtIugxd5Adl7/3niV0YcKcxmih5ch+W4sr DXeSkpXyqZGldZurT0tMEHLyknHf8DIWCkxLH03u2opVhnyVL7X1aD5togP9+8lxkLIK5f0mKfo nHItsEZLHr/wVaXCIk1VrLFA= X-Received: by 2002:a1c:a942:0:b0:380:ead5:c4e2 with SMTP id s63-20020a1ca942000000b00380ead5c4e2mr1475276wme.100.1645693382156; Thu, 24 Feb 2022 01:03:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvPLEamBMKxD9kbBLEaOvjdkKui9AlNYY9UPg0V5ThbDzBY/IU9FVgaj6lagofSWiVoX0PUw== X-Received: by 2002:a1c:a942:0:b0:380:ead5:c4e2 with SMTP id s63-20020a1ca942000000b00380ead5c4e2mr1475259wme.100.1645693381945; Thu, 24 Feb 2022 01:03:01 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id y6sm2770787wrd.30.2022.02.24.01.03.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 01:03:01 -0800 (PST) Message-ID: <02cd3c81-d937-eb2a-ebe1-3eb9d83f6adc@redhat.com> Date: Thu, 24 Feb 2022 10:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit() Content-Language: en-US To: Sam Ravnborg , Thomas Zimmermann Cc: daniel@ffwll.ch, deller@gmx.de, geert@linux-m68k.org, kraxel@redhat.com, ppaalanen@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20220223193804.18636-1-tzimmermann@suse.de> <20220223193804.18636-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hello Sam, On 2/23/22 21:25, Sam Ravnborg wrote: [snip] > > Question: What is cfb an abbreviation for anyway? > Not related to the patch - but if I have known the memory is lost.. > I was curious so I dug on this. It seems CFB stands for Color Frame Buffer. Doing a `git grep "(CFB)"` in the linux history repo [0], I get this: Documentation/isdn/README.diversion: (CFB). drivers/video/pmag-ba-fb.c: * PMAG-BA TURBOchannel Color Frame Buffer (CFB) card support, include/video/pmag-ba-fb.h: * TURBOchannel PMAG-BA Color Frame Buffer (CFB) card support, Probably the helpers are called like this because they were for any fbdev driver but assumed that the framebuffer was always in I/O memory. Later some drivers were allocating the framebuffer in system memory and still using the helpers, that were using I/O memory accessors and it's ilegal on some arches. So the sys_* variants where introduced by commit 68648ed1f58d ("fbdev: add drawing functions for framebuffers in system RAM") to fix this. The old ones just kept their name, but probably it should had been renamed to io_* for the naming to be consistent with the sys_* functions. [0]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CB6DC433F5 for ; Thu, 24 Feb 2022 09:03:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C62010F3BF; Thu, 24 Feb 2022 09:03:09 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D15410F3BF for ; Thu, 24 Feb 2022 09:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645693386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zu3JRAMZmyMFpfpAyWAwf1dFrNwpiFycwdVqnbkI0FA=; b=gFaT++d5WmCXG75dwNze3x45OZ1RPxFwr+FjEWJRUpiJZfgyJ/5M6GxDCTw8L7oAeCfCeM pyP5A++auYhQ8ozJ75mcQi7NZjlTWiZhXO/oOHxI/JcU8CsBEGBdHKa5lnKdul0sNAkcHa Cp4snRT1yXYtYdOQDfBczPlt8dqlfkU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-363-y4mvyTa5Oo28luXGQH0XIA-1; Thu, 24 Feb 2022 04:03:03 -0500 X-MC-Unique: y4mvyTa5Oo28luXGQH0XIA-1 Received: by mail-wr1-f69.google.com with SMTP id e26-20020adfa45a000000b001ea860cd35cso453348wra.4 for ; Thu, 24 Feb 2022 01:03:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Zu3JRAMZmyMFpfpAyWAwf1dFrNwpiFycwdVqnbkI0FA=; b=jJpMng2MRINRohMwEHLP9E612N+TLjFfOHfgufXNqVSaVFJiMjQ5/X7J89iUJvLl5O nGQJ1hCffemzBMrZOBoxdIVn7bDcxGiYi3N7finqdW+1KjQ0szrYHCarIxf8pqnim59H Gm3b7yEwy0VeyI8NKYT3UlKbwJUYO30C+Ra17ePzm6GO5JitZ/ShGobverJX7Q7i63Yr FUoIfArXERvGsSZrc2cLb0cmi2cS3k31w5IpivSWXyZT9ceUp6AonRO98QftrdOYXZxi JPzfA2wC+ve9CqMAfgnp5WzpX99+3DgvBbKs0eEN54YAkK45B8FCkrPerieU12wM68jz N26A== X-Gm-Message-State: AOAM530HidTKtFPyM+ZN4nIa5/wXm0djnpqkWaZBb1ih1XpF82bVADsu 1453bg78G3FJ6zsIEu5+Ug/p42WhlJz4vheHb/roxVzvG/uFPN8eRQilJaBmplA6IooDJoZ8S2Y yIE+DMrQEF1tlxWc+UdXJ/s3ZAVuk X-Received: by 2002:a1c:a942:0:b0:380:ead5:c4e2 with SMTP id s63-20020a1ca942000000b00380ead5c4e2mr1475282wme.100.1645693382159; Thu, 24 Feb 2022 01:03:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvPLEamBMKxD9kbBLEaOvjdkKui9AlNYY9UPg0V5ThbDzBY/IU9FVgaj6lagofSWiVoX0PUw== X-Received: by 2002:a1c:a942:0:b0:380:ead5:c4e2 with SMTP id s63-20020a1ca942000000b00380ead5c4e2mr1475259wme.100.1645693381945; Thu, 24 Feb 2022 01:03:01 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id y6sm2770787wrd.30.2022.02.24.01.03.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 01:03:01 -0800 (PST) Message-ID: <02cd3c81-d937-eb2a-ebe1-3eb9d83f6adc@redhat.com> Date: Thu, 24 Feb 2022 10:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit() To: Sam Ravnborg , Thomas Zimmermann References: <20220223193804.18636-1-tzimmermann@suse.de> <20220223193804.18636-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, deller@gmx.de, dri-devel@lists.freedesktop.org, geert@linux-m68k.org, kraxel@redhat.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Sam, On 2/23/22 21:25, Sam Ravnborg wrote: [snip] > > Question: What is cfb an abbreviation for anyway? > Not related to the patch - but if I have known the memory is lost.. > I was curious so I dug on this. It seems CFB stands for Color Frame Buffer. Doing a `git grep "(CFB)"` in the linux history repo [0], I get this: Documentation/isdn/README.diversion: (CFB). drivers/video/pmag-ba-fb.c: * PMAG-BA TURBOchannel Color Frame Buffer (CFB) card support, include/video/pmag-ba-fb.h: * TURBOchannel PMAG-BA Color Frame Buffer (CFB) card support, Probably the helpers are called like this because they were for any fbdev driver but assumed that the framebuffer was always in I/O memory. Later some drivers were allocating the framebuffer in system memory and still using the helpers, that were using I/O memory accessors and it's ilegal on some arches. So the sys_* variants where introduced by commit 68648ed1f58d ("fbdev: add drawing functions for framebuffers in system RAM") to fix this. The old ones just kept their name, but probably it should had been renamed to io_* for the naming to be consistent with the sys_* functions. [0]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/ Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat