From: Yonghong Song <yonghong.song@linux.dev>
To: Hao Ge <hao.ge@linux.dev>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, mykolal@fb.com,
shuah@kernel.org
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Hao Ge <gehao@kylinos.cn>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer checking
Date: Wed, 21 Aug 2024 14:03:17 -0700 [thread overview]
Message-ID: <02dd26b5-16a0-4732-80e4-c7bf183e965a@linux.dev> (raw)
In-Reply-To: <20240820023447.29002-1-hao.ge@linux.dev>
On 8/19/24 7:34 PM, Hao Ge wrote:
> From: Hao Ge <gehao@kylinos.cn>
>
> Smatch reported the following warning:
> ./tools/testing/selftests/bpf/testing_helpers.c:455 get_xlated_program()
> warn: variable dereferenced before check 'buf' (see line 454)
>
> It seems correct,so let's modify it based on it's suggestion.
>
> Actually,commit b23ed4d74c4d ("selftests/bpf: Fix invalid pointer
> check in get_xlated_program()") fixed an issue in the test_verifier.c
> once,but it was reverted this time.
>
> Let's solve this issue with the minimal changes possible.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/1eb3732f-605a-479d-ba64-cd14250cbf91@stanley.mountain/
> Fixes: b4b7a4099b8c ("selftests/bpf: Factor out get_xlated_program() helper")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
In the future, please change subject '[PATCH] ...' to '[PATCH bpf-next] ...'
so CI can properly test it.
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2024-08-21 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 2:34 [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer checking Hao Ge
2024-08-21 21:03 ` Yonghong Song [this message]
2024-08-21 21:50 ` Dan Carpenter
2024-08-21 22:07 ` Alexei Starovoitov
2024-08-21 22:31 ` Dan Carpenter
2024-08-23 7:12 ` Hao Ge
2024-08-23 7:04 ` Hao Ge
-- strict thread matches above, loose matches on Subject: below --
2024-08-20 2:36 Hao Ge
2024-08-20 2:47 ` Hao Ge
2024-08-28 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02dd26b5-16a0-4732-80e4-c7bf183e965a@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gehao@kylinos.cn \
--cc=hao.ge@linux.dev \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.