From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F9920CCDC for ; Mon, 23 Mar 2026 02:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774232015; cv=none; b=d5tMZIqcfaleZsZO4hbKBNkYWYdjylKCxIyzvMqNM/gttAsZVfKK65QJJJMWA7ffU+drEU4CdH+4B2ffBadTjQjKSVMKdBAGAtOPHeX4Frk64BoCbLVRJgJhVP+QyMyiXOZH23m9Wepdipg290fU4tvJHd6Uo9bNqnebUmV7xVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774232015; c=relaxed/simple; bh=HI3XPJq6xRg6az0WgltEmIbm0qHjoruEglQ6XI1Kwes=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mtVkAf4GoaswvtTzeJw3rLXq9Amq/gYyWK7IIBuB0B0MGEah+v2ovG/M1bJTz+NU05RpqKzTPT2z9kO+FYHa+rKADM+o2sojxle2WZU8CrLO6E9Mp1Y9SvByy27JIOel3Tj3eQaBSB4BOdPFbAYPLd2LC018lljChoq+nmEr0BY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BDr+e/fP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IPEQbhU7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BDr+e/fP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IPEQbhU7" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MLsEjZ2181635 for ; Mon, 23 Mar 2026 02:13:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AxFWUvPSX2mwwlFn45yatk4d7Jv3c+D4EWYrVWqqXXU=; b=BDr+e/fPZqCBLHjg nva3ZLF5wN55/cseNHv4Se9rBxtxZokLPp3jTRTm8Qf0aqGigiNT1MyY1UOo9kd5 6Y/XeILYodL1PRqJRuC82uwnuhILlSD9h9HEn8CpV/9YkUCvhjnVAKr1xUbngAzN nx5Wd0sAqhOqiSg3YZRHcLi8+mTbYsZwDZXBIMJ3cJbLjWUwoSJflUdiy0r6+ji9 TI6P+In8t39ORQeb3kFIDyJRBF/iJGcCCU+QssoUj/kEByGkCNqmOoKFYRJQLbpr PUkE+s8M5Xo+SVxxjyUNcCgppmVs7Iy78LrBopi5YEJXDvN0VD37pSIV/gGuTMWc mB1rzg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1m3cu8t1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 02:13:33 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cfcfa72765so1498832985a.0 for ; Sun, 22 Mar 2026 19:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774232012; x=1774836812; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxFWUvPSX2mwwlFn45yatk4d7Jv3c+D4EWYrVWqqXXU=; b=IPEQbhU78vuGNEojbpZ4X8ulFY98vYxPq2DhWlI8a2/KcAi5fdtyqk6f/jkYp9p4j6 jKf5g4s1C0oWNZOKl641eAuGG7agoX/SFhU3trS6gHP8tXqzh/qs9S9fRfEjAqk8R7gl 8oA2/g8SWcvUjk4dRmpJllh6EEgp2UjJMCY7qhkwwpaHcRMahlYeLN0xwvbEgoU1Wlzd JCsO4q7IikZeJEaUiTdKcV4KO+zYTKR7OyHDDAZhHaNWYybpMfq42615Iv6bsavR1raG 0Opr3Yt3/Htbqz68khBTM/GI6z4u/EzN6LUUshLDDhHjKM42W2qtUA4kcQLyHV6oEJmK 3cAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774232012; x=1774836812; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AxFWUvPSX2mwwlFn45yatk4d7Jv3c+D4EWYrVWqqXXU=; b=tBHUJCCKlySR8ryN2fL0fCdHB8XgnTGEpYZrHzsuPHJpNAIPf+2srfdqDYbW51KKgC h/fav2aMndyDylMOfX3pIrOB09PLzHg6erRc61x1t3X4RARMHJXYlfMDXrEDqAf2b1SA /54aevS/rW7mhPR3YjUx49s7FiuwdyzGNbUFhk+Q4XUXC+zIDaMI8w4Uv10eLC8HgZAo 7QaqX/kkVrPwj1rePVPSkJBcuEsO+nrf0EtNUKDXJ+iEBZrwT+/Zp3AUUAgEa1mKWav5 y0kefciZiyhUJ2gdSDtVdL+6cz+rOu8UlfTm1A2m1qlxsuspLqErQ9gTU+VOtJCpWoWS nvnQ== X-Forwarded-Encrypted: i=1; AJvYcCVLar33c8MudYALpy9cBs5vvl4K36wqNHCHO47gWJ++R1MyNnz1UngwbZVf7z401iYdCtjeV8cGlSLNncVH@vger.kernel.org X-Gm-Message-State: AOJu0YyA3J166N0C1LT4Ai3QBwReieMqltcoPx5ShkhnTljG3zY5VKlp A/uHfMglcpDFcDLLhgl4vOEiqLHmtjs1UpN39z7dUnc63KiYkT2xFLeMgszRtpknkgCJupwOYZK d6a/ZnHzm+Sf3smKvEE7D998T4gFl/1enIe3X9hdFTBDeNkA3oI7hzKR++VvAnapyDN3J X-Gm-Gg: ATEYQzwKAR/Fdx2NROb6XuJWl2xpjIOMBrADZLNigRvY+G9OjAqD9XTHh4nOgCt+xtE yozpv6VO8b0B6v4Dt18evtwYiUBItsnRZbUu4bvkP1uqXETxKsUKeBnCVDtMWWACCNpzNlzNPQa mQ1KgTpvUiAY0Js0O4INhTHbJEaYS2vU73qmSzC7+vnNAV1Cf85l9fSJsY83TquMv5SoAXZd0MB TDu8Y14SH+rxdS/3BX4nZotuqdlB9eRQ1daGW6vFz+7eSbjHtHIyzEJzzthaqNk5Tm79hK4YqJF cFEpJ4nOgMUcQbaOO1eXbuktie7tdHLMzi5B93saDiDWMh1bpBe5ooSzAUhsV9hC78kiktSn0Dp ED4WSwleHwXdwgOcW3DrX1z8/pl/KB3rtAQEN4OUwe+JIc9S9F72nXctdBDUW/AZtsmj2MfPBpQ == X-Received: by 2002:a05:620a:40d2:b0:8cf:eafc:b7c with SMTP id af79cd13be357-8cfeafc0be0mr150753285a.41.1774232012224; Sun, 22 Mar 2026 19:13:32 -0700 (PDT) X-Received: by 2002:a05:620a:40d2:b0:8cf:eafc:b7c with SMTP id af79cd13be357-8cfeafc0be0mr150749585a.41.1774232011705; Sun, 22 Mar 2026 19:13:31 -0700 (PDT) Received: from [10.111.160.211] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cfc8fb9c10sm771993485a.19.2026.03.22.19.13.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2026 19:13:31 -0700 (PDT) Message-ID: <02ecbd98-01dc-4e56-901b-41783c55d095@oss.qualcomm.com> Date: Mon, 23 Mar 2026 10:13:24 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite To: Loic Poulain Cc: Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Gjorgji Rosikopulos , Radoslav Tsvetkov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260319-camss_fix-v1-1-e69a3590500e@oss.qualcomm.com> Content-Language: en-US From: Wenmeng Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Wa8kJ82XSnAiptUbQzS8OBz4g2h--IEy X-Authority-Analysis: v=2.4 cv=Z5rh3XRA c=1 sm=1 tr=0 ts=69c0a1cd cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ecNFY0pxKnQf4PiGJQAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDAxNSBTYWx0ZWRfX+s+fukCklhUg EKBTAAkDXj1iUjLOMRQoTdpsGkuN/lm6HWqkdUZQ4RpuFDLrBGPbiFJmt0/vu2IwbP1AZ2RaoXo RgW+zsWzoHuPadteBYyjPF/cJpAzzty0IOrwKZvOeuyJekO7no1b6FN5a3Zs6+Kgt23/2tsIz0n zvcTIj8FNNVV/Im/hJf5fDa+JDvSST6AYUiY3841jtHUYJZUpsx0AO36gJVPClgDW/7kce19W4E 3XeWg2LZ2WgbPV+umD6b6EkvE9vkG5szdhhpQ1nxLKCKv6uMVAphHmwTcktbXVjsMHvcNToUNRZ ky1BHvJif+IFqfpeDnAvoL9tx2pfpvDeXIAeJLLcsgk0rtpVkl/YsWtFvA9wSdcPha22eGoauQN KoReABWJ2Uyzgkrezigc66pZ4eNvhR50/UiakZhi149lFEc9hYAnLjXNPNqYboOHqhJOVIR4oXW rx+t9wtE1bcC5CBbggw== X-Proofpoint-ORIG-GUID: Wa8kJ82XSnAiptUbQzS8OBz4g2h--IEy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-22_07,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230015 On 3/19/2026 10:44 PM, Loic Poulain wrote: > On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu > wrote: >> >> VFE lite hardware does not provide a functional PIX path, but after >> the per sub-device type resource changes the PIX subdev name is still >> assigned unconditionally. >> >> Only assign the PIX subdev name on non-lite VFE variants to avoid >> exposing a misleading device name. >> >> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") >> Signed-off-by: Wenmeng Liu >> --- >> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 >> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, >> v4l2_subdev_init(sd, &vfe_v4l2_ops); >> sd->internal_ops = &vfe_v4l2_internal_ops; >> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >> - if (i == VFE_LINE_PIX) >> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) >> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", >> MSM_VFE_NAME, vfe->id, "pix"); > > So the PIX path will be called RDI? Doesn’t that seem misleading as well? when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is pix, not rdi. thanks, Wenmeng