From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Martin Wilck <mwilck@suse.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
DM_DEVEL-ML <dm-devel@lists.linux.dev>
Subject: Re: [PATCH 1/3] multipath-tools: delete obsolete information from multipath.conf.5
Date: Sat, 13 Jun 2026 12:27:59 +0200 [thread overview]
Message-ID: <02efe6db-3a13-4177-a318-eccf95a01c09@gmail.com> (raw)
In-Reply-To: <ainpVKRJH91bsAQc@redhat.com>
On 6/11/26 12:46 AM, Benjamin Marzinski wrote:
> On Sun, Jun 07, 2026 at 12:38:21PM +0200, Xose Vazquez Perez wrote:
>> @@ -198,9 +198,8 @@ kernel multipath target:
>> .TP 12
>> .I "round-robin 0"
>> Choose the path for the next bunch of I/O by looping through every path in the
>> -path group, sending \fBthe same number of I/O requests\fR to each path. Some
>> -aspects of behavior can be controlled with the attributes: \fIrr_min_io\fR,
>> -\fIrr_min_io_rq\fR and \fIrr_weight\fR.
>> +path group, sending \fBthe same number of I/O requests\fR to each path.
> For the path selectors, we know the number of I/O requests that will
> be sent, and it's 1. So instead of saying "the next bunch of I/O", we
> should probably just say "the next I/O request". And we can probably
> just drop the "sending the same number of I/O requests to each path"
> part of the round-robin definition.
>> @@ -1008,10 +974,6 @@ The default is: \fB<unset>\fR
>> .TP
>> .B config_dir
>> (Deprecated) This option is not supported anymore, and will be ignored.
>> -.RS
>> -.TP
>> -The compiled-in value is: \fB@CONFIGDIR@\fR
>> -.RE
> We don't actually specify the location of these files and directories
> elsewhere in this man page (except for the bindings file), and we do
> refer to them by these config option names. We should probably
> replace the references to these option names with the actual file
> locations, and probably also list the files in a FILES section.
Sounds good. I will address both points and submit the updates in
separate patches.
next prev parent reply other threads:[~2026-06-13 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260607103831.336833-1-xose.vazquez@gmail.com>
2026-06-07 10:38 ` [PATCH 1/3] multipath-tools: delete obsolete information from multipath.conf.5 Xose Vazquez Perez
2026-06-10 22:46 ` Benjamin Marzinski
2026-06-13 10:27 ` Xose Vazquez Perez [this message]
2026-06-07 10:38 ` [PATCH 2/3] multipath-tools: remove explicit width from .TP macros in multipath.conf.5 Xose Vazquez Perez
2026-06-10 23:41 ` Benjamin Marzinski
2026-06-07 10:38 ` [PATCH 3/3] multipath-tools: remove explicit widths from macros in the remaining man pages Xose Vazquez Perez
2026-06-10 23:41 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02efe6db-3a13-4177-a318-eccf95a01c09@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.