All of lore.kernel.org
 help / color / mirror / Atom feed
From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH] nvme-rdma: Support 2 inline data SGEs for write	commands.
Date: Wed, 8 Feb 2017 09:41:03 -0600	[thread overview]
Message-ID: <030701d28221$c115d1d0$43417570$@opengridcomputing.com> (raw)
In-Reply-To: <VI1PR0502MB30080615048602665537DBB9D1420@VI1PR0502MB3008.eurprd05.prod.outlook.com>

> >
> > This looks fine to me in general, but I'm a little curious how your arrived
at
> > that 2 number.  Why not 4 or 8?
> 
> Some adapters doesn't support more than 5 sges. So increasing it to 4 or 8
would
> fail them.
> Chuck reported 1 out of 3 adapters only support 3. Its likely due to
min(send_sge,
> recv_sge).
> With total of 3 SGEs (64B cmd sge + data sges), WQE fits in 64 bytes size at
the
> provider driver level. So to strike balance between cache line usage and
> performance, and to be nice to those adapters which has low SGE (either due to
> min(send_sge, recv) or other otherwise, I picked 2 data sges.
> 
> Side  note: I have split out send and recv sge in other unrelated patch which
is in
> review internally from linux-rdma tree.

I'm looking forward to this patch since cxgb4 has max_recv_sge of 4 and
max_send_sge of 17!

Steve.

  reply	other threads:[~2017-02-08 15:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 22:39 [PATCH] nvme-rdma: Support 2 inline data SGEs for write commands Parav Pandit
2017-02-08  8:27 ` Christoph Hellwig
2017-02-08  9:48   ` Sagi Grimberg
2017-02-08 15:15   ` Parav Pandit
2017-02-08 15:41     ` Steve Wise [this message]
2017-02-08 15:42       ` Parav Pandit
2017-02-08 15:49         ` Steve Wise
2017-02-08  9:45 ` Sagi Grimberg
     [not found] <VI1PR0502MB3008FAE182CFAFA906ECF62DD1500@VI1PR0502MB3008.eurprd05.prod.outlook.com>
2017-02-22 19:38 ` Sagi Grimberg
2017-02-22 19:52   ` Parav Pandit
2017-02-22 19:55     ` Sagi Grimberg
2017-02-22 20:02       ` Parav Pandit
2017-02-22 20:07         ` Sagi Grimberg
2017-02-22 20:46           ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='030701d28221$c115d1d0$43417570$@opengridcomputing.com' \
    --to=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.