From: "Hampson, Steven T" <steven.t.hampson@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage
Date: Thu, 19 Nov 2020 18:18:14 +0000 [thread overview]
Message-ID: <030edf9e00ee4cc8bf204becd5ec53fc@intel.com> (raw)
In-Reply-To: <08d69a538ca24cc1806b160e2981b0b2@intel.com>
Chris,
Is this acceptable? Can it be merged?
-----Original Message-----
From: Hampson, Steven T
Sent: Wednesday, November 18, 2020 12:41 PM
To: 'Chris Wilson' <chris@chris-wilson.co.uk>
Cc: intel-gfx@ <lists.freedesktop.org intel-gfx@lists.freedesktop.org>
Subject: RE: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage
The problem is that the machine it was running on had 32 cpus, so one set of numbers per cpu filled the buffer.
-----Original Message-----
From: Chris Wilson <chris@chris-wilson.co.uk>
Sent: Wednesday, November 18, 2020 2:52 AM
To: Hampson, Steven T <steven.t.hampson@intel.com>
Cc: intel-gfx@ <lists.freedesktop.org intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage
Quoting Hampson, Steven T (2020-11-17 23:45:23)
>
>
> Sent from my iPhone
>
> > On Nov 17, 2020, at 2:28 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Steve Hampson (2020-11-17 22:23:08)
> >> A buffer in function test_flink_name was both too small and never
> >> checked for overflow. Both errors are fixed.
> >
> > That many numbers is not interesting. Show the range and median instead.
> > -Chris
>
> I don’t understand what you are talking about.
The reason I printed the individual numbers was so that we could see the distribution in case one thread was being starved or not. That is fine for a few numbers, but beyond that we can summarise with statistics.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-19 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 22:23 [Intel-gfx] [PATCH] i915/gem_flink_race: Fix error in buffer usage Steve Hampson
2020-11-17 22:28 ` Chris Wilson
2020-11-17 23:45 ` Hampson, Steven T
2020-11-18 10:52 ` Chris Wilson
[not found] ` <08d69a538ca24cc1806b160e2981b0b2@intel.com>
2020-11-19 18:18 ` Hampson, Steven T [this message]
2020-11-19 18:31 ` Chris Wilson
2020-11-18 2:30 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030edf9e00ee4cc8bf204becd5ec53fc@intel.com \
--to=steven.t.hampson@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.