From: Stephan Linz <linz@mazet.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] AGAIN: need help for LAN91C111 driver
Date: Tue, 28 Oct 2003 19:31:47 +0100 [thread overview]
Message-ID: <03102819314708.02205@pcj86> (raw)
Hi all,
I've found unexpected code inside of smc_send_packet() in file
drivers/smc91111.c (near line 585-590):
/* send the packet length ( +6 for status, length and ctl byte )
and the status word ( set to zeros ) */
#ifdef USE_32_BIT
SMC_outl ((length + 6) << 16, SMC91111_DATA_REG);
#else
SMC_outw (0, SMC91111_DATA_REG);
/* send the packet length ( +6 for status words, length, and ctl */
SMC_outw ((length + 6), SMC91111_DATA_REG);
#endif
This code assembles the header of a data frame for transmission. My SMSC
manual says about the BYTE COUNTER: "... alway even ...", Hmm , this code
will put in even and odd length arguments. "length" should be replaced with
"(length & 0xfffe)", the same code at top of function for page number
calculation.
What's your opinion?
Best regards
--
Mit freundlichen Gruessen
Stephan Linz
======================================================================
Stephan Linz
Softwareentwicklung
MAZeT GmbH Email: mailto:linz@mazet.de
G?schwitzer Str. 32 Tel. : (3641) 2809-55
D-07745 Jena Fax : (3641) 2809-12
Besuchen Sie bitte unsere Web-Seiten: http://www.MAZeT.de
======================================================================
reply other threads:[~2003-10-28 18:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03102819314708.02205@pcj86 \
--to=linz@mazet.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.