From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'Ben Boeckel'" <ben.boeckel@kitware.com>, <git@vger.kernel.org>
Subject: RE: [BUG] `git describe` doesn't traverse the graph in topological order
Date: Fri, 22 Sep 2023 14:12:31 -0400 [thread overview]
Message-ID: <032d01d9ed80$5e569670$1b03c350$@nexbridge.com> (raw)
In-Reply-To: <xmqqediq2j0g.fsf@gitster.g>
On Friday, September 22, 2023 1:52 PM, Junio C Hamano wrote:
><rsbecker@nexbridge.com> writes:
>
>> There appears to be a merge at 446120fd88 which brings v9.3.0.rc0 closer
to HEAD
>than v9.3.0.rc1.
>
>I didn't look at the actual graph but let me say I trust you ;-)
>
>I wonder if there should be an obvious "explain why you gave this name"
mode added
>to the command, though. The command should be able to say "The closest
path from
>HEAD to any tag is via this, that, and that commit, which is N hops to tag
T0", and
>from there, the user should be able to say "Oh, I thought T1 was closer,
let me try
>again to describe HEAD, limiting the candidate only to T1" and run the
command in
>that mode, which should be able to say "The closest path from HEAD to any
tag that
>is allowed as a candidate is via these commits, which is M hops to tag T1".
And if M
>is smaller than N, then that may deserve to trigger a bug report (but as
you said,
>there are rules like preferring annotated over unannotated tags involved,
so it may
>not as straight-forward as comparing the two integer hop counts).
>
>Thanks for digging.
I'm wondering whether we need something more general that --first-parent.
Perhaps something like
git describe commitish [ commitish ... ]
Where the traversal must cross the set of specified commitish points in
history in order to find the expected tag. In Ben's case, I do not think
that would help much, given the complexity of his history. Perhaps a
--verbose argument might display the analysis path done by git describe as
above. Sadly, I am not familiar with this code area.
What confuses me is how, in the other subthread, that adding sleep 1 to the
construction of history should make any difference. My understanding is that
the path to the tag is invariant of the commit-date.
next prev parent reply other threads:[~2023-09-22 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 19:36 [BUG] `git describe` doesn't traverse the graph in topological order Ben Boeckel
2023-09-22 15:39 ` Ben Boeckel
2023-09-22 16:13 ` rsbecker
2023-09-22 16:51 ` 'Ben Boeckel'
2023-09-22 17:14 ` rsbecker
2023-09-22 17:38 ` 'Ben Boeckel'
2023-09-22 17:51 ` Junio C Hamano
2023-09-22 18:12 ` rsbecker [this message]
2023-09-22 18:44 ` 'Ben Boeckel'
2023-09-22 18:49 ` rsbecker
2023-09-22 19:05 ` 'Ben Boeckel'
2023-09-22 19:27 ` rsbecker
2025-11-20 2:48 ` 'Ben Boeckel'
2025-11-20 8:05 ` Jeff King
2026-02-28 6:11 ` 'Ben Boeckel'
2023-09-22 18:41 ` 'Ben Boeckel'
2023-09-23 12:32 ` 'Ben Boeckel'
2023-09-22 17:11 ` Kristoffer Haugsbakk
2023-09-22 17:35 ` Kristoffer Haugsbakk
2023-09-22 17:43 ` 'Ben Boeckel'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='032d01d9ed80$5e569670$1b03c350$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=ben.boeckel@kitware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.