RE: [PATCH dev-5.1 v5 1/4] ARM: dts: nuvoton: Add NPCM730 common device tree include file.

[franhsutw@gmail.com]

Hi Joel, Benjamin,
    I did some modification and push the patch v6 for review.
The patch v6 fixed the warning of nuvoton-npcm730-gsj.dts only.
Regarding the other warning messages, I will co-work with Nuvoton team.
Thanks,

Fran

> -----Original Message-----
> From: Joel Stanley <joel@jms.id.au>
> Sent: Tuesday, June 4, 2019 1:29 PM
> To: Benjamin Fair <benjaminfair@google.com>
> Cc: Fran Hsu <franhsutw@gmail.com>; OpenBMC Maillist
> <openbmc@lists.ozlabs.org>; Fran Hsu <Fran.Hsu@quantatw.com>
> Subject: Re: [PATCH dev-5.1 v5 1/4] ARM: dts: nuvoton: Add NPCM730 common
> device tree include file.
> 
> On Tue, 4 Jun 2019 at 05:23, Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Fri, 31 May 2019 at 15:28, Benjamin Fair <benjaminfair@google.com>
> wrote:
> > > This looks great! I think it's ready to merge.
> > >
> > > On Fri, May 31, 2019 at 6:26 AM Fran Hsu <franhsutw@gmail.com> wrote:
> > > >
> > > > Quanta GSJ BMC uses the Nuvoton NPCM730 BMC soc.
> > > > This file describes the common setting of NPCM730 soc.
> > > >
> > > > Signed-off-by: Fran Hsu <Fran.Hsu@quantatw.com>
> > >
> > > Reviewed-by: Benjamin Fair <benjaminfair@google.com>
> >
> > Thanks Benjamin for reviewing, and Fran for working to get these
> > patches in a state that we can merge them. I've put them in the
> > dev-5.1 tree with some small tweaks to the commit messages.
> 
> I spoke too soon. I see these warnings when building:
> 
> ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:307.6-25: Warning
> (i2c_bus_reg): /ahb/apb/i2c@8d000/ipmb@40000010:reg: I2C address must
> be less than 10-bits, got "0x40000010"
> ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:320.6-25: Warning
> (i2c_bus_reg): /ahb/apb/i2c@8e000/ipmb@40000012:reg: I2C address must
> be less than 10-bits, got "0x40000012"
> 
> Please send follow up patches to fix these warnings.
> 
> The following warnings also exist when building the npcm kernel. If you could
> also fix those it would be appreciated:
> 
> ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:222.22-231.5: Warning
> (spi_bus_bridge): /ahb/fiu@fb000000: node name for SPI buses should be 'spi'
>   also defined at ../arch/arm/boot/dts/nuvoton-npcm730-gsj.dts:81.22-126.5
> arch/arm/boot/dts/nuvoton-npcm730-gsj.dtb: Warning (spi_bus_reg):
> Failed prerequisite 'spi_bus_bridge'
> ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:222.22-231.5: Warning
> (spi_bus_bridge): /ahb/fiu@fb000000: node name for SPI buses should be 'spi'
>   also defined
> at ../arch/arm/boot/dts/nuvoton-npcm750-evb.dts:164.22-221.5
> ../arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi:233.22-244.5: Warning
> (spi_bus_bridge): /ahb/fiu@c0000000: node name for SPI buses should be 'spi'
>   also defined
> at ../arch/arm/boot/dts/nuvoton-npcm750-evb.dts:223.22-242.5
> 
> Cheers,
> 
> Joel