From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Michal Swiatkowski'" <michal.swiatkowski@linux.intel.com>
Cc: <netdev@vger.kernel.org>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>,
<mengyuanlou@net-swift.com>, <duanqiangwen@net-swift.com>
Subject: RE: [PATCH net v2 3/3] net: ngbe: specify IRQ vector when the number of VFs is 7
Date: Thu, 26 Jun 2025 09:56:15 +0800 [thread overview]
Message-ID: <034a01dbe63d$800dc060$80294120$@trustnetic.com> (raw)
In-Reply-To: <aFvZ4miOKWbj1Xvp@mev-dev.igk.intel.com>
On Wed, Jun 25, 2025 7:14 PM, Michal Swiatkowski wrote:
> On Wed, Jun 25, 2025 at 05:27:05PM +0800, Jiawen Wu wrote:
> > > > diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_type.h b/drivers/net/ethernet/wangxun/ngbe/ngbe_type.h
> > > > index 6eca6de475f7..b6252b272364 100644
> > > > --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_type.h
> > > > +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_type.h
> > > > @@ -87,7 +87,8 @@
> > > > #define NGBE_PX_MISC_IC_TIMESYNC BIT(11) /* time sync */
> > > >
> > > > #define NGBE_INTR_ALL 0x1FF
> > > > -#define NGBE_INTR_MISC(A) BIT((A)->num_q_vectors)
> > > > +#define NGBE_INTR_MISC(A) ((A)->num_vfs == 7 ? \
> > > > + BIT(0) : BIT((A)->num_q_vectors))
> > >
> > > Isn't it problematic that configuring interrupts is done in
> > > ndo_open/ndo_stop on PF, but it depends on numvfs set in otther context.
> > > If you start with misc on index 8 and after that set numvfs to 7 isn't
> > > it fail?
> >
> > When setting num_vfs, wx->setup_tc() is called to re-init the interrupt scheme.
> >
>
> Right, maybe to be more clear you should use wx->msix_entry->entry
> wherever misc index is used.
Sure, thanks for your suggestion.
prev parent reply other threads:[~2025-06-26 1:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 8:56 [PATCH net v2 0/3] Fix IRQ vectors Jiawen Wu
2025-06-24 8:56 ` [PATCH net v2 1/3] net: txgbe: request MISC IRQ in ndo_open Jiawen Wu
2025-06-25 8:52 ` Michal Swiatkowski
2025-06-25 9:22 ` Jiawen Wu
2025-06-25 11:11 ` Michal Swiatkowski
2025-06-24 8:56 ` [PATCH net v2 2/3] net: wangxun: revert the adjustment of the IRQ vector sequence Jiawen Wu
2025-06-24 8:56 ` [PATCH net v2 3/3] net: ngbe: specify IRQ vector when the number of VFs is 7 Jiawen Wu
2025-06-25 9:00 ` Michal Swiatkowski
2025-06-25 9:27 ` Jiawen Wu
2025-06-25 11:13 ` Michal Swiatkowski
2025-06-26 1:56 ` Jiawen Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034a01dbe63d$800dc060$80294120$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.