From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 550BEC433FE for ; Mon, 18 Apr 2022 08:03:55 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-152-EL758NDBNOGaHUBeEOoYDw-1; Mon, 18 Apr 2022 04:03:51 -0400 X-MC-Unique: EL758NDBNOGaHUBeEOoYDw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6696A1014A62; Mon, 18 Apr 2022 08:03:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5410C575A5A; Mon, 18 Apr 2022 08:03:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EBB491947BBC; Mon, 18 Apr 2022 08:03:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A0D271947BBB for ; Mon, 18 Apr 2022 08:03:47 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7CD2257C929; Mon, 18 Apr 2022 08:03:47 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78A1D57C91F for ; Mon, 18 Apr 2022 08:03:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F6B71014A61 for ; Mon, 18 Apr 2022 08:03:47 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509-hulfIi8ePHyWqh2oafmwCA-1; Mon, 18 Apr 2022 04:03:45 -0400 X-MC-Unique: hulfIi8ePHyWqh2oafmwCA-1 X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; d="scan'208";a="203014631" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:03:43 +0800 IronPort-SDR: pghIC6TXwWkUldSsT5H6QPVfjdOogHQWlXP97Aw41XqE4+DppddtuawxrTRtFURaWvNrQTjA+Z pWnGtJ3EGhsRru14pF3PHw5Ol5rdN6uNpHwHylcVX5Q+XM3nJPCXu6mHLMTzrRiLsWISnqFCle tmEjzHaNtr/JLatS8aB30zAja66nEow94oa54EQpgYFUNl3vg4XaAfht9rLQYJPrOpVOunk64L fQRSftlDFM4pjjXlhsrrctt0op5v5U0nyqx3a37N4AxYpMpNJrupPO4fVtRgoicrVP1K11UbAS WOrxDRukTuZCJ59K8VlCAYSS Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 00:34:50 -0700 IronPort-SDR: 7vAwIyqpYVi+mTHTEdp/jdN5FpM5/jrIYUjkgw3UylofLSnNhDGA8r0kwR6MWNjm4nWztmtUrq 37G3OD1blryx3NhAfDS5H3SOSGe0U1TQvNd0A8wmV+rXpoIl84Falyh/eDMXmXdzhspZ1wxohR IUhDxpPTQ78zASEfDa5dlO9SGLbI+N7EcnpFPU7rLssU9RKnm3H9hbhplAS5jJcTXL1O4p/+MT ki8KQ85lKh/e1ShdNJvWFQSHUA8rxRixGb9FsXJiHiPP1EzuKhCzIAGFB/KLDU3aB17FkVR5eu hx0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 01:03:44 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfZl2rXWz1Rwrw for ; Mon, 18 Apr 2022 01:03:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HOW2jwW8mRQH for ; Mon, 18 Apr 2022 01:03:42 -0700 (PDT) Received: from [10.225.163.14] (unknown [10.225.163.14]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfZg2dWsz1Rvlx; Mon, 18 Apr 2022 01:03:39 -0700 (PDT) Message-ID: <034efb57-9e1d-41ed-1855-e2b057b03ea7@opensource.wdc.com> Date: Mon, 18 Apr 2022 17:03:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 To: Christoph Hellwig , Jens Axboe References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-12-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220418045314.360785-12-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Subject: Re: [dm-devel] [PATCH 11/11] xen-blkback: use bdev_discard_alignment X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Hoeppner , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, "Md. Haris Iqbal" , Jack Wang , linux-s390@vger.kernel.org, Richard Weinberger , xen-devel@lists.xenproject.org, Mike Snitzer , linux-um@lists.infradead.org, Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Haberland , linux-block@vger.kernel.org, "Martin K. Petersen" , Johannes Berg , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 4/18/22 13:53, Christoph Hellwig wrote: > Use bdev_discard_alignment to calculate the correct discard alignment > offset even for partitions instead of just looking at the queue limit. > > Also switch to use bdev_discard_granularity to get rid of the last direct > queue reference in xen_blkbk_discard. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/xen-blkback/xenbus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index b21bffc9c50bc..04c90cb8955f6 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -583,14 +583,14 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info > if (bdev_max_discard_sectors(bdev)) { > err = xenbus_printf(xbt, dev->nodename, > "discard-granularity", "%u", > - q->limits.discard_granularity); > + bdev_discard_granularity(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-granularity (%d)", err); > return; > } > err = xenbus_printf(xbt, dev->nodename, > "discard-alignment", "%u", > - q->limits.discard_alignment); > + bdev_discard_alignment(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-alignment (%d)", err); > return; Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA9EC433EF for ; Mon, 18 Apr 2022 08:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbiDRIG2 (ORCPT ); Mon, 18 Apr 2022 04:06:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237081AbiDRIG1 (ORCPT ); Mon, 18 Apr 2022 04:06:27 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 312C11929E for ; Mon, 18 Apr 2022 01:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650269028; x=1681805028; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rst7WZOXaJnTOprfWYkoaRENgax/3SjcG41/Nf0ZaiQ=; b=EmdD7FamYGmavx1pUGfT1fI8RCXuQt/sLKvEI6XvEoYEa8tCQJHYWMyo Da7WKAwPjA16523o9E8lfx4JbLWg8frrVTynHnbW9K4X48xKLE17yOQLs mkwASqVuZyKzzQoisr5JTJIuVDHTf26WfCZIso66cwu/xCcidWuGkO/W5 R2/CQ+sSFuMH4Emih9V5GXcnM+a6LIp0jX3c0cIm/hzBYecHWGkNHDbnr SNsZV1bfPDTMSWIFjZamgunEf/JRpA0fPKVSddWPtklGmwtuFtP0tGN0C JK6ot2tLzuYFojWRJpFcL7kjrrKZTllBi1m/OJDf+a8cDnRllznYi9wjH g==; X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; d="scan'208";a="203014638" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:03:46 +0800 IronPort-SDR: qg4Cl7IPcvzn5upJlnSQOPI4GjFMAAUC4sksChPs8GTdoOIbyzbPxPEUqvDb/ma9ocMhUqYuRn 7RCHdNDn63QkHEsqMhkzuVoNS4+giXVeCnw5yW/ZYc7fgrzt68qY/v/i/fLdjYylYOgx9axhJL sa9bvGKC824KR0cYmO+GlCDUpAZb9w/wNWS7MuOvlLLNTR2ZTJOOzj0gIhFM1mLPB2SXdbNz2w w2CAQ9UU3dQCOI9EssfEc6aE/rxppD9TVzS6KOd2ykzeTSxeDCgiFE1gOt3nFguC5KFb/HpNrQ PpbgoafvcP9lZe6Luqy2+vd7 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 00:34:08 -0700 IronPort-SDR: UXIBc3G9lc+ZdHHr1aeMrN3PMyP/9uH4Uumz19MGuqSbvWXp9C4p6ikUdDWci7s2KGOgCn+F9Z VZGPExVlxBYLDihmLCwq1xzAVGv/k3tFlhYKqOFwjSQWE4NGQDRYiFVblJVTk2c/6OphNZvmSY kAlfW4Dtdfp5qsAE/RTlzQ3y5wJfx9JbEjOAsNk8jvqJXQ3WlMPe96+L8iEvk6tvhcu7EjpQFA 9r29mzhin+hvx26P9UWq7jMCqL/1O8WGuIO/DE3oZd0Ql3Uh/9HTWNCgxSlAaXGYi+dlFKTtkx aZA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 01:03:45 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfZl4ZTHz1SVp6 for ; Mon, 18 Apr 2022 01:03:43 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1650269022; x=1652861023; bh=rst7WZOXaJnTOprfWYkoaRENgax/3SjcG41 /Nf0ZaiQ=; b=k/wWzmmm2mZiM/ewBYvITJF4lq6rUDh2cOF7medHWCRms6ali4K cmsUMPnv+11ke+dcJMqdHi78/nHqy7qP8KSBVECU/14iKM2QiwMZ5RSyv3w8qT7S xlveFRxheMNhYX6ukLpVSJjx7rJm1hUviNx0vdLPyHXo9hRa3+JS30WcAvz31Pdj REkM1jfEzC/yE6LWYc1GnErshn9kE3jwbU3zXmWIjE2FGZwQcw8k8zOw/wl74Ik/ 4p11eeyi0wRjJXJE9DwwkghyuPjiZnJUMe5TVmPA4z2xIF/G5tJciClJzAeXlh6d O8hZxw8UZiDqrwR15XLejWpz4dbpVOf4kAw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K4IWPE4JaQ6K for ; Mon, 18 Apr 2022 01:03:42 -0700 (PDT) Received: from [10.225.163.14] (unknown [10.225.163.14]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfZg2dWsz1Rvlx; Mon, 18 Apr 2022 01:03:39 -0700 (PDT) Message-ID: <034efb57-9e1d-41ed-1855-e2b057b03ea7@opensource.wdc.com> Date: Mon, 18 Apr 2022 17:03:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [dm-devel] [PATCH 11/11] xen-blkback: use bdev_discard_alignment Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Jan Hoeppner , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, "Md. Haris Iqbal" , Jack Wang , linux-s390@vger.kernel.org, Richard Weinberger , xen-devel@lists.xenproject.org, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-block@vger.kernel.org, Stefan Haberland , linux-raid@vger.kernel.org, "Martin K. Petersen" , Johannes Berg , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-12-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220418045314.360785-12-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 4/18/22 13:53, Christoph Hellwig wrote: > Use bdev_discard_alignment to calculate the correct discard alignment > offset even for partitions instead of just looking at the queue limit. > > Also switch to use bdev_discard_granularity to get rid of the last direct > queue reference in xen_blkbk_discard. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/xen-blkback/xenbus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index b21bffc9c50bc..04c90cb8955f6 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -583,14 +583,14 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info > if (bdev_max_discard_sectors(bdev)) { > err = xenbus_printf(xbt, dev->nodename, > "discard-granularity", "%u", > - q->limits.discard_granularity); > + bdev_discard_granularity(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-granularity (%d)", err); > return; > } > err = xenbus_printf(xbt, dev->nodename, > "discard-alignment", "%u", > - q->limits.discard_alignment); > + bdev_discard_alignment(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-alignment (%d)", err); > return; Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngMMN-00FvRn-4d for linux-um@lists.infradead.org; Mon, 18 Apr 2022 08:03:48 +0000 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfZl4cmyz1SVp7 for ; Mon, 18 Apr 2022 01:03:43 -0700 (PDT) Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id et7z_T9r9_KA for ; Mon, 18 Apr 2022 01:03:42 -0700 (PDT) Message-ID: <034efb57-9e1d-41ed-1855-e2b057b03ea7@opensource.wdc.com> Date: Mon, 18 Apr 2022 17:03:38 +0900 MIME-Version: 1.0 Subject: Re: [dm-devel] [PATCH 11/11] xen-blkback: use bdev_discard_alignment Content-Language: en-US References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-12-hch@lst.de> From: Damien Le Moal In-Reply-To: <20220418045314.360785-12-hch@lst.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christoph Hellwig , Jens Axboe Cc: Jan Hoeppner , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, "Md. Haris Iqbal" , Jack Wang , linux-s390@vger.kernel.org, Richard Weinberger , xen-devel@lists.xenproject.org, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-block@vger.kernel.org, Stefan Haberland , linux-raid@vger.kernel.org, "Martin K. Petersen" , Johannes Berg , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= On 4/18/22 13:53, Christoph Hellwig wrote: > Use bdev_discard_alignment to calculate the correct discard alignment > offset even for partitions instead of just looking at the queue limit. > > Also switch to use bdev_discard_granularity to get rid of the last direct > queue reference in xen_blkbk_discard. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/xen-blkback/xenbus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index b21bffc9c50bc..04c90cb8955f6 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -583,14 +583,14 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info > if (bdev_max_discard_sectors(bdev)) { > err = xenbus_printf(xbt, dev->nodename, > "discard-granularity", "%u", > - q->limits.discard_granularity); > + bdev_discard_granularity(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-granularity (%d)", err); > return; > } > err = xenbus_printf(xbt, dev->nodename, > "discard-alignment", "%u", > - q->limits.discard_alignment); > + bdev_discard_alignment(bdev)); > if (err) { > dev_warn(&dev->dev, "writing discard-alignment (%d)", err); > return; Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um