From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFECDC4743C for ; Mon, 21 Jun 2021 18:12:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D769C6100B for ; Mon, 21 Jun 2021 18:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D769C6100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B5968295C; Mon, 21 Jun 2021 20:12:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d5i0IOgu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C0C14829A6; Mon, 21 Jun 2021 20:12:21 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A79D80352 for ; Mon, 21 Jun 2021 20:12:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id l1so30374928ejb.6 for ; Mon, 21 Jun 2021 11:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PjWKkRcUOJe8pzvh2+eA4gYN6lntVVV6hexxYkWRXnQ=; b=d5i0IOguj4ubKoodRm6Zi+4Xt3Nnq1cIekY8+X3Zqe/mgAv8DSs1IutmE5l9Q/orqH /hhIgzku7M2MWH1PQvFKD48fMJFT0AZLp4noEwZGdjgpWTR0gwn/8ydUBhrs/L/u/wtA tXF6d2o9uY/gCtLOHX9gQCPxKhGpKhOmX62SiC9ojT03TnEu4G5piZepKT3LgW277isf EnmYTi0ldmgrLGkLB7ZSmEavVCxwniOTBGQ/bT994V57evZTec+clsZrtJqdFwhpEQ3P wH06wS5VjOLF4opAT+DQAW79PyWWIT/F3wDZXldTeOngxYZCw1IEsTejGflw7Kq7atxS 2UMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PjWKkRcUOJe8pzvh2+eA4gYN6lntVVV6hexxYkWRXnQ=; b=Z17hK3/5jW7U8+BN9HdS/jgdogW9Rhd1Fet//zIow0WQnhJStInWulA/jP/dds2ihQ ExFXK9BzaqIkcSDDuRxF01+RWiTN4+4Aq3Zogaf1rxjVTEOqLHUIOnAA0FdnG18QCe1p WNbfBDqI7TIqaxmJshn+nu4jfNuf9eeoZiwJJzDtpZ7RySR00neUi4+62MRql8Vphkp4 5U+LXZjKp2N3LvlPBpg10W3GNzuPGPoD/Ny6mYCfeA0q43PXvvk7ckFr0H1K6fRhCXw7 mn2jYbwi8PEJD1YndbDsw4kwVaYq5iiUyDjFWnQ9B3pY+EM8hQ0dH2WV9lDqqFP3HnMV ttlQ== X-Gm-Message-State: AOAM532QzYAg29bRuhqWctakBHQVX9x+SPxtWvz9DHSnWZjC3Pngp1Su GTADDFzoo8cYQmpldD/gTTA= X-Google-Smtp-Source: ABdhPJzVXZGcirqp3vGMclQj8aTP8vJIlbEaLs/d1Il19Y9LJe1abqebJCCFgB9piBfqxNelbRErBA== X-Received: by 2002:a17:906:478d:: with SMTP id cw13mr11800031ejc.543.1624299137127; Mon, 21 Jun 2021 11:12:17 -0700 (PDT) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id g11sm11044796edt.85.2021.06.21.11.12.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 11:12:16 -0700 (PDT) Subject: Re: [PATCH v2 1/3] tools: docker: Install a readable kernel for libguestfs-tools To: Heinrich Schuchardt , u-boot@lists.denx.de Cc: AKASHI Takahiro , Bin Meng , Tom Rini , Simon Glass , Daniel Schwierzeck , Marek Vasut References: <20210613140731.16254-1-alpernebiyasak@gmail.com> <20210613140731.16254-2-alpernebiyasak@gmail.com> From: Alper Nebi Yasak Message-ID: <0354f009-4bfa-9f17-0835-edf28a6bb9ce@gmail.com> Date: Mon, 21 Jun 2021 21:12:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 14/06/2021 20:29, Heinrich Schuchardt wrote: > On 6/13/21 4:07 PM, Alper Nebi Yasak wrote: >> >> supermin: failed to find a suitable kernel (host_cpu=x86_64). >> >> I looked for kernels in /boot and modules in /lib/modules. >> >> [...] >> >> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile >> index d2f0074ee8a6..563b16639e54 100644 >> --- a/tools/docker/Dockerfile >> +++ b/tools/docker/Dockerfile >> @@ -71,6 +71,7 @@ RUN apt-get update && apt-get install -y \ >> libssl-dev \ >> libudev-dev \ >> libusb-1.0-0-dev \ >> + linux-image-kvm \ >> lzma-alone \ >> lzop \ >> mount \ >> @@ -99,6 +100,9 @@ RUN apt-get update && apt-get install -y \ >> zip \ >> && rm -rf /var/lib/apt/lists/* >> >> +# Make kernels readable for libguestfs tools to work correctly >> +RUN chmod +r /boot/vmlinu* /lib/modules/*/vmlinu* || true > > /lib/modules/4.15.0-1092-kvm# find . -name 'vm*' > does not find any file. > > We don't need '|| true' if you do not refer to non-existent files. I included both dirs as libguestfs checks both of them. If that doesn't convince you, I can send a v3 with just `chmod +r /boot/vmlinu*`. I actually misread the error message above as mentioning both dirs for kernel so I didn't explicitly write it in the commit message, but the source code [1] confirms that both are checked. [1] https://github.com/libguestfs/supermin/blob/master/src/format_ext2_kernel.ml#L28-L49 (sorry for the late reply)