From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD6A0CCA478 for ; Thu, 2 Jun 2022 10:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jj/myS+gi0FMunwA2/OYi/17ncEE86QQocPWSDBDZZc=; b=Wi8rsE5FgU22CL /5419XD9vN1+AMNYB/NYGcZ3npAyS0fG4LTwT2uR+D5QXJkhqVjSXsiZZ9XrzO3pfoAqVhA/Zl0Xc /LXvADJXGQcYI+bWn/PnnhTj15hPgYNhQGbvDoZvWrcj/5q4p4OnGH97LqvUCr115YCIa7Noabwhf j95U+nYrgBcSIwSW18+2Sxz8EIaepNL8K6GCtHtKDm+RTuOTXDD5sYq1qLrg8ozaSnB24gR52nueA 2mXndsbRazXIg+LTw3GTdCQd+m+m81ldqvekRmBnK37QWe5xPWByA4jQuceTir0Z3ldvFLW5LDRRh MOOaJSJy+FemGF3Jn+yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhmr-002hP1-4S; Thu, 02 Jun 2022 10:10:41 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhmm-002hMT-IR for linux-phy@lists.infradead.org; Thu, 02 Jun 2022 10:10:40 +0000 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20220602101029epoutp04faf5df427edcc77f612c0f38998af3c0~0xfeCc9vo0567105671epoutp04Y for ; Thu, 2 Jun 2022 10:10:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20220602101029epoutp04faf5df427edcc77f612c0f38998af3c0~0xfeCc9vo0567105671epoutp04Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654164630; bh=7koIz/DVucBKimOwAVWE0zWB8XnPg8smoktAvfpidIs=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=SyUD3e+Uv/SsYcgNF/K8P5bOqj6SBv4rziub1PyPZzluhw6EUPghpUJjwWDgq4Gm/ PoApE7MOK9g+eY/16bSjgePYXRNn3GMaaBJgdhpyHSaA9V35iVmWSLPno9+HsoyNeE 61sZr40AJ7SZMjajtwTFU5qKPGY4Oakt+F9ZIBjE= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20220602101029epcas2p1ed37f5efcef816e7b5631b2c5ed6d998~0xfdcNpuY1582215822epcas2p15; Thu, 2 Jun 2022 10:10:29 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.98]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4LDMGC6qpRz4x9Pp; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 33.0B.10028.39C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e~0xfbbOhHn2389023890epcas2p4T; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220602101027epsmtrp2fb1a4c04dfb28473f8df4503086c9b8a~0xfbWXZsj2707927079epsmtrp2O; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) X-AuditID: b6c32a47-573ff7000000272c-45-62988c93388a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 14.BC.11276.29C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602101026epsmtip1e563cad0eb0f88870ebbd2945dffbc82~0xfbLn3tS2748227482epsmtip1d; Thu, 2 Jun 2022 10:10:26 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , , In-Reply-To: Subject: RE: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Date: Thu, 2 Jun 2022 19:10:26 +0900 Message-ID: <035e01d87668$fb2bfcf0$f183f6d0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLWkTnA63V9WykH3rm22/0hqLdk6gLMec0AAc0/rTIBlco14ALgFz+bqvcxoOA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsWy7bCmqe7knhlJBvOfG1s8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvKtslITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0 tDBXUshLzE21VXLxCdB1y8wBukxJoSwxpxQoFJBYXKykb2dTlF9akqqQkV9cYquUWpCSU2Be oFecmFtcmpeul5daYmVoYGBkClSYkJ3R+3EyY8El3ormT9uYGxhXcHUxcnJICJhITDqxhqWL kYtDSGAHo0TPp49MEM4nRonmS5OhnG+MEvu33WGFaZl48TA7RGIvo8TsVVtZIZwXjBIbfy1m AqliE9CXeNmxDSwhIjCfSeJp51WwBLPABEaJlZ+8QWxOATuJdyu7WUBsYYFEietTXzGC2CwC KhKH/kDYvAKWEhN/zmGHsAUlTs58wgIxR1ti2cLXzBAnKUj8fLoM7DwRAT+Jj/8XMkPUiEjM 7mxjBjlCQmALh8STmVOYIBpcJObv2s8OYQtLvDq+BcqWkvj8bi8bhF0ssXTWJyaI5gZGicvb fkEljCVmPWsHuo4DaIOmxPpd+iCmhICyxJFbULfxSXQc/ssOEeaV6GgTgmhUlziwfToLhC0r 0T3nM+sERqVZSD6bheSzWUg+mIWwawEjyypGsdSC4tz01GKjAmN4dCfn525iBCdbLfcdjDPe ftA7xMjEwXiIUYKDWUmEt2TX1CQh3pTEyqrUovz4otKc1OJDjKbAsJ7ILCWanA9M93kl8YYm lgYmZmaG5kamBuZK4rxeKRsShQTSE0tSs1NTC1KLYPqYODilGphiWebtWNByLaMv+4cty978 k/qS0ss4mr/N2yvoEWD+7/vM8moJ1QBD1+osg6tTdj15vNjQ+/6X4yxGpbs890TMeJ3w/PSh nCqZtviqJR+8Q5a8Kn0ss/aDs3TTx7a9mZ4Kf1MbhDu/J6338n3Gd6vuyYVNHxRFFTQ2sHwu M92YeeS0rpmgNFtPYfpktvcp3lsLBRTLZ57t00vi00i9/ZpvzZkr0W+F3aMNjx99tdj/q2cm u1t26rStnZPcF1tyr52l77xqYVS68M/dD4VX14WpPfb/xOYpV1nt4fbQ2S/t/5mKGbbaOY4c IbvPFVxbKFiZfl3u9ZHfC6dH86pUzdS587NW8QuDYcGWvL1Wm5VYijMSDbWYi4oTAWfE65g/ BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWy7bCSnO7knhlJBrNuMFo8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvisklJzcksSy3St0vgyljXdI+lYA9vxbezL1gbGPu4 uhg5OSQETCQmXjzM3sXIxSEksJtRYu2Ee8wQCVmJZ+92sEPYwhL3W46wQhQ9Y5T4/30/E0iC TUBf4mXHNrCEiMBiJon+E2fZQBxmgSmMEpevvmSBaFnOJDH7/XGwWZwCdhLvVnazgNjCAvES H+70s4HYLAIqEof+vGIEsXkFLCUm/pzDDmELSpyc+QSsnllAW+Lpzadw9rKFr6FuVZD4+XQZ K4gtIuAn8fH/QmaIGhGJ2Z1tzBMYhWchGTULyahZSEbNQtKygJFlFaNkakFxbnpusWGBYV5q uV5xYm5xaV66XnJ+7iZGcOxpae5g3L7qg94hRiYOxkOMEhzMSiK8JbumJgnxpiRWVqUW5ccX leakFh9ilOZgURLnvdB1Ml5IID2xJDU7NbUgtQgmy8TBKdXAJGfqbSg3/ahtpdlx8wClQ3qy bRckVvjXT3J/5NB4z0A1xTwg/F/ZPU3DYxekI5/0LL19UZV7trvtHYXJvrYi6+buPLTR4v+E /iPTwmavbFv2dOlv/91Pt+f8OyH9dDLPX+P26JLSuCU737618mVera+bra5+47yE/QrFxjz7 +b4C/O9v/d+8y3PvN+Za/8UdIasusv3+8U51Uzpf943r178x/ZpfE9dbktalWBh4KFXaZHfu TfaGRzr/hKVFn3N5fSrpaGxI+Oh+2NWz7r/GRWf7LPsVaoKPyk9dOiKgoPFoRxe77jH5N8vU 3DcFd/evWcoj9CVHcnnG9ccxjfubdiurv3xx/8r523suJwa9VmIpzkg01GIuKk4EAGe7vdMs AwAA X-CMS-MailID: 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220602053329epcas2p4c2baca2d161814f5d51dc48722f904b1 References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_031038_775897_A655526E X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > >> samsung,pmu-syscon: > >> - $ref: '/schemas/types.yaml#/definitions/phandle' > >> - description: phandle for PMU system controller interface, used to > >> - control pmu registers bits for ufs m-phy > >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' > >> + items: > >> + minItems: 1 > >> + items: > >> + - description: phandle for PMU system controller interface, used > to > >> + control pmu registers bits for ufs m-phy > >> + - description: offset of the pmu control register > > > > This does not work... Please test your bindings with different cases. > > Just to be clear - when I mentioned that minItems should be on second > items level, I meant it should affect the second items list, not the first. > Now you can have 1, 2 or 10 phandles. I put the minItems to the second level as you mentioned but I got below error from dt_binding_check. --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -42,8 +42,8 @@ properties: samsung,pmu-syscon: $ref: '/schemas/types.yaml#/definitions/phandle-array' items: - minItems: 1 items: + - minItems: 1 - description: phandle for PMU system controller interface, used to control pmu registers bits for ufs m-phy - description: offset of the pmu control register $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml ufs-phy@15571800: samsung,pmu-syscon:0: [4294967295, 1828] is too short Best Regards, Chanho Park -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D782DC43334 for ; Thu, 2 Jun 2022 10:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233094AbiFBKKh (ORCPT ); Thu, 2 Jun 2022 06:10:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbiFBKKg (ORCPT ); Thu, 2 Jun 2022 06:10:36 -0400 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1DEE2AD5C2 for ; Thu, 2 Jun 2022 03:10:34 -0700 (PDT) Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220602101030epoutp01e7e5f5cad3b4b073ea6ce5913e1fb43b~0xfeDmADl0612406124epoutp01_ for ; Thu, 2 Jun 2022 10:10:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220602101030epoutp01e7e5f5cad3b4b073ea6ce5913e1fb43b~0xfeDmADl0612406124epoutp01_ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654164630; bh=7koIz/DVucBKimOwAVWE0zWB8XnPg8smoktAvfpidIs=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=SyUD3e+Uv/SsYcgNF/K8P5bOqj6SBv4rziub1PyPZzluhw6EUPghpUJjwWDgq4Gm/ PoApE7MOK9g+eY/16bSjgePYXRNn3GMaaBJgdhpyHSaA9V35iVmWSLPno9+HsoyNeE 61sZr40AJ7SZMjajtwTFU5qKPGY4Oakt+F9ZIBjE= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20220602101029epcas2p1ed37f5efcef816e7b5631b2c5ed6d998~0xfdcNpuY1582215822epcas2p15; Thu, 2 Jun 2022 10:10:29 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.98]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4LDMGC6qpRz4x9Pp; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 33.0B.10028.39C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e~0xfbbOhHn2389023890epcas2p4T; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220602101027epsmtrp2fb1a4c04dfb28473f8df4503086c9b8a~0xfbWXZsj2707927079epsmtrp2O; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) X-AuditID: b6c32a47-573ff7000000272c-45-62988c93388a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 14.BC.11276.29C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602101026epsmtip1e563cad0eb0f88870ebbd2945dffbc82~0xfbLn3tS2748227482epsmtip1d; Thu, 2 Jun 2022 10:10:26 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , , In-Reply-To: Subject: RE: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Date: Thu, 2 Jun 2022 19:10:26 +0900 Message-ID: <035e01d87668$fb2bfcf0$f183f6d0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLWkTnA63V9WykH3rm22/0hqLdk6gLMec0AAc0/rTIBlco14ALgFz+bqvcxoOA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsWy7bCmqe7knhlJBvOfG1s8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvKtslITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0 tDBXUshLzE21VXLxCdB1y8wBukxJoSwxpxQoFJBYXKykb2dTlF9akqqQkV9cYquUWpCSU2Be oFecmFtcmpeul5daYmVoYGBkClSYkJ3R+3EyY8El3ormT9uYGxhXcHUxcnJICJhITDqxhqWL kYtDSGAHo0TPp49MEM4nRonmS5OhnG+MEvu33WGFaZl48TA7RGIvo8TsVVtZIZwXjBIbfy1m AqliE9CXeNmxDSwhIjCfSeJp51WwBLPABEaJlZ+8QWxOATuJdyu7WUBsYYFEietTXzGC2CwC KhKH/kDYvAKWEhN/zmGHsAUlTs58wgIxR1ti2cLXzBAnKUj8fLoM7DwRAT+Jj/8XMkPUiEjM 7mxjBjlCQmALh8STmVOYIBpcJObv2s8OYQtLvDq+BcqWkvj8bi8bhF0ssXTWJyaI5gZGicvb fkEljCVmPWsHuo4DaIOmxPpd+iCmhICyxJFbULfxSXQc/ssOEeaV6GgTgmhUlziwfToLhC0r 0T3nM+sERqVZSD6bheSzWUg+mIWwawEjyypGsdSC4tz01GKjAmN4dCfn525iBCdbLfcdjDPe ftA7xMjEwXiIUYKDWUmEt2TX1CQh3pTEyqrUovz4otKc1OJDjKbAsJ7ILCWanA9M93kl8YYm lgYmZmaG5kamBuZK4rxeKRsShQTSE0tSs1NTC1KLYPqYODilGphiWebtWNByLaMv+4cty978 k/qS0ss4mr/N2yvoEWD+7/vM8moJ1QBD1+osg6tTdj15vNjQ+/6X4yxGpbs890TMeJ3w/PSh nCqZtviqJR+8Q5a8Kn0ss/aDs3TTx7a9mZ4Kf1MbhDu/J6338n3Gd6vuyYVNHxRFFTQ2sHwu M92YeeS0rpmgNFtPYfpktvcp3lsLBRTLZ57t00vi00i9/ZpvzZkr0W+F3aMNjx99tdj/q2cm u1t26rStnZPcF1tyr52l77xqYVS68M/dD4VX14WpPfb/xOYpV1nt4fbQ2S/t/5mKGbbaOY4c IbvPFVxbKFiZfl3u9ZHfC6dH86pUzdS587NW8QuDYcGWvL1Wm5VYijMSDbWYi4oTAWfE65g/ BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWy7bCSnO7knhlJBrNuMFo8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvisklJzcksSy3St0vgyljXdI+lYA9vxbezL1gbGPu4 uhg5OSQETCQmXjzM3sXIxSEksJtRYu2Ee8wQCVmJZ+92sEPYwhL3W46wQhQ9Y5T4/30/E0iC TUBf4mXHNrCEiMBiJon+E2fZQBxmgSmMEpevvmSBaFnOJDH7/XGwWZwCdhLvVnazgNjCAvES H+70s4HYLAIqEof+vGIEsXkFLCUm/pzDDmELSpyc+QSsnllAW+Lpzadw9rKFr6FuVZD4+XQZ K4gtIuAn8fH/QmaIGhGJ2Z1tzBMYhWchGTULyahZSEbNQtKygJFlFaNkakFxbnpusWGBYV5q uV5xYm5xaV66XnJ+7iZGcOxpae5g3L7qg94hRiYOxkOMEhzMSiK8JbumJgnxpiRWVqUW5ccX leakFh9ilOZgURLnvdB1Ml5IID2xJDU7NbUgtQgmy8TBKdXAJGfqbSg3/ahtpdlx8wClQ3qy bRckVvjXT3J/5NB4z0A1xTwg/F/ZPU3DYxekI5/0LL19UZV7trvtHYXJvrYi6+buPLTR4v+E /iPTwmavbFv2dOlv/91Pt+f8OyH9dDLPX+P26JLSuCU737618mVera+bra5+47yE/QrFxjz7 +b4C/O9v/d+8y3PvN+Za/8UdIasusv3+8U51Uzpf943r178x/ZpfE9dbktalWBh4KFXaZHfu TfaGRzr/hKVFn3N5fSrpaGxI+Oh+2NWz7r/GRWf7LPsVaoKPyk9dOiKgoPFoRxe77jH5N8vU 3DcFd/evWcoj9CVHcnnG9ccxjfubdiurv3xx/8r523suJwa9VmIpzkg01GIuKk4EAGe7vdMs AwAA X-CMS-MailID: 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220602053329epcas2p4c2baca2d161814f5d51dc48722f904b1 References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org > >> samsung,pmu-syscon: > >> - =24ref: '/schemas/types.yaml=23/definitions/phandle' > >> - description: phandle for PMU system controller interface, used to > >> - control pmu registers bits for ufs m-phy > >> + =24ref: '/schemas/types.yaml=23/definitions/phandle-array' > >> + items: > >> + minItems: 1 > >> + items: > >> + - description: phandle for PMU system controller interface, u= sed > to > >> + control pmu registers bits for ufs m-phy > >> + - description: offset of the pmu control register > > > > This does not work... Please test your bindings with different cases. >=20 > Just to be clear - when I mentioned that minItems should be on second > items level, I meant it should affect the second items list, not the firs= t. > Now you can have 1, 2 or 10 phandles. I put the minItems to the second level as you mentioned but I got below err= or from dt_binding_check. --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml =40=40 -42,8 +42,8 =40=40 properties: samsung,pmu-syscon: =24ref: '/schemas/types.yaml=23/definitions/phandle-array' items: - minItems: 1 items: + - minItems: 1 - description: phandle for PMU system controller interface, used t= o control pmu registers bits for ufs m-phy - description: offset of the pmu control register =24 make dt_binding_check DT_SCHEMA_FILES=3DDocumentation/devicetree/bindin= gs/phy/samsung,ufs-phy.yaml ufs-phy=4015571800: samsung,pmu-syscon:0: =5B4294967295, 1828=5D is too sho= rt Best Regards, Chanho Park From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74ACDC433EF for ; Thu, 2 Jun 2022 10:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zAvZRNLM7zlabN1MHzI6gIVzue8SggDVZw3PiHUqyOQ=; b=HdmLigNziF3qyA 3nF4pU7CixHJ7gjepG9rCvgRRZukiBjDCbq9Xfy6V4sTjIJhcyE0EgrCSV8dpSbLqZDcr+MYnRXE0 HJtZqv6i677lhqBVvxpemO8Zd1uQy9FBWf7aj2YwGjaKKUq6PnM6oGprWw4b3/ZUfXYHb43hkqFd0 WbpEOSD/EDTBr4Tnjg9OVhvPYe9+J/6a2zVCAV4OYDlcSGCNnO3nzvbiguQBGML7ufpN/dxKS8pMv YLNKRB5ajUYO6lSnWHOMMCsCsyJsh6u1Y3SUaw4kHKeFt2lRI135o0QBJfhSFKv2I3CFRdFYCP3i/ HJ4YlZOusucKrds0pLRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhmx-002hRU-Q9; Thu, 02 Jun 2022 10:10:48 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhmt-002hN5-ID for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 10:10:45 +0000 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220602101029epoutp036ef57a95597a2335654b35669d0417df~0xfd3cI5m1080510805epoutp03w for ; Thu, 2 Jun 2022 10:10:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220602101029epoutp036ef57a95597a2335654b35669d0417df~0xfd3cI5m1080510805epoutp03w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654164629; bh=7koIz/DVucBKimOwAVWE0zWB8XnPg8smoktAvfpidIs=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=U+DIy2rMVwy87ufA7dRUNPwCxBDYix7pnghkobxRztNul+ZDlB/NGB8t2acUl1Rnd OtjaT6FzjgttoJvUwdtT1qgrVasaMAR6XA5aIDbhSK+05dY9UwLXlRKORmzirI871l LnRmHRkCc+1aGzQPtgnxV72J8DgLySBi1U0nTVUY= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20220602101029epcas2p1ed37f5efcef816e7b5631b2c5ed6d998~0xfdcNpuY1582215822epcas2p15; Thu, 2 Jun 2022 10:10:29 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.98]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4LDMGC6qpRz4x9Pp; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 33.0B.10028.39C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e~0xfbbOhHn2389023890epcas2p4T; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220602101027epsmtrp2fb1a4c04dfb28473f8df4503086c9b8a~0xfbWXZsj2707927079epsmtrp2O; Thu, 2 Jun 2022 10:10:27 +0000 (GMT) X-AuditID: b6c32a47-573ff7000000272c-45-62988c93388a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 14.BC.11276.29C88926; Thu, 2 Jun 2022 19:10:27 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602101026epsmtip1e563cad0eb0f88870ebbd2945dffbc82~0xfbLn3tS2748227482epsmtip1d; Thu, 2 Jun 2022 10:10:26 +0000 (GMT) From: "Chanho Park" To: "'Krzysztof Kozlowski'" , "'Kishon Vijay Abraham I'" , "'Vinod Koul'" , "'Alim Akhtar'" , "'Rob Herring'" , "'Krzysztof Kozlowski'" Cc: , , , In-Reply-To: Subject: RE: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Date: Thu, 2 Jun 2022 19:10:26 +0900 Message-ID: <035e01d87668$fb2bfcf0$f183f6d0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLWkTnA63V9WykH3rm22/0hqLdk6gLMec0AAc0/rTIBlco14ALgFz+bqvcxoOA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsWy7bCmqe7knhlJBvOfG1s8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvKtslITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0 tDBXUshLzE21VXLxCdB1y8wBukxJoSwxpxQoFJBYXKykb2dTlF9akqqQkV9cYquUWpCSU2Be oFecmFtcmpeul5daYmVoYGBkClSYkJ3R+3EyY8El3ormT9uYGxhXcHUxcnJICJhITDqxhqWL kYtDSGAHo0TPp49MEM4nRonmS5OhnG+MEvu33WGFaZl48TA7RGIvo8TsVVtZIZwXjBIbfy1m AqliE9CXeNmxDSwhIjCfSeJp51WwBLPABEaJlZ+8QWxOATuJdyu7WUBsYYFEietTXzGC2CwC KhKH/kDYvAKWEhN/zmGHsAUlTs58wgIxR1ti2cLXzBAnKUj8fLoM7DwRAT+Jj/8XMkPUiEjM 7mxjBjlCQmALh8STmVOYIBpcJObv2s8OYQtLvDq+BcqWkvj8bi8bhF0ssXTWJyaI5gZGicvb fkEljCVmPWsHuo4DaIOmxPpd+iCmhICyxJFbULfxSXQc/ssOEeaV6GgTgmhUlziwfToLhC0r 0T3nM+sERqVZSD6bheSzWUg+mIWwawEjyypGsdSC4tz01GKjAmN4dCfn525iBCdbLfcdjDPe ftA7xMjEwXiIUYKDWUmEt2TX1CQh3pTEyqrUovz4otKc1OJDjKbAsJ7ILCWanA9M93kl8YYm lgYmZmaG5kamBuZK4rxeKRsShQTSE0tSs1NTC1KLYPqYODilGphiWebtWNByLaMv+4cty978 k/qS0ss4mr/N2yvoEWD+7/vM8moJ1QBD1+osg6tTdj15vNjQ+/6X4yxGpbs890TMeJ3w/PSh nCqZtviqJR+8Q5a8Kn0ss/aDs3TTx7a9mZ4Kf1MbhDu/J6338n3Gd6vuyYVNHxRFFTQ2sHwu M92YeeS0rpmgNFtPYfpktvcp3lsLBRTLZ57t00vi00i9/ZpvzZkr0W+F3aMNjx99tdj/q2cm u1t26rStnZPcF1tyr52l77xqYVS68M/dD4VX14WpPfb/xOYpV1nt4fbQ2S/t/5mKGbbaOY4c IbvPFVxbKFiZfl3u9ZHfC6dH86pUzdS587NW8QuDYcGWvL1Wm5VYijMSDbWYi4oTAWfE65g/ BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWy7bCSnO7knhlJBrNuMFo8mLeNzWL+kXOs Fhee9rBZ9L14yGyx9/VWdotNj6+xWkxY9Y3FYsb5fUwWrXuPsFvsvHOC2YHLY9OqTjaPO9f2 sHlsXlLv0bdlFaPH8RvbmTw+b5ILYIvisklJzcksSy3St0vgyljXdI+lYA9vxbezL1gbGPu4 uhg5OSQETCQmXjzM3sXIxSEksJtRYu2Ee8wQCVmJZ+92sEPYwhL3W46wQhQ9Y5T4/30/E0iC TUBf4mXHNrCEiMBiJon+E2fZQBxmgSmMEpevvmSBaFnOJDH7/XGwWZwCdhLvVnazgNjCAvES H+70s4HYLAIqEof+vGIEsXkFLCUm/pzDDmELSpyc+QSsnllAW+Lpzadw9rKFr6FuVZD4+XQZ K4gtIuAn8fH/QmaIGhGJ2Z1tzBMYhWchGTULyahZSEbNQtKygJFlFaNkakFxbnpusWGBYV5q uV5xYm5xaV66XnJ+7iZGcOxpae5g3L7qg94hRiYOxkOMEhzMSiK8JbumJgnxpiRWVqUW5ccX leakFh9ilOZgURLnvdB1Ml5IID2xJDU7NbUgtQgmy8TBKdXAJGfqbSg3/ahtpdlx8wClQ3qy bRckVvjXT3J/5NB4z0A1xTwg/F/ZPU3DYxekI5/0LL19UZV7trvtHYXJvrYi6+buPLTR4v+E /iPTwmavbFv2dOlv/91Pt+f8OyH9dDLPX+P26JLSuCU737618mVera+bra5+47yE/QrFxjz7 +b4C/O9v/d+8y3PvN+Za/8UdIasusv3+8U51Uzpf943r178x/ZpfE9dbktalWBh4KFXaZHfu TfaGRzr/hKVFn3N5fSrpaGxI+Oh+2NWz7r/GRWf7LPsVaoKPyk9dOiKgoPFoRxe77jH5N8vU 3DcFd/evWcoj9CVHcnnG9ccxjfubdiurv3xx/8r523suJwa9VmIpzkg01GIuKk4EAGe7vdMs AwAA X-CMS-MailID: 20220602101027epcas2p41c9f5360805c7aa8479560bae156286e X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220602053329epcas2p4c2baca2d161814f5d51dc48722f904b1 References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_031044_010515_9CDF5D22 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > >> samsung,pmu-syscon: > >> - $ref: '/schemas/types.yaml#/definitions/phandle' > >> - description: phandle for PMU system controller interface, used to > >> - control pmu registers bits for ufs m-phy > >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' > >> + items: > >> + minItems: 1 > >> + items: > >> + - description: phandle for PMU system controller interface, used > to > >> + control pmu registers bits for ufs m-phy > >> + - description: offset of the pmu control register > > > > This does not work... Please test your bindings with different cases. > > Just to be clear - when I mentioned that minItems should be on second > items level, I meant it should affect the second items list, not the first. > Now you can have 1, 2 or 10 phandles. I put the minItems to the second level as you mentioned but I got below error from dt_binding_check. --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -42,8 +42,8 @@ properties: samsung,pmu-syscon: $ref: '/schemas/types.yaml#/definitions/phandle-array' items: - minItems: 1 items: + - minItems: 1 - description: phandle for PMU system controller interface, used to control pmu registers bits for ufs m-phy - description: offset of the pmu control register $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml ufs-phy@15571800: samsung,pmu-syscon:0: [4294967295, 1828] is too short Best Regards, Chanho Park _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel