From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50A62C433EF for ; Tue, 8 Mar 2022 03:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zijtQJqOnSdn6uAX8HlK/c1Q3Bq2oJE70VBVshQ3Tlk=; b=xTXtHw3Qg1s6Sg KahMxv3D4qbfPRFHoEVDZEj1db0Sf2HnkUeV3hPVgjZAWniwruYPL9DgmfsB2BvQDgCuPVc14sc80 c1/EjwPASBB4GaSdnna9xOx65HAfAUdxZWP9ERL/xVBK0m+Prx5m8w1UaVdMgPXg/AaLlrCohxOrC 9gqTUjS4rmp5MIsq/cs2e9uddvhGLs9hCXXC+MGJEdoYkoEl/nx+RAyJFNTd51KQE9Pxmppo+0asY qnZt9yotup0Xbgbr2r0/gjEooL72teIZM/iuqN99EW6IOamiYVIFQiWrSnl4OW6XkKmAilJTSHJcp /H/PDx3/3Axn7XNpnEaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRQZW-002Xhe-CT; Tue, 08 Mar 2022 03:31:38 +0000 Received: from mail-m121144.qiye.163.com ([115.236.121.144]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRQZJ-002Xg3-S3; Tue, 08 Mar 2022 03:31:28 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 1E19CAC03A0; Tue, 8 Mar 2022 11:31:23 +0800 (CST) Message-ID: <035f2dfd-bf35-abca-32bf-2be85cc88f8a@rock-chips.com> Date: Tue, 8 Mar 2022 11:31:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk Content-Language: en-US To: Dmitry Osipenko , Sascha Hauer , Robin Murphy , elaine.zhang@rock-chips.com Cc: devicetree@vger.kernel.org, Benjamin Gaignard , kernel@pengutronix.de, Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Dmitry Osipenko , linux-arm-kernel@lists.infradead.org, Kever Yang , algea.cao@rock-chips.com, huangtao@rock-chips.com References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-11-s.hauer@pengutronix.de> <47ddcaf3-4544-2b7c-a2f6-1f6346907f33@gmail.com> <20220225104924.GC19585@pengutronix.de> <78207d97-b5a1-9792-8ec9-11fcf2e00370@gmail.com> <90c61299-f02c-607b-4734-7134852ef0a6@arm.com> <20220225131154.GE19585@pengutronix.de> <20220228141921.GN19585@pengutronix.de> <5184ecf2-8734-3121-cbbc-5dcfcf0d02f8@arm.com> <20220302112528.GV19585@pengutronix.de> <20220304142235.GL22780@pengutronix.de> <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> From: Andy Yan In-Reply-To: <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRpNSE5WSRhDHRpKGB hLGUpKVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBQ6Ayo4PT5RNzItAx8xDhYL N1FPC0tVSlVKTU9NTEpLSUNIQk5LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBQkNPQjcG X-HM-Tid: 0a7f6794dd93b039kuuu1e19cac03a0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_193126_253449_579387D9 X-CRM114-Status: GOOD ( 34.18 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgOgoKT24gMy81LzIyIDA3OjU1LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gT24gMy80LzIy IDE3OjIyLCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+IE9uIFdlZCwgTWFyIDAyLCAyMDIyIGF0IDEy OjI1OjI4UE0gKzAxMDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+IE9uIFR1ZSwgTWFyIDAxLCAy MDIyIGF0IDAxOjM5OjMxUE0gKzAwMDAsIFJvYmluIE11cnBoeSB3cm90ZToKPj4+PiBPbiAyMDIy LTAyLTI4IDE0OjE5LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+Pj4+IE9uIEZyaSwgRmViIDI1LCAy MDIyIGF0IDAyOjExOjU0UE0gKzAxMDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4+IE9uIEZy aSwgRmViIDI1LCAyMDIyIGF0IDEyOjQxOjIzUE0gKzAwMDAsIFJvYmluIE11cnBoeSB3cm90ZToK Pj4+Pj4+PiBPbiAyMDIyLTAyLTI1IDExOjEwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+Pj4+ Pj4+IDI1LjAyLjIwMjIgMTM6NDksIFNhc2NoYSBIYXVlciDQv9C40YjQtdGCOgo+Pj4+Pj4+Pj4g T24gRnJpLCBGZWIgMjUsIDIwMjIgYXQgMDE6MjY6MTRQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+Pj4+Pj4+Pj4+IDI1LjAyLjIwMjIgMTA6NTEsIFNhc2NoYSBIYXVlciDQv9C40YjQ tdGCOgo+Pj4+Pj4+Pj4+PiBUaGUgcmszNTY4IEhETUkgaGFzIGFuIGFkZGl0aW9uYWwgY2xvY2sg dGhhdCBuZWVkcyB0byBiZSBlbmFibGVkIGZvciB0aGUKPj4+Pj4+Pj4+Pj4gSERNSSBjb250cm9s bGVyIHRvIHdvcmsuIFRoZSBwdXJwb3NlIG9mIHRoYXQgY2xvY2sgaXMgbm90IGNsZWFyLiBJdCBp cwo+Pj4+Pj4+Pj4+PiBuYW1lZCAiaGNsayIgaW4gdGhlIGRvd25zdHJlYW0gZHJpdmVyLCBzbyB1 c2UgdGhlIHNhbWUgbmFtZS4KPj4+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTog U2FzY2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJvbml4LmRlPgo+Pj4+Pj4+Pj4+PiAtLS0KPj4+ Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gTm90ZXM6Cj4+Pj4+Pj4+Pj4+ICAgICAgICBDaGFuZ2VzIHNp bmNlIHY1Ogo+Pj4+Pj4+Pj4+PiAgICAgICAgLSBVc2UgZGV2bV9jbGtfZ2V0X29wdGlvbmFsIHJh dGhlciB0aGFuIGRldm1fY2xrX2dldAo+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiAgICAgZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYyB8IDE2ICsrKysrKysrKysrKysr KysKPj4+Pj4+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspCj4+Pj4+ Pj4+Pj4+Cj4+Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv ZHdfaGRtaS1yb2NrY2hpcC5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9j a2NoaXAuYwo+Pj4+Pj4+Pj4+PiBpbmRleCBmZTRmOTU1NjIzOWFjLi5jNmMwMGU4Nzc5YWI1IDEw MDY0NAo+Pj4+Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHdfaGRtaS1y b2NrY2hpcC5jCj4+Pj4+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kd19o ZG1pLXJvY2tjaGlwLmMKPj4+Pj4+Pj4+Pj4gQEAgLTc2LDYgKzc2LDcgQEAgc3RydWN0IHJvY2tj aGlwX2hkbWkgewo+Pj4+Pj4+Pj4+PiAgICAgCWNvbnN0IHN0cnVjdCByb2NrY2hpcF9oZG1pX2No aXBfZGF0YSAqY2hpcF9kYXRhOwo+Pj4+Pj4+Pj4+PiAgICAgCXN0cnVjdCBjbGsgKnJlZl9jbGs7 Cj4+Pj4+Pj4+Pj4+ICAgICAJc3RydWN0IGNsayAqZ3JmX2NsazsKPj4+Pj4+Pj4+Pj4gKwlzdHJ1 Y3QgY2xrICpoY2xrX2NsazsKPj4+Pj4+Pj4+Pj4gICAgIAlzdHJ1Y3QgZHdfaGRtaSAqaGRtaTsK Pj4+Pj4+Pj4+Pj4gICAgIAlzdHJ1Y3QgcmVndWxhdG9yICphdmRkXzB2OTsKPj4+Pj4+Pj4+Pj4g ICAgIAlzdHJ1Y3QgcmVndWxhdG9yICphdmRkXzF2ODsKPj4+Pj4+Pj4+Pj4gQEAgLTIyOSw2ICsy MzAsMTQgQEAgc3RhdGljIGludCByb2NrY2hpcF9oZG1pX3BhcnNlX2R0KHN0cnVjdCByb2NrY2hp cF9oZG1pICpoZG1pKQo+Pj4+Pj4+Pj4+PiAgICAgCQlyZXR1cm4gUFRSX0VSUihoZG1pLT5ncmZf Y2xrKTsKPj4+Pj4+Pj4+Pj4gICAgIAl9Cj4+Pj4+Pj4+Pj4+ICsJaGRtaS0+aGNsa19jbGsgPSBk ZXZtX2Nsa19nZXRfb3B0aW9uYWwoaGRtaS0+ZGV2LCAiaGNsayIpOwo+Pj4+Pj4+Pj4+PiArCWlm IChQVFJfRVJSKGhkbWktPmhjbGtfY2xrKSA9PSAtRVBST0JFX0RFRkVSKSB7Cj4+Pj4+Pj4+Pj4g SGF2ZSB5b3UgdHJpZWQgdG8gaW52ZXN0aWdhdGUgdGhlIGhjbGs/IEknbSBzdGlsbCB0aGlua2lu ZyB0aGF0J3Mgbm90Cj4+Pj4+Pj4+Pj4gb25seSBIRE1JIHRoYXQgbmVlZHMgdGhpcyBjbG9jayBh bmQgdGhlbiB0aGUgaGFyZHdhcmUgZGVzY3JpcHRpb24KPj4+Pj4+Pj4+PiBkb2Vzbid0IGxvb2sg Y29ycmVjdC4KPj4+Pj4+Pj4+IEkgYW0gc3RpbGwgbm90IHN1cmUgd2hhdCB5b3UgbWVhbi4gWWVz LCBpdCdzIG5vdCBvbmx5IHRoZSBIRE1JIHRoYXQKPj4+Pj4+Pj4+IG5lZWRzIHRoaXMgY2xvY2su IFRoZSBWT1AyIG5lZWRzIGl0IGFzIHdlbGwgYW5kIHRoZSBkcml2ZXIgaGFuZGxlcyB0aGF0Lgo+ Pj4+Pj4+PiBJJ20gY3VyaW91cyB3aGV0aGVyIERTSS9EUCBhbHNvIG5lZWQgdGhhdCBjbG9jayB0 byBiZSBlbmFibGVkLiBJZiB0aGV5Cj4+Pj4+Pj4+IGRvLCB0aGVuIHlvdSBhcmVuJ3QgbW9kZWxp bmcgaC93IHByb3Blcmx5IEFGQUlDUy4KPj4+Pj4+PiBBc3N1bWluZyBub2JvZHkgYXQgUm9ja2No aXAgZGVjaWRlZCB0byBtYWtlIHRoaW5ncyBuZWVkbGVzc2x5IGluY29uc2lzdGVudAo+Pj4+Pj4+ IHdpdGggcHJldmlvdXMgU29DcywgSENMS19WT1Agc2hvdWxkIGJlIHRoZSBjbG9jayBmb3IgdGhl IFZPUCdzIEFIQiBzbGF2ZQo+Pj4+Pj4+IGludGVyZmFjZS4gVXN1YWxseSwgaWYgdGhhdCBhZmZl Y3RlZCBhbnl0aGluZyBvdGhlciB0aGFuIGFjY2Vzc2luZyBWT1AKPj4+Pj4+PiByZWdpc3RlcnMs IGluZGVlZCBpdCB3b3VsZCBzbWVsbCBvZiBzb21ldGhpbmcgYmVpbmcgd3JvbmcgaW4gdGhlIGNs b2NrIHRyZWUsCj4+Pj4+Pj4gYnV0IGluIHRoaXMgY2FzZSBJJ2QgYWxzbyBiZSBzdXNwaWNpb3Vz IG9mIHdoZXRoZXIgaXQgbWlnaHQgaGF2ZSBlbmRlZCB1cAo+Pj4+Pj4+IGNsb2NraW5nIHJlbGF0 ZWQgR1JGIHJlZ2lzdGVycyBhcyB3ZWxsIChlaXRoZXIgZGlyZWN0bHksIG9yIGluZGlyZWN0bHkg dmlhCj4+Pj4+Pj4gc29tZSBnYXRlIHRoYXQgdGhlIGNsb2NrIGRyaXZlciBoYXNuJ3QgbW9kZWxs ZWQgeWV0KS4KPj4+Pj4+IE9rLCBJIGFtIGJlZ2lubmluZyB0byB1bmRlcnN0YW5kLiBJIHZlcmlm aWVkIHRoYXQgaGRtaSwgbWlwaSBhbmQgZHAgYXJlCj4+Pj4+PiBoYW5naW5nIHdoZW4gSENMS19W T1AgaXMgZGlzYWJsZWQgYnkgZGlzYWJsaW5nIHRoYXQgY2xvY2sgdmlhIHN5c2ZzCj4+Pj4+PiB1 c2luZyBDTE9DS19BTExPV19XUklURV9ERUJVR0ZTLiBXaGVuIGl0J3MgZGlzYWJsZWQgdGhlbiB0 aGUgcmVnaXN0ZXJzCj4+Pj4+PiBvZiB0aGF0IHVuaXRzIGNhbid0IGJlIGFjY2Vzc2VkLiBIb3dl dmVyLCB3aGVuIEkgZGlzYWJsZSBIQ0xLX1ZPUCBieQo+Pj4+Pj4gZGlyZWN0bHkgd3JpdGluZyB0 byB0aGUgZ2F0ZSBiaXQgUkszNTY4X0NMS0dBVEVfQ09OKDIwKSB0aGVuIG9ubHkKPj4+Pj4+IGFj Y2Vzc2luZyBWT1AgcmVnaXN0ZXJzIGhhbmdzLCB0aGUgb3RoZXIgdW5pdHMgc3RheSBmdW5jdGlv bmFsLgo+Pj4+Pj4gU28gaXQgc2VlbXMgaXQgbXVzdCBiZSB0aGUgcGFyZW50IGNsb2NrIHdoaWNo IG11c3QgYmUgZW5hYmxlZC4gVGhlCj4+Pj4+PiBwYXJlbnQgY2xvY2sgaXMgaGNsa192by4gVGhp cyBjbG9jayBzaG91bGQgYmUgaGFuZGxlZCBhcyBwYXJ0IG9mIHRoZQo+Pj4+Pj4gUkszNTY4X1BE X1ZPIHBvd2VyIGRvbWFpbjoKPj4+Pj4+Cj4+Pj4+PiAJcG93ZXItZG9tYWluQFJLMzU2OF9QRF9W TyB7Cj4+Pj4+PiAgICAgICAgICAgICAgICAgICByZWcgPSA8UkszNTY4X1BEX1ZPPjsKPj4+Pj4+ ICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1IEhDTEtfVk8+LAo+Pj4+Pj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgPCZjcnUgUENMS19WTz4sCj4+Pj4+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICA8JmNydSBBQ0xLX1ZPUF9QUkU+Owo+Pj4+Pj4gICAgICAgICAgICAgICAg ICAgIHBtX3FvcyA9IDwmcW9zX2hkY3A+LAo+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDwmcW9zX3ZvcF9tMD4sCj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZx b3Nfdm9wX20xPjsKPj4+Pj4+ICAgICAgICAgICAgICAgICAgICAjcG93ZXItZG9tYWluLWNlbGxz ID0gPDA+Owo+Pj4+Pj4gICAgICAgICAgIH07Cj4+Pj4+IEZvcmdldCB0aGlzLiBUaGUgY2xvY2tz IGluIHRoaXMgbm9kZSBhcmUgb25seSBlbmFibGVkIGR1cmluZyBlbmFibGluZyBvcgo+Pj4+PiBk aXNhYmxpbmcgdGhlIHBvd2VyIGRvbWFpbiwgdGhleSBhcmUgZGlzYWJsZWQgYWdhaW4gaW1tZWRp YXRlbHkgYWZ0ZXJ3YXJkcy4KPj4+Pj4KPj4+Pj4gT0ssIEkgbmVlZCBIQ0xLX1ZPIHRvIGFjY2Vz cyB0aGUgSERNSSByZWdpc3RlcnMuIEkgdmVyaWZpZWQgdGhhdCBieQo+Pj4+PiBkaXNhYmxpbmcg SENMS19WTyBhdCByZWdpc3RlciBsZXZlbCAoQ1JVX0dBVEVfQ09OKDIwKSBCSVQoMSkpLiBUaGUK Pj4+Pj4gSERNSSByZWdpc3RlcnMgYmVjb21lIGluYWNjZXNzaWJsZSB0aGVuLiBUaGlzIG1lYW5z IEknbGwgcmVwbGFjZQo+Pj4+PiBIQ0xLX1ZPUCBpbiB0aGUgSERNSSBub2RlIHdpdGggSENMS19W Ty4gRG9lcyB0aGlzIHNvdW5kIHNhbmU/Cj4+Pj4gV2VsbCwgaXQncyBzdGlsbCBhIG15c3Rlcnkg aGFjayBvdmVyYWxsLCBhbmQgaW4gc29tZSB3YXlzIGl0IHNlZW1zIGV2ZW4gbW9yZQo+Pj4+IHN1 c3BlY3QgdG8gYmUgY2xhaW1pbmcgYSB3aG9sZSBicmFuY2ggb2YgdGhlIGNsb2NrIHRyZWUgcmF0 aGVyIHRoYW4gYSBsZWFmCj4+Pj4gZ2F0ZSB3aXRoIGEgc3BlY2lmaWMgcHVycG9zZS4gSSdtIHJl YWxseSBzdGFydGluZyB0byB0aGluayB0aGF0IHRoZQo+Pj4+IHVuZGVybHlpbmcgaXNzdWUgaGVy ZSBpcyBhIGJ1ZyBpbiB0aGUgY2xvY2sgZHJpdmVyLCBvciBhIGhhcmR3YXJlIG1pc2hhcAo+Pj4+ IHRoYXQgc2hvdWxkIGxvZ2ljYWxseSBiZSB3b3JrZWQgYXJvdW5kIGJ5IHRoZSBjbG9jayBkcml2 ZXIsIHJhdGhlciB0aGFuCj4+Pj4gaW5kaXZpZHVhbCB0aGUgY29uc3VtZXJzLgo+Pj4+Cj4+Pj4g RG9lcyBpdCB3b3JrIGlmIHlvdSBoYWNrIHRoZSBjbG9jayBkcml2ZXIgdG8gdGhpbmsgdGhhdCBQ Q0xLX1ZPIGlzIGEgY2hpbGQKPj4+PiBvZiBIQ0xLX1ZPPyBFdmVuIGlmIHRoYXQncyBub3QgdGVj aG5pY2FsbHkgdHJ1ZSwgaXQgd291bGQgc2VlbSB0bwo+Pj4+IGVmZmVjdGl2ZWx5IG1hdGNoIHRo ZSBvYnNlcnZlZCBiZWhhdmlvdXIgKGkuZS4gYWxsIDMgdGhpbmdzIHdob3NlIHJlZ2lzdGVyCj4+ Pj4gYWNjZXNzIGFwcGFyZW50bHkgKnNob3VsZCogYmUgZW5hYmxlZCBieSBhIGdhdGUgb2ZmIFBD TEtfVk8sIHNlZW0gdG8gYWxzbwo+Pj4+IHJlcXVpcmUgSENMS19WTykuCj4+PiBZZXMsIHRoYXQg d29ya3MgYXMgZXhwZWN0ZWQuIEkgYW0gbm90IHN1cmUgdGhvdWdoIGlmIHdlIHJlYWxseSB3YW50 IHRvCj4+PiBnbyB0aGF0IHBhdGguIFRoZSBwY2xrIHJhdGVzIHdpbGwgYmVjb21lIGNvbXBsZXRl bHkgYm9ndXMgd2l0aCB0aGlzIGFuZAo+Pj4gc2hvdWxkIHdlIGhhdmUgdG8gcGxheSB3aXRoIHRo ZSByYXRlcyBpbiB0aGUgZnV0dXJlIHdlIG1pZ2h0IHJlZ3JldCB0aGlzCj4+PiBzdGVwLgo+PiBI b3cgZG8gd2UgcHJvY2VlZCBoZXJlPyBJIGNhbiBpbmNsdWRlIGEgcGF0Y2ggd2hpY2ggbWFrZXMg UENMS19WTyBhCj4+IGNoaWxkIG9mIEhDTEtfVk8gaWYgdGhhdCdzIHdoYXQgd2UgYWdyZWUgdXBv bi4KPiBDb3VsZG4ndCBBbmR5IGNsYXJpZnkgdGhlIGFjdHVhbCBjbG9jayB0cmVlIHN0cnVjdHVy ZSBvZiB0aGUgaC93IGZvciB1cz8KPgo+IFRoaXMgd2lsbCBiZSB0aGUgYmVzdCBvcHRpb24gYmVj YXVzZSBkYXRhc2hlZXQgZG9lc24ndCBnaXZlIHRoZSBjbGVhcgo+IGFuc3dlciwgb3IgYXQgbGVh c3QgSSBjb3VsZG4ndCBmaW5kIGl0LiBUZWNobmljYWxseSwgUENMSyBpbmRlZWQgc2hvdWxkCj4g YmUgYSBjaGlsZCBvZiB0aGUgSENMSyBpbiBnZW5lcmFsLCBzbyBSb2JpbiBjb3VsZCBiZSByaWdo dC4KCgpBZGQgb3VyIGNsayBleHBlcnQgRWxhaW5lLCBzaGUgd2lsbCBzaGFyZSBzb21lIGluZm9y bWF0aW9uIGFib3V0IHRoZSAKYWN0dWFsIGNsb2NrIHN0cnVjdHVyZS4KCgo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gTGludXgtcm9ja2NoaXAgbWFp bGluZyBsaXN0Cj4gTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlw IG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63FB0C433FE for ; Tue, 8 Mar 2022 03:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6DjKFWIAm8lOPGtNsjhuHHpKdyFq0T8k+kJUEupF6w0=; b=dkix5CgcnMfnxW ewAuIoQnAbJE+6TG4T9Wljlk8tloFJTuhvCBF3xDDph7zrLTYmOQheBVkWjx2RMzAIkGu3wmiN3bA hNZ9qMyELg14JbyPs99mPePzNpi9UtLpi7U1RfEN69peAuq5L03kxpxJ8Nt8fep8Mn0netq04auMw HrW+/ErVj+x8KkagpJwQxUUWtAqDXofiLWMJ0dwJTo/npvaJ6WmEe7MvsOWEJpSyy5el22L0mfXUL c5M7gssYr5gKAOlPfFjV88gxhvvL71RQmDnRBvZoAQeySql117323OMB3cN9fpG8GHKzXHyCM1vEC Us2vnV5xitobJn6nmG8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRQZN-002Xgh-V5; Tue, 08 Mar 2022 03:31:30 +0000 Received: from mail-m121144.qiye.163.com ([115.236.121.144]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRQZJ-002Xg3-S3; Tue, 08 Mar 2022 03:31:28 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 1E19CAC03A0; Tue, 8 Mar 2022 11:31:23 +0800 (CST) Message-ID: <035f2dfd-bf35-abca-32bf-2be85cc88f8a@rock-chips.com> Date: Tue, 8 Mar 2022 11:31:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk Content-Language: en-US To: Dmitry Osipenko , Sascha Hauer , Robin Murphy , elaine.zhang@rock-chips.com Cc: devicetree@vger.kernel.org, Benjamin Gaignard , kernel@pengutronix.de, Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Dmitry Osipenko , linux-arm-kernel@lists.infradead.org, Kever Yang , algea.cao@rock-chips.com, huangtao@rock-chips.com References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-11-s.hauer@pengutronix.de> <47ddcaf3-4544-2b7c-a2f6-1f6346907f33@gmail.com> <20220225104924.GC19585@pengutronix.de> <78207d97-b5a1-9792-8ec9-11fcf2e00370@gmail.com> <90c61299-f02c-607b-4734-7134852ef0a6@arm.com> <20220225131154.GE19585@pengutronix.de> <20220228141921.GN19585@pengutronix.de> <5184ecf2-8734-3121-cbbc-5dcfcf0d02f8@arm.com> <20220302112528.GV19585@pengutronix.de> <20220304142235.GL22780@pengutronix.de> <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> From: Andy Yan In-Reply-To: <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRpNSE5WSRhDHRpKGB hLGUpKVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBQ6Ayo4PT5RNzItAx8xDhYL N1FPC0tVSlVKTU9NTEpLSUNIQk5LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBQkNPQjcG X-HM-Tid: 0a7f6794dd93b039kuuu1e19cac03a0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_193126_253449_579387D9 X-CRM114-Status: GOOD ( 34.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgOgoKT24gMy81LzIyIDA3OjU1LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gT24gMy80LzIy IDE3OjIyLCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+IE9uIFdlZCwgTWFyIDAyLCAyMDIyIGF0IDEy OjI1OjI4UE0gKzAxMDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+IE9uIFR1ZSwgTWFyIDAxLCAy MDIyIGF0IDAxOjM5OjMxUE0gKzAwMDAsIFJvYmluIE11cnBoeSB3cm90ZToKPj4+PiBPbiAyMDIy LTAyLTI4IDE0OjE5LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+Pj4+IE9uIEZyaSwgRmViIDI1LCAy MDIyIGF0IDAyOjExOjU0UE0gKzAxMDAsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4+IE9uIEZy aSwgRmViIDI1LCAyMDIyIGF0IDEyOjQxOjIzUE0gKzAwMDAsIFJvYmluIE11cnBoeSB3cm90ZToK Pj4+Pj4+PiBPbiAyMDIyLTAyLTI1IDExOjEwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+Pj4+ Pj4+IDI1LjAyLjIwMjIgMTM6NDksIFNhc2NoYSBIYXVlciDQv9C40YjQtdGCOgo+Pj4+Pj4+Pj4g T24gRnJpLCBGZWIgMjUsIDIwMjIgYXQgMDE6MjY6MTRQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+Pj4+Pj4+Pj4+IDI1LjAyLjIwMjIgMTA6NTEsIFNhc2NoYSBIYXVlciDQv9C40YjQ tdGCOgo+Pj4+Pj4+Pj4+PiBUaGUgcmszNTY4IEhETUkgaGFzIGFuIGFkZGl0aW9uYWwgY2xvY2sg dGhhdCBuZWVkcyB0byBiZSBlbmFibGVkIGZvciB0aGUKPj4+Pj4+Pj4+Pj4gSERNSSBjb250cm9s bGVyIHRvIHdvcmsuIFRoZSBwdXJwb3NlIG9mIHRoYXQgY2xvY2sgaXMgbm90IGNsZWFyLiBJdCBp cwo+Pj4+Pj4+Pj4+PiBuYW1lZCAiaGNsayIgaW4gdGhlIGRvd25zdHJlYW0gZHJpdmVyLCBzbyB1 c2UgdGhlIHNhbWUgbmFtZS4KPj4+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTog U2FzY2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJvbml4LmRlPgo+Pj4+Pj4+Pj4+PiAtLS0KPj4+ Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gTm90ZXM6Cj4+Pj4+Pj4+Pj4+ICAgICAgICBDaGFuZ2VzIHNp bmNlIHY1Ogo+Pj4+Pj4+Pj4+PiAgICAgICAgLSBVc2UgZGV2bV9jbGtfZ2V0X29wdGlvbmFsIHJh dGhlciB0aGFuIGRldm1fY2xrX2dldAo+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiAgICAgZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYyB8IDE2ICsrKysrKysrKysrKysr KysKPj4+Pj4+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspCj4+Pj4+ Pj4+Pj4+Cj4+Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv ZHdfaGRtaS1yb2NrY2hpcC5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9j a2NoaXAuYwo+Pj4+Pj4+Pj4+PiBpbmRleCBmZTRmOTU1NjIzOWFjLi5jNmMwMGU4Nzc5YWI1IDEw MDY0NAo+Pj4+Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHdfaGRtaS1y b2NrY2hpcC5jCj4+Pj4+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kd19o ZG1pLXJvY2tjaGlwLmMKPj4+Pj4+Pj4+Pj4gQEAgLTc2LDYgKzc2LDcgQEAgc3RydWN0IHJvY2tj aGlwX2hkbWkgewo+Pj4+Pj4+Pj4+PiAgICAgCWNvbnN0IHN0cnVjdCByb2NrY2hpcF9oZG1pX2No aXBfZGF0YSAqY2hpcF9kYXRhOwo+Pj4+Pj4+Pj4+PiAgICAgCXN0cnVjdCBjbGsgKnJlZl9jbGs7 Cj4+Pj4+Pj4+Pj4+ICAgICAJc3RydWN0IGNsayAqZ3JmX2NsazsKPj4+Pj4+Pj4+Pj4gKwlzdHJ1 Y3QgY2xrICpoY2xrX2NsazsKPj4+Pj4+Pj4+Pj4gICAgIAlzdHJ1Y3QgZHdfaGRtaSAqaGRtaTsK Pj4+Pj4+Pj4+Pj4gICAgIAlzdHJ1Y3QgcmVndWxhdG9yICphdmRkXzB2OTsKPj4+Pj4+Pj4+Pj4g ICAgIAlzdHJ1Y3QgcmVndWxhdG9yICphdmRkXzF2ODsKPj4+Pj4+Pj4+Pj4gQEAgLTIyOSw2ICsy MzAsMTQgQEAgc3RhdGljIGludCByb2NrY2hpcF9oZG1pX3BhcnNlX2R0KHN0cnVjdCByb2NrY2hp cF9oZG1pICpoZG1pKQo+Pj4+Pj4+Pj4+PiAgICAgCQlyZXR1cm4gUFRSX0VSUihoZG1pLT5ncmZf Y2xrKTsKPj4+Pj4+Pj4+Pj4gICAgIAl9Cj4+Pj4+Pj4+Pj4+ICsJaGRtaS0+aGNsa19jbGsgPSBk ZXZtX2Nsa19nZXRfb3B0aW9uYWwoaGRtaS0+ZGV2LCAiaGNsayIpOwo+Pj4+Pj4+Pj4+PiArCWlm IChQVFJfRVJSKGhkbWktPmhjbGtfY2xrKSA9PSAtRVBST0JFX0RFRkVSKSB7Cj4+Pj4+Pj4+Pj4g SGF2ZSB5b3UgdHJpZWQgdG8gaW52ZXN0aWdhdGUgdGhlIGhjbGs/IEknbSBzdGlsbCB0aGlua2lu ZyB0aGF0J3Mgbm90Cj4+Pj4+Pj4+Pj4gb25seSBIRE1JIHRoYXQgbmVlZHMgdGhpcyBjbG9jayBh bmQgdGhlbiB0aGUgaGFyZHdhcmUgZGVzY3JpcHRpb24KPj4+Pj4+Pj4+PiBkb2Vzbid0IGxvb2sg Y29ycmVjdC4KPj4+Pj4+Pj4+IEkgYW0gc3RpbGwgbm90IHN1cmUgd2hhdCB5b3UgbWVhbi4gWWVz LCBpdCdzIG5vdCBvbmx5IHRoZSBIRE1JIHRoYXQKPj4+Pj4+Pj4+IG5lZWRzIHRoaXMgY2xvY2su IFRoZSBWT1AyIG5lZWRzIGl0IGFzIHdlbGwgYW5kIHRoZSBkcml2ZXIgaGFuZGxlcyB0aGF0Lgo+ Pj4+Pj4+PiBJJ20gY3VyaW91cyB3aGV0aGVyIERTSS9EUCBhbHNvIG5lZWQgdGhhdCBjbG9jayB0 byBiZSBlbmFibGVkLiBJZiB0aGV5Cj4+Pj4+Pj4+IGRvLCB0aGVuIHlvdSBhcmVuJ3QgbW9kZWxp bmcgaC93IHByb3Blcmx5IEFGQUlDUy4KPj4+Pj4+PiBBc3N1bWluZyBub2JvZHkgYXQgUm9ja2No aXAgZGVjaWRlZCB0byBtYWtlIHRoaW5ncyBuZWVkbGVzc2x5IGluY29uc2lzdGVudAo+Pj4+Pj4+ IHdpdGggcHJldmlvdXMgU29DcywgSENMS19WT1Agc2hvdWxkIGJlIHRoZSBjbG9jayBmb3IgdGhl IFZPUCdzIEFIQiBzbGF2ZQo+Pj4+Pj4+IGludGVyZmFjZS4gVXN1YWxseSwgaWYgdGhhdCBhZmZl Y3RlZCBhbnl0aGluZyBvdGhlciB0aGFuIGFjY2Vzc2luZyBWT1AKPj4+Pj4+PiByZWdpc3RlcnMs IGluZGVlZCBpdCB3b3VsZCBzbWVsbCBvZiBzb21ldGhpbmcgYmVpbmcgd3JvbmcgaW4gdGhlIGNs b2NrIHRyZWUsCj4+Pj4+Pj4gYnV0IGluIHRoaXMgY2FzZSBJJ2QgYWxzbyBiZSBzdXNwaWNpb3Vz IG9mIHdoZXRoZXIgaXQgbWlnaHQgaGF2ZSBlbmRlZCB1cAo+Pj4+Pj4+IGNsb2NraW5nIHJlbGF0 ZWQgR1JGIHJlZ2lzdGVycyBhcyB3ZWxsIChlaXRoZXIgZGlyZWN0bHksIG9yIGluZGlyZWN0bHkg dmlhCj4+Pj4+Pj4gc29tZSBnYXRlIHRoYXQgdGhlIGNsb2NrIGRyaXZlciBoYXNuJ3QgbW9kZWxs ZWQgeWV0KS4KPj4+Pj4+IE9rLCBJIGFtIGJlZ2lubmluZyB0byB1bmRlcnN0YW5kLiBJIHZlcmlm aWVkIHRoYXQgaGRtaSwgbWlwaSBhbmQgZHAgYXJlCj4+Pj4+PiBoYW5naW5nIHdoZW4gSENMS19W T1AgaXMgZGlzYWJsZWQgYnkgZGlzYWJsaW5nIHRoYXQgY2xvY2sgdmlhIHN5c2ZzCj4+Pj4+PiB1 c2luZyBDTE9DS19BTExPV19XUklURV9ERUJVR0ZTLiBXaGVuIGl0J3MgZGlzYWJsZWQgdGhlbiB0 aGUgcmVnaXN0ZXJzCj4+Pj4+PiBvZiB0aGF0IHVuaXRzIGNhbid0IGJlIGFjY2Vzc2VkLiBIb3dl dmVyLCB3aGVuIEkgZGlzYWJsZSBIQ0xLX1ZPUCBieQo+Pj4+Pj4gZGlyZWN0bHkgd3JpdGluZyB0 byB0aGUgZ2F0ZSBiaXQgUkszNTY4X0NMS0dBVEVfQ09OKDIwKSB0aGVuIG9ubHkKPj4+Pj4+IGFj Y2Vzc2luZyBWT1AgcmVnaXN0ZXJzIGhhbmdzLCB0aGUgb3RoZXIgdW5pdHMgc3RheSBmdW5jdGlv bmFsLgo+Pj4+Pj4gU28gaXQgc2VlbXMgaXQgbXVzdCBiZSB0aGUgcGFyZW50IGNsb2NrIHdoaWNo IG11c3QgYmUgZW5hYmxlZC4gVGhlCj4+Pj4+PiBwYXJlbnQgY2xvY2sgaXMgaGNsa192by4gVGhp cyBjbG9jayBzaG91bGQgYmUgaGFuZGxlZCBhcyBwYXJ0IG9mIHRoZQo+Pj4+Pj4gUkszNTY4X1BE X1ZPIHBvd2VyIGRvbWFpbjoKPj4+Pj4+Cj4+Pj4+PiAJcG93ZXItZG9tYWluQFJLMzU2OF9QRF9W TyB7Cj4+Pj4+PiAgICAgICAgICAgICAgICAgICByZWcgPSA8UkszNTY4X1BEX1ZPPjsKPj4+Pj4+ ICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY3J1IEhDTEtfVk8+LAo+Pj4+Pj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgPCZjcnUgUENMS19WTz4sCj4+Pj4+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICA8JmNydSBBQ0xLX1ZPUF9QUkU+Owo+Pj4+Pj4gICAgICAgICAgICAgICAg ICAgIHBtX3FvcyA9IDwmcW9zX2hkY3A+LAo+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDwmcW9zX3ZvcF9tMD4sCj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZx b3Nfdm9wX20xPjsKPj4+Pj4+ICAgICAgICAgICAgICAgICAgICAjcG93ZXItZG9tYWluLWNlbGxz ID0gPDA+Owo+Pj4+Pj4gICAgICAgICAgIH07Cj4+Pj4+IEZvcmdldCB0aGlzLiBUaGUgY2xvY2tz IGluIHRoaXMgbm9kZSBhcmUgb25seSBlbmFibGVkIGR1cmluZyBlbmFibGluZyBvcgo+Pj4+PiBk aXNhYmxpbmcgdGhlIHBvd2VyIGRvbWFpbiwgdGhleSBhcmUgZGlzYWJsZWQgYWdhaW4gaW1tZWRp YXRlbHkgYWZ0ZXJ3YXJkcy4KPj4+Pj4KPj4+Pj4gT0ssIEkgbmVlZCBIQ0xLX1ZPIHRvIGFjY2Vz cyB0aGUgSERNSSByZWdpc3RlcnMuIEkgdmVyaWZpZWQgdGhhdCBieQo+Pj4+PiBkaXNhYmxpbmcg SENMS19WTyBhdCByZWdpc3RlciBsZXZlbCAoQ1JVX0dBVEVfQ09OKDIwKSBCSVQoMSkpLiBUaGUK Pj4+Pj4gSERNSSByZWdpc3RlcnMgYmVjb21lIGluYWNjZXNzaWJsZSB0aGVuLiBUaGlzIG1lYW5z IEknbGwgcmVwbGFjZQo+Pj4+PiBIQ0xLX1ZPUCBpbiB0aGUgSERNSSBub2RlIHdpdGggSENMS19W Ty4gRG9lcyB0aGlzIHNvdW5kIHNhbmU/Cj4+Pj4gV2VsbCwgaXQncyBzdGlsbCBhIG15c3Rlcnkg aGFjayBvdmVyYWxsLCBhbmQgaW4gc29tZSB3YXlzIGl0IHNlZW1zIGV2ZW4gbW9yZQo+Pj4+IHN1 c3BlY3QgdG8gYmUgY2xhaW1pbmcgYSB3aG9sZSBicmFuY2ggb2YgdGhlIGNsb2NrIHRyZWUgcmF0 aGVyIHRoYW4gYSBsZWFmCj4+Pj4gZ2F0ZSB3aXRoIGEgc3BlY2lmaWMgcHVycG9zZS4gSSdtIHJl YWxseSBzdGFydGluZyB0byB0aGluayB0aGF0IHRoZQo+Pj4+IHVuZGVybHlpbmcgaXNzdWUgaGVy ZSBpcyBhIGJ1ZyBpbiB0aGUgY2xvY2sgZHJpdmVyLCBvciBhIGhhcmR3YXJlIG1pc2hhcAo+Pj4+ IHRoYXQgc2hvdWxkIGxvZ2ljYWxseSBiZSB3b3JrZWQgYXJvdW5kIGJ5IHRoZSBjbG9jayBkcml2 ZXIsIHJhdGhlciB0aGFuCj4+Pj4gaW5kaXZpZHVhbCB0aGUgY29uc3VtZXJzLgo+Pj4+Cj4+Pj4g RG9lcyBpdCB3b3JrIGlmIHlvdSBoYWNrIHRoZSBjbG9jayBkcml2ZXIgdG8gdGhpbmsgdGhhdCBQ Q0xLX1ZPIGlzIGEgY2hpbGQKPj4+PiBvZiBIQ0xLX1ZPPyBFdmVuIGlmIHRoYXQncyBub3QgdGVj aG5pY2FsbHkgdHJ1ZSwgaXQgd291bGQgc2VlbSB0bwo+Pj4+IGVmZmVjdGl2ZWx5IG1hdGNoIHRo ZSBvYnNlcnZlZCBiZWhhdmlvdXIgKGkuZS4gYWxsIDMgdGhpbmdzIHdob3NlIHJlZ2lzdGVyCj4+ Pj4gYWNjZXNzIGFwcGFyZW50bHkgKnNob3VsZCogYmUgZW5hYmxlZCBieSBhIGdhdGUgb2ZmIFBD TEtfVk8sIHNlZW0gdG8gYWxzbwo+Pj4+IHJlcXVpcmUgSENMS19WTykuCj4+PiBZZXMsIHRoYXQg d29ya3MgYXMgZXhwZWN0ZWQuIEkgYW0gbm90IHN1cmUgdGhvdWdoIGlmIHdlIHJlYWxseSB3YW50 IHRvCj4+PiBnbyB0aGF0IHBhdGguIFRoZSBwY2xrIHJhdGVzIHdpbGwgYmVjb21lIGNvbXBsZXRl bHkgYm9ndXMgd2l0aCB0aGlzIGFuZAo+Pj4gc2hvdWxkIHdlIGhhdmUgdG8gcGxheSB3aXRoIHRo ZSByYXRlcyBpbiB0aGUgZnV0dXJlIHdlIG1pZ2h0IHJlZ3JldCB0aGlzCj4+PiBzdGVwLgo+PiBI b3cgZG8gd2UgcHJvY2VlZCBoZXJlPyBJIGNhbiBpbmNsdWRlIGEgcGF0Y2ggd2hpY2ggbWFrZXMg UENMS19WTyBhCj4+IGNoaWxkIG9mIEhDTEtfVk8gaWYgdGhhdCdzIHdoYXQgd2UgYWdyZWUgdXBv bi4KPiBDb3VsZG4ndCBBbmR5IGNsYXJpZnkgdGhlIGFjdHVhbCBjbG9jayB0cmVlIHN0cnVjdHVy ZSBvZiB0aGUgaC93IGZvciB1cz8KPgo+IFRoaXMgd2lsbCBiZSB0aGUgYmVzdCBvcHRpb24gYmVj YXVzZSBkYXRhc2hlZXQgZG9lc24ndCBnaXZlIHRoZSBjbGVhcgo+IGFuc3dlciwgb3IgYXQgbGVh c3QgSSBjb3VsZG4ndCBmaW5kIGl0LiBUZWNobmljYWxseSwgUENMSyBpbmRlZWQgc2hvdWxkCj4g YmUgYSBjaGlsZCBvZiB0aGUgSENMSyBpbiBnZW5lcmFsLCBzbyBSb2JpbiBjb3VsZCBiZSByaWdo dC4KCgpBZGQgb3VyIGNsayBleHBlcnQgRWxhaW5lLCBzaGUgd2lsbCBzaGFyZSBzb21lIGluZm9y bWF0aW9uIGFib3V0IHRoZSAKYWN0dWFsIGNsb2NrIHN0cnVjdHVyZS4KCgo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gTGludXgtcm9ja2NoaXAgbWFp bGluZyBsaXN0Cj4gTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038D2C433FE for ; Tue, 8 Mar 2022 03:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238945AbiCHDcY (ORCPT ); Mon, 7 Mar 2022 22:32:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233825AbiCHDcV (ORCPT ); Mon, 7 Mar 2022 22:32:21 -0500 Received: from mail-m121144.qiye.163.com (mail-m121144.qiye.163.com [115.236.121.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84E232D1FF for ; Mon, 7 Mar 2022 19:31:25 -0800 (PST) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 1E19CAC03A0; Tue, 8 Mar 2022 11:31:23 +0800 (CST) Message-ID: <035f2dfd-bf35-abca-32bf-2be85cc88f8a@rock-chips.com> Date: Tue, 8 Mar 2022 11:31:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk Content-Language: en-US To: Dmitry Osipenko , Sascha Hauer , Robin Murphy , elaine.zhang@rock-chips.com Cc: devicetree@vger.kernel.org, Benjamin Gaignard , kernel@pengutronix.de, Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Dmitry Osipenko , linux-arm-kernel@lists.infradead.org, Kever Yang , algea.cao@rock-chips.com, huangtao@rock-chips.com References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-11-s.hauer@pengutronix.de> <47ddcaf3-4544-2b7c-a2f6-1f6346907f33@gmail.com> <20220225104924.GC19585@pengutronix.de> <78207d97-b5a1-9792-8ec9-11fcf2e00370@gmail.com> <90c61299-f02c-607b-4734-7134852ef0a6@arm.com> <20220225131154.GE19585@pengutronix.de> <20220228141921.GN19585@pengutronix.de> <5184ecf2-8734-3121-cbbc-5dcfcf0d02f8@arm.com> <20220302112528.GV19585@pengutronix.de> <20220304142235.GL22780@pengutronix.de> <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> From: Andy Yan In-Reply-To: <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRpNSE5WSRhDHRpKGB hLGUpKVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBQ6Ayo4PT5RNzItAx8xDhYL N1FPC0tVSlVKTU9NTEpLSUNIQk5LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBQkNPQjcG X-HM-Tid: 0a7f6794dd93b039kuuu1e19cac03a0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi : On 3/5/22 07:55, Dmitry Osipenko wrote: > On 3/4/22 17:22, Sascha Hauer wrote: >> On Wed, Mar 02, 2022 at 12:25:28PM +0100, Sascha Hauer wrote: >>> On Tue, Mar 01, 2022 at 01:39:31PM +0000, Robin Murphy wrote: >>>> On 2022-02-28 14:19, Sascha Hauer wrote: >>>>> On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: >>>>>> On Fri, Feb 25, 2022 at 12:41:23PM +0000, Robin Murphy wrote: >>>>>>> On 2022-02-25 11:10, Dmitry Osipenko wrote: >>>>>>>> 25.02.2022 13:49, Sascha Hauer пишет: >>>>>>>>> On Fri, Feb 25, 2022 at 01:26:14PM +0300, Dmitry Osipenko wrote: >>>>>>>>>> 25.02.2022 10:51, Sascha Hauer пишет: >>>>>>>>>>> The rk3568 HDMI has an additional clock that needs to be enabled for the >>>>>>>>>>> HDMI controller to work. The purpose of that clock is not clear. It is >>>>>>>>>>> named "hclk" in the downstream driver, so use the same name. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Sascha Hauer >>>>>>>>>>> --- >>>>>>>>>>> >>>>>>>>>>> Notes: >>>>>>>>>>> Changes since v5: >>>>>>>>>>> - Use devm_clk_get_optional rather than devm_clk_get >>>>>>>>>>> >>>>>>>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++++++++++++++++ >>>>>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> index fe4f9556239ac..c6c00e8779ab5 100644 >>>>>>>>>>> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> @@ -76,6 +76,7 @@ struct rockchip_hdmi { >>>>>>>>>>> const struct rockchip_hdmi_chip_data *chip_data; >>>>>>>>>>> struct clk *ref_clk; >>>>>>>>>>> struct clk *grf_clk; >>>>>>>>>>> + struct clk *hclk_clk; >>>>>>>>>>> struct dw_hdmi *hdmi; >>>>>>>>>>> struct regulator *avdd_0v9; >>>>>>>>>>> struct regulator *avdd_1v8; >>>>>>>>>>> @@ -229,6 +230,14 @@ static int rockchip_hdmi_parse_dt(struct rockchip_hdmi *hdmi) >>>>>>>>>>> return PTR_ERR(hdmi->grf_clk); >>>>>>>>>>> } >>>>>>>>>>> + hdmi->hclk_clk = devm_clk_get_optional(hdmi->dev, "hclk"); >>>>>>>>>>> + if (PTR_ERR(hdmi->hclk_clk) == -EPROBE_DEFER) { >>>>>>>>>> Have you tried to investigate the hclk? I'm still thinking that's not >>>>>>>>>> only HDMI that needs this clock and then the hardware description >>>>>>>>>> doesn't look correct. >>>>>>>>> I am still not sure what you mean. Yes, it's not only the HDMI that >>>>>>>>> needs this clock. The VOP2 needs it as well and the driver handles that. >>>>>>>> I'm curious whether DSI/DP also need that clock to be enabled. If they >>>>>>>> do, then you aren't modeling h/w properly AFAICS. >>>>>>> Assuming nobody at Rockchip decided to make things needlessly inconsistent >>>>>>> with previous SoCs, HCLK_VOP should be the clock for the VOP's AHB slave >>>>>>> interface. Usually, if that affected anything other than accessing VOP >>>>>>> registers, indeed it would smell of something being wrong in the clock tree, >>>>>>> but in this case I'd also be suspicious of whether it might have ended up >>>>>>> clocking related GRF registers as well (either directly, or indirectly via >>>>>>> some gate that the clock driver hasn't modelled yet). >>>>>> Ok, I am beginning to understand. I verified that hdmi, mipi and dp are >>>>>> hanging when HCLK_VOP is disabled by disabling that clock via sysfs >>>>>> using CLOCK_ALLOW_WRITE_DEBUGFS. When it's disabled then the registers >>>>>> of that units can't be accessed. However, when I disable HCLK_VOP by >>>>>> directly writing to the gate bit RK3568_CLKGATE_CON(20) then only >>>>>> accessing VOP registers hangs, the other units stay functional. >>>>>> So it seems it must be the parent clock which must be enabled. The >>>>>> parent clock is hclk_vo. This clock should be handled as part of the >>>>>> RK3568_PD_VO power domain: >>>>>> >>>>>> power-domain@RK3568_PD_VO { >>>>>> reg = ; >>>>>> clocks = <&cru HCLK_VO>, >>>>>> <&cru PCLK_VO>, >>>>>> <&cru ACLK_VOP_PRE>; >>>>>> pm_qos = <&qos_hdcp>, >>>>>> <&qos_vop_m0>, >>>>>> <&qos_vop_m1>; >>>>>> #power-domain-cells = <0>; >>>>>> }; >>>>> Forget this. The clocks in this node are only enabled during enabling or >>>>> disabling the power domain, they are disabled again immediately afterwards. >>>>> >>>>> OK, I need HCLK_VO to access the HDMI registers. I verified that by >>>>> disabling HCLK_VO at register level (CRU_GATE_CON(20) BIT(1)). The >>>>> HDMI registers become inaccessible then. This means I'll replace >>>>> HCLK_VOP in the HDMI node with HCLK_VO. Does this sound sane? >>>> Well, it's still a mystery hack overall, and in some ways it seems even more >>>> suspect to be claiming a whole branch of the clock tree rather than a leaf >>>> gate with a specific purpose. I'm really starting to think that the >>>> underlying issue here is a bug in the clock driver, or a hardware mishap >>>> that should logically be worked around by the clock driver, rather than >>>> individual the consumers. >>>> >>>> Does it work if you hack the clock driver to think that PCLK_VO is a child >>>> of HCLK_VO? Even if that's not technically true, it would seem to >>>> effectively match the observed behaviour (i.e. all 3 things whose register >>>> access apparently *should* be enabled by a gate off PCLK_VO, seem to also >>>> require HCLK_VO). >>> Yes, that works as expected. I am not sure though if we really want to >>> go that path. The pclk rates will become completely bogus with this and >>> should we have to play with the rates in the future we might regret this >>> step. >> How do we proceed here? I can include a patch which makes PCLK_VO a >> child of HCLK_VO if that's what we agree upon. > Couldn't Andy clarify the actual clock tree structure of the h/w for us? > > This will be the best option because datasheet doesn't give the clear > answer, or at least I couldn't find it. Technically, PCLK indeed should > be a child of the HCLK in general, so Robin could be right. Add our clk expert Elaine, she will share some information about the actual clock structure. > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3181AC433EF for ; Tue, 8 Mar 2022 03:31:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1777010E4EC; Tue, 8 Mar 2022 03:31:27 +0000 (UTC) Received: from mail-m121144.qiye.163.com (mail-m121144.qiye.163.com [115.236.121.144]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5D8F10E4EC for ; Tue, 8 Mar 2022 03:31:25 +0000 (UTC) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 1E19CAC03A0; Tue, 8 Mar 2022 11:31:23 +0800 (CST) Message-ID: <035f2dfd-bf35-abca-32bf-2be85cc88f8a@rock-chips.com> Date: Tue, 8 Mar 2022 11:31:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk Content-Language: en-US To: Dmitry Osipenko , Sascha Hauer , Robin Murphy , elaine.zhang@rock-chips.com References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-11-s.hauer@pengutronix.de> <47ddcaf3-4544-2b7c-a2f6-1f6346907f33@gmail.com> <20220225104924.GC19585@pengutronix.de> <78207d97-b5a1-9792-8ec9-11fcf2e00370@gmail.com> <90c61299-f02c-607b-4734-7134852ef0a6@arm.com> <20220225131154.GE19585@pengutronix.de> <20220228141921.GN19585@pengutronix.de> <5184ecf2-8734-3121-cbbc-5dcfcf0d02f8@arm.com> <20220302112528.GV19585@pengutronix.de> <20220304142235.GL22780@pengutronix.de> <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> From: Andy Yan In-Reply-To: <9ea0134e-aac7-60e1-5c58-ae31b4e1c422@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRpNSE5WSRhDHRpKGB hLGUpKVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBQ6Ayo4PT5RNzItAx8xDhYL N1FPC0tVSlVKTU9NTEpLSUNIQk5LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBQkNPQjcG X-HM-Tid: 0a7f6794dd93b039kuuu1e19cac03a0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org, algea.cao@rock-chips.com, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, Kever Yang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Dmitry Osipenko , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi : On 3/5/22 07:55, Dmitry Osipenko wrote: > On 3/4/22 17:22, Sascha Hauer wrote: >> On Wed, Mar 02, 2022 at 12:25:28PM +0100, Sascha Hauer wrote: >>> On Tue, Mar 01, 2022 at 01:39:31PM +0000, Robin Murphy wrote: >>>> On 2022-02-28 14:19, Sascha Hauer wrote: >>>>> On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: >>>>>> On Fri, Feb 25, 2022 at 12:41:23PM +0000, Robin Murphy wrote: >>>>>>> On 2022-02-25 11:10, Dmitry Osipenko wrote: >>>>>>>> 25.02.2022 13:49, Sascha Hauer пишет: >>>>>>>>> On Fri, Feb 25, 2022 at 01:26:14PM +0300, Dmitry Osipenko wrote: >>>>>>>>>> 25.02.2022 10:51, Sascha Hauer пишет: >>>>>>>>>>> The rk3568 HDMI has an additional clock that needs to be enabled for the >>>>>>>>>>> HDMI controller to work. The purpose of that clock is not clear. It is >>>>>>>>>>> named "hclk" in the downstream driver, so use the same name. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Sascha Hauer >>>>>>>>>>> --- >>>>>>>>>>> >>>>>>>>>>> Notes: >>>>>>>>>>> Changes since v5: >>>>>>>>>>> - Use devm_clk_get_optional rather than devm_clk_get >>>>>>>>>>> >>>>>>>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++++++++++++++++ >>>>>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> index fe4f9556239ac..c6c00e8779ab5 100644 >>>>>>>>>>> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>>>>>>> @@ -76,6 +76,7 @@ struct rockchip_hdmi { >>>>>>>>>>> const struct rockchip_hdmi_chip_data *chip_data; >>>>>>>>>>> struct clk *ref_clk; >>>>>>>>>>> struct clk *grf_clk; >>>>>>>>>>> + struct clk *hclk_clk; >>>>>>>>>>> struct dw_hdmi *hdmi; >>>>>>>>>>> struct regulator *avdd_0v9; >>>>>>>>>>> struct regulator *avdd_1v8; >>>>>>>>>>> @@ -229,6 +230,14 @@ static int rockchip_hdmi_parse_dt(struct rockchip_hdmi *hdmi) >>>>>>>>>>> return PTR_ERR(hdmi->grf_clk); >>>>>>>>>>> } >>>>>>>>>>> + hdmi->hclk_clk = devm_clk_get_optional(hdmi->dev, "hclk"); >>>>>>>>>>> + if (PTR_ERR(hdmi->hclk_clk) == -EPROBE_DEFER) { >>>>>>>>>> Have you tried to investigate the hclk? I'm still thinking that's not >>>>>>>>>> only HDMI that needs this clock and then the hardware description >>>>>>>>>> doesn't look correct. >>>>>>>>> I am still not sure what you mean. Yes, it's not only the HDMI that >>>>>>>>> needs this clock. The VOP2 needs it as well and the driver handles that. >>>>>>>> I'm curious whether DSI/DP also need that clock to be enabled. If they >>>>>>>> do, then you aren't modeling h/w properly AFAICS. >>>>>>> Assuming nobody at Rockchip decided to make things needlessly inconsistent >>>>>>> with previous SoCs, HCLK_VOP should be the clock for the VOP's AHB slave >>>>>>> interface. Usually, if that affected anything other than accessing VOP >>>>>>> registers, indeed it would smell of something being wrong in the clock tree, >>>>>>> but in this case I'd also be suspicious of whether it might have ended up >>>>>>> clocking related GRF registers as well (either directly, or indirectly via >>>>>>> some gate that the clock driver hasn't modelled yet). >>>>>> Ok, I am beginning to understand. I verified that hdmi, mipi and dp are >>>>>> hanging when HCLK_VOP is disabled by disabling that clock via sysfs >>>>>> using CLOCK_ALLOW_WRITE_DEBUGFS. When it's disabled then the registers >>>>>> of that units can't be accessed. However, when I disable HCLK_VOP by >>>>>> directly writing to the gate bit RK3568_CLKGATE_CON(20) then only >>>>>> accessing VOP registers hangs, the other units stay functional. >>>>>> So it seems it must be the parent clock which must be enabled. The >>>>>> parent clock is hclk_vo. This clock should be handled as part of the >>>>>> RK3568_PD_VO power domain: >>>>>> >>>>>> power-domain@RK3568_PD_VO { >>>>>> reg = ; >>>>>> clocks = <&cru HCLK_VO>, >>>>>> <&cru PCLK_VO>, >>>>>> <&cru ACLK_VOP_PRE>; >>>>>> pm_qos = <&qos_hdcp>, >>>>>> <&qos_vop_m0>, >>>>>> <&qos_vop_m1>; >>>>>> #power-domain-cells = <0>; >>>>>> }; >>>>> Forget this. The clocks in this node are only enabled during enabling or >>>>> disabling the power domain, they are disabled again immediately afterwards. >>>>> >>>>> OK, I need HCLK_VO to access the HDMI registers. I verified that by >>>>> disabling HCLK_VO at register level (CRU_GATE_CON(20) BIT(1)). The >>>>> HDMI registers become inaccessible then. This means I'll replace >>>>> HCLK_VOP in the HDMI node with HCLK_VO. Does this sound sane? >>>> Well, it's still a mystery hack overall, and in some ways it seems even more >>>> suspect to be claiming a whole branch of the clock tree rather than a leaf >>>> gate with a specific purpose. I'm really starting to think that the >>>> underlying issue here is a bug in the clock driver, or a hardware mishap >>>> that should logically be worked around by the clock driver, rather than >>>> individual the consumers. >>>> >>>> Does it work if you hack the clock driver to think that PCLK_VO is a child >>>> of HCLK_VO? Even if that's not technically true, it would seem to >>>> effectively match the observed behaviour (i.e. all 3 things whose register >>>> access apparently *should* be enabled by a gate off PCLK_VO, seem to also >>>> require HCLK_VO). >>> Yes, that works as expected. I am not sure though if we really want to >>> go that path. The pclk rates will become completely bogus with this and >>> should we have to play with the rates in the future we might regret this >>> step. >> How do we proceed here? I can include a patch which makes PCLK_VO a >> child of HCLK_VO if that's what we agree upon. > Couldn't Andy clarify the actual clock tree structure of the h/w for us? > > This will be the best option because datasheet doesn't give the clear > answer, or at least I couldn't find it. Technically, PCLK indeed should > be a child of the HCLK in general, so Robin could be right. Add our clk expert Elaine, she will share some information about the actual clock structure. > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip