All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net] ipv4: convert fib_num_tclassid_users to atomic_t
Date: Wed, 1 Dec 2021 19:42:17 -0700	[thread overview]
Message-ID: <0369c4e8-e19d-d376-06f1-3742da0cc003@gmail.com> (raw)
In-Reply-To: <20211202022635.2864113-1-eric.dumazet@gmail.com>

On 12/1/21 7:26 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> Before commit faa041a40b9f ("ipv4: Create cleanup helper for fib_nh")
> changes to net->ipv4.fib_num_tclassid_users were protected by RTNL.
> 
> After the change, this is no longer the case, as free_fib_info_rcu()
> runs after rcu grace period, without rtnl being held.
> 
> Fixes: faa041a40b9f ("ipv4: Create cleanup helper for fib_nh")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Ahern <dsahern@kernel.org>
> ---
>  include/net/ip_fib.h     | 2 +-
>  include/net/netns/ipv4.h | 2 +-
>  net/ipv4/fib_frontend.c  | 2 +-
>  net/ipv4/fib_rules.c     | 4 ++--
>  net/ipv4/fib_semantics.c | 4 ++--
>  5 files changed, 7 insertions(+), 7 deletions(-)
> 

Thanks, Eric. Was this found by syzbot or code inspection?

Reviewed-by: David Ahern <dsahern@kernel.org>



  reply	other threads:[~2021-12-02  2:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:26 [PATCH net] ipv4: convert fib_num_tclassid_users to atomic_t Eric Dumazet
2021-12-02  2:42 ` David Ahern [this message]
2021-12-02  2:58   ` Eric Dumazet
2021-12-02 12:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0369c4e8-e19d-d376-06f1-3742da0cc003@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.