From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support Date: Wed, 21 May 2014 22:40:07 +0900 Message-ID: <036c01cf74fa$2da9c320$88fd4960$@samsung.com> References: <1400655169-21683-1-git-send-email-sachin.kamat@linaro.org> <1400655169-21683-3-git-send-email-sachin.kamat@linaro.org> <1635304.bK37Q0Q4AO@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:28090 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbaEUNkJ convert rfc822-to-8bit (ORCPT ); Wed, 21 May 2014 09:40:09 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N5X00KEMFAVY5B0@mailout3.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 21 May 2014 22:40:07 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Sachin Kamat' , 'Bartlomiej Zolnierkiewicz' Cc: 'linux-arm-kernel' , 'linux-samsung-soc' , 'Arnd Bergmann' Sachin Kamat wrote: > > Hi Bartlomiej, > > On 21 May 2014 16:06, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Wednesday, May 21, 2014 12:22:48 PM Sachin Kamat wrote: > >> From: Arnd Bergmann > >> > >> This makes it possible to enable the exynos platform as part of a > >> multiplatform kernel, in addition to keeping the single-platform > >> Exynos support. > > > > The patch description is wrong. After this patch single-platform Exynos > > support is no longer available > > Forgot to update the message while rebasing. Thanks for noticing. > > > and it adds at least one serious regression > > I have mentioned about this in the cover letter. > > > (cpufreq) which should be fixed before merging this patch. Moreover it > > seems that this patch (#2) should be merged with patch #3 to preserve > > bisectability. > > At this point exynos_defconfig works. > > >Please also note that exynos_defconfig is no longer useful > > after these changes and can be be removed. > > Yes. > Well, I think keeping the exynos_defconfig would be nice like other platform in multiplatforms...and I'm going to enable possible configs in exynos_defconfig for exynso SoCs then it can cover more for exynos... Thanks, Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Wed, 21 May 2014 22:40:07 +0900 Subject: [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support In-Reply-To: References: <1400655169-21683-1-git-send-email-sachin.kamat@linaro.org> <1400655169-21683-3-git-send-email-sachin.kamat@linaro.org> <1635304.bK37Q0Q4AO@amdc1032> Message-ID: <036c01cf74fa$2da9c320$88fd4960$@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sachin Kamat wrote: > > Hi Bartlomiej, > > On 21 May 2014 16:06, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Wednesday, May 21, 2014 12:22:48 PM Sachin Kamat wrote: > >> From: Arnd Bergmann > >> > >> This makes it possible to enable the exynos platform as part of a > >> multiplatform kernel, in addition to keeping the single-platform > >> Exynos support. > > > > The patch description is wrong. After this patch single-platform Exynos > > support is no longer available > > Forgot to update the message while rebasing. Thanks for noticing. > > > and it adds at least one serious regression > > I have mentioned about this in the cover letter. > > > (cpufreq) which should be fixed before merging this patch. Moreover it > > seems that this patch (#2) should be merged with patch #3 to preserve > > bisectability. > > At this point exynos_defconfig works. > > >Please also note that exynos_defconfig is no longer useful > > after these changes and can be be removed. > > Yes. > Well, I think keeping the exynos_defconfig would be nice like other platform in multiplatforms...and I'm going to enable possible configs in exynos_defconfig for exynso SoCs then it can cover more for exynos... Thanks, Kukjin