From: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Daniel Zoghalchali <daniel@latchkey.dev>
Subject: Re: [PATCH] pack-objects: handle missing objects kkkjwhen excluding promisor objects
Date: Tue, 27 Oct 2026 12:02:11 -0400 [thread overview]
Message-ID: <03704f3590183aadc16d5d81bdc64e9a@fastmail.com> (raw)
In-Reply-To: <20261027-b4-pks-pack-objects-repack-links-with-missing-objects-v1-1-f50f90651274@pks.im>
On Tue, 27 Oct 2026 08:00:28 +0100, Patrick Steinhardt <ps@pks.im> wrote:
> In a partial clone Git tries to maintain two different sets of objects:
> promisor objects should be those that we have received from the remote,
> and any such object may not be fully connected. Locally created objects
> on the other hand should be stored as non-promisor objects. The goal is
> that promisor objects should never reference non-promisor objects as the
> "promisor" property is contagious, where a promisor implicitly means
> that any of its referenced objects are promisor objects, too.
Wordsmithing nitpick: this reads awkwardly. You start by saying there
are two different kinds of things, and then introduce one of them,
followed by a comma, followed by something which _isn't_ the second
type of thing.
Maybe:
In a partial clone, Git tries to maintain two different sets of objects:
promisor objects (which are those we have recieved from a remote, and may
not be fully connected), and non-promisor objects (including any locally
created objects). The goal is that ....
next prev parent reply other threads:[~2026-10-27 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 7:00 [PATCH] pack-objects: handle missing objects when excluding promisor objects Patrick Steinhardt
2026-10-27 16:02 ` Mark C. Chu-Carroll [this message]
2026-10-28 7:26 ` [PATCH] pack-objects: handle missing objects kkkjwhen " Patrick Steinhardt
2026-10-28 7:37 ` [PATCH] pack-objects: handle missing objects when " Junio C Hamano
2026-10-28 11:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03704f3590183aadc16d5d81bdc64e9a@fastmail.com \
--to=markchucarroll@fastmail.com \
--cc=daniel@latchkey.dev \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.