From: Jan Beulich <jbeulich@suse.com>
To: Penny Zheng <Penny.Zheng@amd.com>
Cc: ray.huang@amd.com, grygorii_strashko@epam.com,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
"Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 5/7] xen/p2m: move xenmem_access_to_p2m_access() to common p2m.c
Date: Mon, 24 Nov 2025 15:01:08 +0100 [thread overview]
Message-ID: <0372e719-a79e-445b-a354-2e11562bfdc2@suse.com> (raw)
In-Reply-To: <20251121091554.1003315-6-Penny.Zheng@amd.com>
On 21.11.2025 10:15, Penny Zheng wrote:
> Memory access and ALTP2M are two seperate features, while both depending on
> helper xenmem_access_to_p2m_access(). So it betters lives in common p2m.c,
> other than mem_access.c which will be compiled out when VM_EVENT=n && ALTP2M=y.
> Guard xenmem_access_to_p2m_access() with VM_EVENT || ALTP2M, otherwise it
> will become unreachable when both VM_EVENT=n and ALTP2M=n, and hence
> violating Misra rule 2.1
> We also need to move declaration from mem_access.h to p2m-common.h
> An extra blank line is inserted after each case-block to correct coding
> style at the same time.
>
> Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2025-11-24 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:15 [PATCH v3 0/7] consolidate vm event subsystem Penny Zheng
2025-11-21 9:15 ` [PATCH v3 1/7] xen/x86: move declaration from mem_access.h to altp2m.h Penny Zheng
2025-11-21 9:15 ` [PATCH v3 2/7] xen/xsm: wrap xsm_vm_event_control() with CONFIG_VM_EVENT Penny Zheng
2025-11-25 14:57 ` Daniel P. Smith
2025-11-25 15:01 ` Jan Beulich
2025-11-21 9:15 ` [PATCH v3 4/7] x86/monitor: wrap monitor_op under CONFIG_VM_EVENT Penny Zheng
2025-11-21 9:15 ` [PATCH v3 5/7] xen/p2m: move xenmem_access_to_p2m_access() to common p2m.c Penny Zheng
2025-11-24 14:01 ` Jan Beulich [this message]
2025-11-21 9:15 ` [PATCH v3 6/7] xen/mem_access: wrap memory access when VM_EVENT=n Penny Zheng
2025-11-24 14:09 ` Jan Beulich
2025-12-01 3:46 ` Penny, Zheng
2025-11-21 9:15 ` [PATCH v3 7/7] xen/vm_event: consolidate CONFIG_VM_EVENT Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0372e719-a79e-445b-a354-2e11562bfdc2@suse.com \
--to=jbeulich@suse.com \
--cc=Penny.Zheng@amd.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=grygorii_strashko@epam.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=ppircalabu@bitdefender.com \
--cc=ray.huang@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.