From: "yitian" <yitian.bu@tangramtek.com>
To: "'Andy Shevchenko'" <andriy.shevchenko@linux.intel.com>,
"'Andy Shevchenko'" <andy.shevchenko@gmail.com>,
"'Viresh Kumar'" <viresh.kumar@linaro.org>
Cc: "'Viresh Kumar'" <vireshk@kernel.org>,
"'Vinod Koul'" <vinod.koul@intel.com>,
"'Dan Williams'" <dan.j.williams@intel.com>,
"'dmaengine'" <dmaengine@vger.kernel.org>,
"'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback
Date: Mon, 28 Sep 2015 17:14:36 +0800 [thread overview]
Message-ID: <037301d0f9ce$1908ca10$4b1a5e30$@tangramtek.com> (raw)
In-Reply-To: <1443429967.8361.227.camel@linux.intel.com>
> From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
> Sent: Monday, September 28, 2015 4:46 PM
> To: yitian <yitian.bu@tangramtek.com>; 'Andy Shevchenko'
> <andy.shevchenko@gmail.com>; 'Viresh Kumar' <viresh.kumar@linaro.org>
> Cc: 'Viresh Kumar' <vireshk@kernel.org>; 'Vinod Koul'
> <vinod.koul@intel.com>; 'Dan Williams' <dan.j.williams@intel.com>;
> 'dmaengine' <dmaengine@vger.kernel.org>; 'Linux Kernel Mailing List'
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion lock when
> audio playback
>
> On Mon, 2015-09-28 at 15:23 +0800, yitian wrote:
> > >
> > > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> > > Sent: Monday, September 28, 2015 3:06 PM
> > > To: Viresh Kumar <viresh.kumar@linaro.org>
> > > Cc: yitian <yitian.bu@tangramtek.com>; Viresh Kumar
> > > <vireshk@kernel.org>; Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com>; Vinod Koul <
> > > vinod.koul@intel.com>;
> > > Dan Williams <dan.j.williams@intel.com>; dmaengine
> > > <dmaengine@vger.kernel.org>; Linux Kernel Mailing List
> > > <linux-kernel@vger.kernel.org>
> > > Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion
> > > > I am not sure if this is a sane way of doing that, and we were
> > > > scanning
> > > > the descriptors for some valid reason..
> > >
> > > Actually one of the patches in a pile sitting in my private repo is
> > > also including similar change. In my case the reason is to support
> > > cyclic transfers natively.
> > >
> >
> > Yes, i am using DW DMAC to support cyclic transfer.
> > Currently it is very easy to get recursion lock crash, but
> > after this patch everything is fine on my device.
>
> What is an actual hardware you are running kernel on?
>
Hi Andy:
I am using a FPGA, with Cortex-A5 core, Designware I2S IP, Designware
DMAC IP. What I was done is to run tinyplay and tinycap to test the
playback and capture function on the FPGA. With my change, both of
them are okay now. I didn't push the patch which added cyclic DMA
support for dw DMAC because I didn't make it decent enough yet.
prev parent reply other threads:[~2015-09-28 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 12:38 [PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback yitian
2015-09-28 3:23 ` Viresh Kumar
2015-09-28 7:05 ` Andy Shevchenko
2015-09-28 7:23 ` yitian
2015-09-28 8:46 ` Andy Shevchenko
2015-09-28 9:14 ` yitian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='037301d0f9ce$1908ca10$4b1a5e30$@tangramtek.com' \
--to=yitian.bu@tangramtek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.