From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
david@ixit.cz, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Petr Hodina <petr.hodina@protonmail.com>,
linux-input@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 07/10] Input: stmfts - add optional reset GPIO support
Date: Mon, 2 Mar 2026 12:17:07 +0100 [thread overview]
Message-ID: <037db488-104c-45c3-8bc4-0e64358be3d1@kernel.org> (raw)
In-Reply-To: <5d3694c6-57e7-4943-8dbb-41334086e8ec@oss.qualcomm.com>
On 02/03/2026 12:04, Konrad Dybcio wrote:
> On 3/1/26 6:51 PM, David Heidelberg via B4 Relay wrote:
>> From: Petr Hodina <petr.hodina@protonmail.com>
>>
>> Add support for an optional "reset-gpios" property. If present, the
>> driver drives the reset line high at probe time and releases it during
>> power-on, after the regulators have been enabled.
>>
>> Signed-off-by: Petr Hodina <petr.hodina@protonmail.com>
>> Co-developed-by: David Heidelberg <david@ixit.cz>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>
> [...]
>
>> + sdata->reset_gpio = devm_gpiod_get_optional(dev, "reset",
>> + GPIOD_OUT_HIGH);
>
> Are you really sure the reset is active-high?
This is not choice of ACTIVE HIGH here. It's initialization to logical
level to keep device in reset state.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-02 11:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 17:51 [PATCH 00/10] Input: support for STM FTS5 David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 17:51 ` [PATCH 01/10] Input: stmfts - Use dev struct directly David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 17:51 ` [PATCH 02/10] Input: stmfts - Switch to devm_regulator_bulk_get_const David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 17:51 ` [PATCH 03/10] Input: stmfts - abstract reading information from the firmware David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-04 4:59 ` Dmitry Torokhov
2026-03-01 17:51 ` [PATCH 04/10] Input: stmfts - disable regulators when power on fails David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-04 5:01 ` Dmitry Torokhov
2026-03-01 17:51 ` [PATCH 05/10] Input: stmfts - use client to make future code cleaner David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 17:51 ` [PATCH 06/10] dt-bindings: input: touchscreen: st,stmfts: Introduce reset GPIO David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-02 7:17 ` Krzysztof Kozlowski
2026-03-01 17:51 ` [PATCH 07/10] Input: stmfts - add optional reset GPIO support David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-02 11:04 ` Konrad Dybcio
2026-03-02 11:17 ` Krzysztof Kozlowski [this message]
2026-03-01 17:51 ` [PATCH 08/10] dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5 David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 19:34 ` Rob Herring (Arm)
2026-03-01 22:40 ` Dmitry Baryshkov
2026-03-15 17:09 ` David Heidelberg
2026-03-22 10:16 ` Krzysztof Kozlowski
2026-03-01 17:51 ` [PATCH 09/10] Input: stmfts - support FTS5 David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-01 22:10 ` Dmitry Torokhov
2026-03-01 17:51 ` [PATCH 10/10] arm64: dts: qcom: sdm845-google: Add STM FTS touchscreen support David Heidelberg
2026-03-01 17:51 ` David Heidelberg via B4 Relay
2026-03-02 11:06 ` Konrad Dybcio
2026-03-15 15:52 ` David Heidelberg
2026-03-01 18:10 ` [PATCH 00/10] Input: support for STM FTS5 David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=037db488-104c-45c3-8bc4-0e64358be3d1@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=petr.hodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.