From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782A5C433DF for ; Tue, 19 May 2020 18:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A37E206C3 for ; Tue, 19 May 2020 18:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="MLCWguRQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbgESSur (ORCPT ); Tue, 19 May 2020 14:50:47 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:25146 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgESSur (ORCPT ); Tue, 19 May 2020 14:50:47 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589914246; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=i1KDNTEcQpMlZ8oYJUcWWelkymnM8rNqtXNDYGMt8AU=; b=MLCWguRQi/BYpTTDy83RqC2qOBfEcJGDySK+tEmEu54QfZAFwBCpQjXrJzzEDpy69T60oaKV pB1IhUNmH8TbwRE4xAXwKnIbSJx/Ltwcp4U18LHPDukrIs4ogfWuBLreV8qWNoOoB5hK0i1T N3gSoLsIB0/MgpWC48eXoGek4fQ= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ec42a85.7f0271097298-smtp-out-n04; Tue, 19 May 2020 18:50:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C271EC433D2; Tue, 19 May 2020 18:50:44 +0000 (UTC) Received: from Pillair (unknown [183.83.68.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0A23CC433D2; Tue, 19 May 2020 18:50:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0A23CC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Evan Green'" Cc: "'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS'" , "'linux-arm Mailing List'" , "'LKML'" , "'linux-arm-msm'" References: <1589712411-26718-1-git-send-email-pillair@codeaurora.org> In-Reply-To: Subject: RE: [PATCH v9] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Wed, 20 May 2020 00:20:36 +0530 Message-ID: <039201d62e0e$65d16590$317430b0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFK6cBZDXagU4txI1QUeQtvgRsTqwIox4YXqbUCpuA= Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Evan, > -----Original Message----- > From: Evan Green > Sent: Tuesday, May 19, 2020 10:58 PM > To: Rakesh Pillai > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; linux-arm Mailing List kernel@lists.infradead.org>; LKML ; = linux- > arm-msm > Subject: Re: [PATCH v9] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node >=20 > On Sun, May 17, 2020 at 3:47 AM Rakesh Pillai > wrote: > > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > Changes from v8: > > - Removed the qcom,msa-fixed-perm > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 +++++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > > 2 files changed, 34 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 4e9149d..38b102e 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -389,6 +389,13 @@ > > }; > > }; > > > > +&wifi { > > + status =3D "okay"; > > + wifi-firmware { > > + iommus =3D <&apps_smmu 0xc2 0x1>; > > + }; > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qspi_clk { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index f1280e0..dd4e095 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -63,6 +63,11 @@ > > clock-frequency =3D <32764>; > > #clock-cells =3D <0>; > > }; > > + > > + wlan_fw_mem: memory@94100000 { > > + reg =3D <0 0x94100000 0 0x200000>; > > + no-map; > > + }; >=20 > This node is not in the right place. Up through v8, this lived inside > reserved-memory. Here it seems to apply into the clocks {} node, which > is not the right spot. Thanks for spotting this. This was a rebase problem. I will post the next patchset by fixing this. >=20 >=20 > > }; > > > > reserved_memory: reserved-memory { > > @@ -944,6 +949,28 @@ > > }; > > }; > > > > + wifi: wifi@18800000 { > > + compatible =3D "qcom,wcn3990-wifi"; > > + reg =3D <0 0x18800000 0 0x800000>; > > + reg-names =3D "membase"; > > + iommus =3D <&apps_smmu 0xc0 0x1>; > > + interrupts =3D > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + memory-region =3D <&wlan_fw_mem>; >=20 > Should any of the *-supply regulators be specified? Or are they all > board specific? Or just not needed? The example has these: > vdd-0.8-cx-mx-supply =3D <&pm8998_l5>; > vdd-1.8-xo-supply =3D <&vreg_l7a_1p8>; > vdd-1.3-rfa-supply =3D <&vreg_l17a_1p3>; > vdd-3.3-ch0-supply =3D <&vreg_l25a_3p3>; These votes are optional and were required for older targets. We do not need these proxy votes in host now. >=20 >=20 >=20 > > + status =3D "disabled"; > > + }; > > + > > config_noc: interconnect@1500000 { > > compatible =3D "qcom,sc7180-config-noc"; > > reg =3D <0 0x01500000 0 0x28000>; > > -- > > 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E45C433E2 for ; Tue, 19 May 2020 18:50:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F4F3207D4 for ; Tue, 19 May 2020 18:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Umb32GV2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="CPfYbIgC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F4F3207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject: In-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=07OMKjhrg4Ntra/s9QO1JDc5rGupYndCZDc6lM94HdA=; b=Umb32GV2wZ0cBu 7QGTYeU8dVUsenirrRoZgZkQrrgKttpAdQeml5L14KuYoIPZP+2QXO6gO1b/2WNfPGHfbN9isfAhf vQW9ku/yTFIE+S0nCwk2cz8LxuFva32UcTSVM0BpGx9lxoGgURJmfQIzYe5QZ8u/3RDhhZCTtc9oW uwSa+gEjmDYPLGMR3AXbU0kPYRthYQ8yYBlFTK911hu0Ptf6pO0OM6fvMEWkDUprDRIegJMNKdWSa 0iRxtW0ZYctcptkibarG6gLMSJmmYy5tEoGOfRJf4LCik16MwrN8b1m7jl3WtE9Rwz6HHxvimf9Sd dSc65/fIuq5KKPUPmr0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb7KC-0007bk-Sv; Tue, 19 May 2020 18:50:48 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb7KA-0007bK-2a for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2020 18:50:47 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589914245; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=i1KDNTEcQpMlZ8oYJUcWWelkymnM8rNqtXNDYGMt8AU=; b=CPfYbIgCp92hQpNsWFtKe7fjKBJ05hCBzjWTRRfkhAogYO8HnJviF+ciAf2u8AiAw5ubfkSC O2Qzj7RteSbrrlURmnfXzj9ouYIjon9SLFrIOM4Tto+zb4Mv6iRwLKIxmc9dG/YUFqecTzaT QibCKTxl7YMDFVbeJvOj3fbfYaE= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ec42a84.7f9b22d3e8f0-smtp-out-n01; Tue, 19 May 2020 18:50:44 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 61EE8C432C2; Tue, 19 May 2020 18:50:43 +0000 (UTC) Received: from Pillair (unknown [183.83.68.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0A23CC433D2; Tue, 19 May 2020 18:50:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0A23CC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Evan Green'" References: <1589712411-26718-1-git-send-email-pillair@codeaurora.org> In-Reply-To: Subject: RE: [PATCH v9] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Wed, 20 May 2020 00:20:36 +0530 Message-ID: <039201d62e0e$65d16590$317430b0$@codeaurora.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFK6cBZDXagU4txI1QUeQtvgRsTqwIox4YXqbUCpuA= Content-Language: en-us X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_115046_181021_4B391F24 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS'" , 'LKML' , 'linux-arm Mailing List' , 'linux-arm-msm' Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Evan, > -----Original Message----- > From: Evan Green > Sent: Tuesday, May 19, 2020 10:58 PM > To: Rakesh Pillai > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; linux-arm Mailing List kernel@lists.infradead.org>; LKML ; linux- > arm-msm > Subject: Re: [PATCH v9] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Sun, May 17, 2020 at 3:47 AM Rakesh Pillai > wrote: > > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > Changes from v8: > > - Removed the qcom,msa-fixed-perm > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 +++++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > > 2 files changed, 34 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 4e9149d..38b102e 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -389,6 +389,13 @@ > > }; > > }; > > > > +&wifi { > > + status = "okay"; > > + wifi-firmware { > > + iommus = <&apps_smmu 0xc2 0x1>; > > + }; > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qspi_clk { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index f1280e0..dd4e095 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -63,6 +63,11 @@ > > clock-frequency = <32764>; > > #clock-cells = <0>; > > }; > > + > > + wlan_fw_mem: memory@94100000 { > > + reg = <0 0x94100000 0 0x200000>; > > + no-map; > > + }; > > This node is not in the right place. Up through v8, this lived inside > reserved-memory. Here it seems to apply into the clocks {} node, which > is not the right spot. Thanks for spotting this. This was a rebase problem. I will post the next patchset by fixing this. > > > > }; > > > > reserved_memory: reserved-memory { > > @@ -944,6 +949,28 @@ > > }; > > }; > > > > + wifi: wifi@18800000 { > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + iommus = <&apps_smmu 0xc0 0x1>; > > + interrupts = > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + memory-region = <&wlan_fw_mem>; > > Should any of the *-supply regulators be specified? Or are they all > board specific? Or just not needed? The example has these: > vdd-0.8-cx-mx-supply = <&pm8998_l5>; > vdd-1.8-xo-supply = <&vreg_l7a_1p8>; > vdd-1.3-rfa-supply = <&vreg_l17a_1p3>; > vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; These votes are optional and were required for older targets. We do not need these proxy votes in host now. > > > > > + status = "disabled"; > > + }; > > + > > config_noc: interconnect@1500000 { > > compatible = "qcom,sc7180-config-noc"; > > reg = <0 0x01500000 0 0x28000>; > > -- > > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel