Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo

[Oleksandr <olekstysh@gmail.com>]

On 12.10.21 19:18, Ian Jackson wrote:

Hi Ian

> Oleksandr writes ("Re: [PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>>> Oleksandr Tyshchenko writes ("[PATCH V6 1/2] xen/arm: Introduce gpaddr_bits field to struct xen_domctl_getdomaininfo"):
>>> You say "to the toolstack", but you are exposing this information up
>>> to callers of libxl.  Do you mean some higher-layer toolstack that
>>> uses libxl ?  What does it use this information for ?
>>>
>>> FTAOD I am not opposed to exposing this in this way; indeed it seems
>>> likely to be useful.  I just want to fully understand before I give
>>> this my tools ack.
>> I didn't mean any higher-layer toolstack, sorry if I was unclear. In the
>> first place this information is
>> needed by the entity which generates the device-tree for the guest on
>> Arm (tools/libs/light/libxl_arm.c) to properly calculate the extended
>> regions to be inserted into the hypervisor node.
> Right, OK.  So I think this is being exposed at the libxl
> gratuitously, because someone might want it in the future.
> I approve :-).
>
> Reviewed-by: Ian Jackson <iwj@xenproject.org>

Thanks!


Please note, it is going to be a new version of this patch based on 
today's discussion with Jan.


>
> Thanks,
> Ian.

-- 
Regards,

Oleksandr Tyshchenko