From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <linux@armlinux.org.uk>,
<horms@kernel.org>, <jacob.e.keller@intel.com>,
<netdev@vger.kernel.org>, <vadim.fedorenko@linux.dev>,
<mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v6 1/4] net: wangxun: Add support for PTP clock
Date: Wed, 12 Feb 2025 15:45:52 +0800 [thread overview]
Message-ID: <03a901db7d22$24628cc0$6d27a640$@trustnetic.com> (raw)
In-Reply-To: <20250211160706.15eb0d2a@kernel.org>
On Wed, Feb 12, 2025 8:07 AM, Jakub Kicinski wrote:
> On Sat, 8 Feb 2025 11:13:45 +0800 Jiawen Wu wrote:
> > + * wx_ptp_tx_hwtstamp_work
> > + * @work: pointer to the work struct
> > + *
> > + * This work item polls TSC_1588_CTL valid bit to determine when a Tx hardware
> > + * timestamp has been taken for the current skb. It is necessary, because the
> > + * descriptor's "done" bit does not correlate with the timestamp event.
>
> Why not use the aux_work for this?
> IIUC aux_work often has lower latency since it's a dedicated thread.
I think this task for checking TX timestamp is immediate and continuous
after the skbuff is sent, and can be stopped after polling a valid timestamp.
But aux_work for detecting overflow and error cases is a periodic task that
is always carried out. It looks a little bit clearer if they were separated, but
I could also try to merge it into aux_work if I need to.
next prev parent reply other threads:[~2025-02-12 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 3:13 [PATCH net-next v6 0/4] Support PTP clock for Wangxun NICs Jiawen Wu
2025-02-08 3:13 ` [PATCH net-next v6 1/4] net: wangxun: Add support for PTP clock Jiawen Wu
2025-02-12 0:07 ` Jakub Kicinski
2025-02-12 7:45 ` Jiawen Wu [this message]
2025-02-13 2:17 ` Jakub Kicinski
2025-02-13 12:45 ` Richard Cochran
2025-02-13 21:56 ` Jacob Keller
2025-02-08 3:13 ` [PATCH net-next v6 2/4] net: wangxun: Support to get ts info Jiawen Wu
2025-02-08 3:13 ` [PATCH net-next v6 3/4] net: wangxun: Implement do_aux_work of ptp_clock_info Jiawen Wu
2025-02-08 3:13 ` [PATCH net-next v6 4/4] net: ngbe: Add support for 1PPS and TOD Jiawen Wu
2025-02-12 0:07 ` [PATCH net-next v6 0/4] Support PTP clock for Wangxun NICs Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2025-01-21 2:20 Jiawen Wu
2025-01-21 2:20 ` [PATCH net-next v6 1/4] net: wangxun: Add support for PTP clock Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03a901db7d22$24628cc0$6d27a640$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.