From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema
Date: Tue, 6 May 2025 13:11:12 +0200 [thread overview]
Message-ID: <03aedee5-bab9-4f36-8d71-f31496832629@kernel.org> (raw)
In-Reply-To: <a9729fd4-1fed-459a-b242-eabc71503954@gmail.com>
On 06/05/2025 12:46, Charan Pedumuru wrote:
>
>
> On 06-05-2025 13:00, Krzysztof Kozlowski wrote:
>> On 06/05/2025 09:07, Charan Pedumuru wrote:
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/irq.h>
>>
>> Why is this a irq.h now?
>>
>>> + #include <dt-bindings/reset/tegra186-reset.h>
>>> + dma-controller@6000a000 {
>>> + compatible = "nvidia,tegra30-apbdma", "nvidia,tegra20-apbdma";
>>> + reg = <0x6000a000 0x1200>;
>>> + interrupts = <0 136 0x04>,
>>> + <0 137 0x04>,
>>> + <0 138 0x04>,
>>> + <0 139 0x04>,
>>> + <0 140 0x04>,
>>> + <0 141 0x04>,
>>> + <0 142 0x04>,
>>> + <0 143 0x04>,
>>> + <0 144 0x04>,
>>> + <0 145 0x04>,
>>> + <0 146 0x04>,
>>> + <0 147 0x04>,
>>> + <0 148 0x04>,
>>> + <0 149 0x04>,
>>> + <0 150 0x04>,
>>> + <0 151 0x04>;
>>
>>
>> Again, quoting:
>>
>> You included this...
>> ... so use it.
>>
>> Otherwise what would be the point of including the header?
>
>
> Yes, I understood it now, will remove the header.
No, I asked to use the header.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-06 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 7:07 [PATCH v2 0/2] dt-bindings: dma: nvidia,tegra20-apbdma: Add json schema for text binding Charan Pedumuru
2025-05-06 7:07 ` [PATCH v2 1/2] arch: arm: dts: nvidia: tegra20,30: Rename the apbdma nodename to match with common dma-controller binding Charan Pedumuru
2025-05-06 7:27 ` Krzysztof Kozlowski
2025-05-06 10:46 ` Charan Pedumuru
2025-05-06 7:07 ` [PATCH v2 2/2] dt-bindings: dma: nvidia,tegra20-apbdma: convert text based binding to json schema Charan Pedumuru
2025-05-06 7:30 ` Krzysztof Kozlowski
2025-05-06 10:46 ` Charan Pedumuru
2025-05-06 11:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03aedee5-bab9-4f36-8d71-f31496832629@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.