From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Przemek Kitszel'" <przemyslaw.kitszel@intel.com>
Cc: <mengyuanlou@net-swift.com>, <duanqiangwen@net-swift.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>
Subject: RE: [PATCH net] net: txgbe: fix MSI and INTx interrupts
Date: Wed, 26 Jun 2024 11:11:04 +0800 [thread overview]
Message-ID: <03db01dac776$7b317c80$71947580$@trustnetic.com> (raw)
In-Reply-To: <08f3db6b-6781-435c-bddb-04a594a2e617@intel.com>
On Tue, June 25, 2024 7:41 PM, Przemek Kitszel wrote:
> On 6/21/24 10:09, Jiawen Wu wrote:
> > When using MSI or INTx interrupts, request_irq() for pdev->irq will
> > conflict with request_threaded_irq() for txgbe->misc.irq, to cause
> > system crash.
> >
> > Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller")
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> > drivers/net/ethernet/wangxun/libwx/wx_lib.c | 13 +-
> > .../net/ethernet/wangxun/txgbe/txgbe_irq.c | 122 +++++++-----------
> > .../net/ethernet/wangxun/txgbe/txgbe_irq.h | 2 +-
> > .../net/ethernet/wangxun/txgbe/txgbe_main.c | 3 +-
> > 4 files changed, 59 insertions(+), 81 deletions(-)
> >
>
> Please split into two commits (by prepending one commit that will just
> move/rename function/s) to avoid inflating the diff of the actual fix.
> This will ease the review process.
I will split it into two commits to make it easier to review, but it may not
be just renaming the function in one commit.
prev parent reply other threads:[~2024-06-26 3:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 8:09 [PATCH net] net: txgbe: fix MSI and INTx interrupts Jiawen Wu
2024-06-25 11:00 ` Paolo Abeni
2024-06-25 11:40 ` Przemek Kitszel
2024-06-26 3:11 ` Jiawen Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03db01dac776$7b317c80$71947580$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.