From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A2615AC5 for ; Tue, 25 Jul 2023 09:51:55 +0000 (UTC) Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F046E64 for ; Tue, 25 Jul 2023 02:51:49 -0700 (PDT) X-QQ-mid:Yeas44t1690278638t364t35872 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [183.128.134.159]) X-QQ-SSF:00400000000000F0FQF000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 17732354056317978735 To: "'Russell King \(Oracle\)'" Cc: , , , , References: <20230724102341.10401-1-jiawenwu@trustnetic.com> <20230724102341.10401-5-jiawenwu@trustnetic.com> <03cc01d9be9c$6e51cad0$4af56070$@trustnetic.com> In-Reply-To: Subject: RE: [PATCH net-next 4/7] net: pcs: xpcs: adapt Wangxun NICs for SGMII mode Date: Tue, 25 Jul 2023 17:50:36 +0800 Message-ID: <03f101d9bedd$763b06d0$62b11470$@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJQc7ZImbL9NUPTrDJxH1gVz1U29QHlV8ySAerVjK8CRWbPqwHK0atUrp2zKeA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FROM_EXCESS_BASE64, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tuesday, July 25, 2023 3:49 PM, Russell King (Oracle) wrote: > On Tue, Jul 25, 2023 at 10:05:05AM +0800, Jiawen Wu wrote: > > On Monday, July 24, 2023 6:35 PM, Russell King (Oracle) wrote: > > > On Mon, Jul 24, 2023 at 06:23:38PM +0800, Jiawen Wu wrote: > > > > Wangxun NICs support the connection with SFP to RJ45 module. In this case, > > > > PCS need to be configured in SGMII mode. > > > > > > > > Accroding to chapter 6.11.1 "SGMII Auto-Negitiation" of DesignWare Cores > > > > Ethernet PCS (version 3.20a) and custom design manual, do the following > > > > configuration when the interface mode is SGMII. > > > > > > > > 1. program VR_MII_AN_CTRL bit(3) [TX_CONFIG] = 1b (PHY side SGMII) > > > > 2. program VR_MII_AN_CTRL bit(8) [MII_CTRL] = 1b (8-bit MII) > > > > 3. program VR_MII_DIG_CTRL1 bit(0) [PHY_MODE_CTRL] = 1b > > > > > > I'm confused by "PHY side SGMII" - what does this mean for the > > > transmitted 16-bit configuration word? Does it mean that _this_ side > > > is acting as if it were a PHY? > > > > I'm not sure, because the datasheet doesn't explicitly describe it. In this > > case, the PHY is integrated in the SFP to RJ45 module. From my point of > > view, TX control occurs on the PHY side. So program it as PHY side SGMII. > > Let me ask the question a different way. Would you use "PHY side SGMII" > if the PHY was directly connected to the PCS with SGMII? The information obtained from the IC designer is that "PHY/MAC side SGMII" is configured by experimentation. For these different kinds of NICs: 1) fiber + SFP-RJ45 module: PHY side SGMII 2) copper (pcs + external PHY): MAC side SGMII 3) backplane: PHY side SGMII Backplane is not supported in the driver yet. If consider the "side" as "acting" point, case 1 (this patch implement) seems more like "MAC side SGMII". But in practice, it won't work.