All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
	'Kukjin Kim' <kgene@kernel.org>,
	linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH 01/12] ARM: SAMSUNG: local regs-srom header in mach-exynos
Date: Wed, 29 Jul 2015 09:48:44 +0900	[thread overview]
Message-ID: <040801d0c998$525c3150$f71493f0$@kernel.org> (raw)
In-Reply-To: <55B6CF92.8050904@samsung.com>

Krzysztof Kozlowski wrote:
> 
> On 27.07.2015 23:57, Kukjin Kim wrote:
> >
> > This patch moves regs-srom header file into mach-exynos.
> 
> Hi,
> 
Hi,

> Minor nits:
> 1. Could you trim it and remove unnecessary empty line before description?

Yeah, actually I couldn't use git send-email when I submitted but just used
e-mail. It should be fine in my local branch.

> 2. Could you answer in commit message: Why? Why are you moving the headers?
> 
OK, basically we don't need to keep headers in <mach/xxx> and <plat/xxx> if it
is not required. For example, actually common.h files in mach-xxxx/ have been
made/moved because of the reason before. Someday we did because it was required
to support multi_v7 as well. Anyway it is still required and note that I have
some more patches to move headers which are used only for under drivers/ not
arch side into drivers/. And next step is removing some definitions which are
not used more.

> >
> > c: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Malformed "Cc:" tag.
> 
Oh, OK. Thanks.

One more thing, please ignore patch "[09/12] ARM: SAMSUNG: local keypad header
in mach-s3c64xx" in this series because the header is used in plat-samsung as
well.

Anyway, thanks,
Kukjin

      reply	other threads:[~2015-07-29  0:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 14:57 [PATCH 01/12] ARM: SAMSUNG: local regs-srom header in mach-exynos Kukjin Kim
2015-07-28  0:40 ` Krzysztof Kozlowski
2015-07-29  0:48   ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='040801d0c998$525c3150$f71493f0$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.