From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Magenheimer Subject: RE: [RFC] tmem ABI change... backwards compatibility unnecessary? Date: Fri, 3 Sep 2010 07:47:20 -0700 (PDT) Message-ID: <04083d29-91f5-465c-953a-e8966df47cf5@default> References: <1e601c02-1f50-4396-b4d1-e1e21ebf3dc8@default> <4C7E87970200007800013C2C@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4C80359C.5050002@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Vasiliy G Tolstov , "Xen-Devel (xen-devel@lists.xensource.com)" , tmem-devel@oss.oracle.com, Hackel , Jan Beulich , Keir Fraser , Kurt, stephen.spector@citrix.com, Chris Mason List-Id: xen-devel@lists.xenproject.org > > Thank goodness ABI versioning was built into tmem from > > the beginning! >=20 > Hm, I'm not really a big fan of having a single "ABI version". It > always seems better to have individual calls which can be > augmented/replaced by new calls, and/or have capability flags to extend > the ABI. Versions mean you end up being stuck doing updates in a very > coarse-grained way, and the long-term support gets very onerous. > (Microsoft ABIs are a good antipattern to avoid, especially DirectX.) While I agree in general, and tmem can cleanly handle other forms of minor updates as well, this ABI version change was very nice for this case where the ops data structure (passed to the hypercall in memory) changed in size, thus changing the interface for most of the critical tmem operations.