From: Markus Elfring <Markus.Elfring@web.de>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH] ALSA: pci: add PreSonus Quantum PCI driver
Date: Fri, 21 Aug 2026 15:00:22 +0200 [thread overview]
Message-ID: <040bab74-5f8c-4054-9b93-4a5e9845d4f8@web.de> (raw)
In-Reply-To: <20260820083646.11383-2-nicholas.johnson-opensource@outlook.com.au>
…
> +++ b/sound/pci/quantum/quantum.h
> @@ -0,0 +1,394 @@
…
> +/* TCI_CHAN_CTRL */
> +#define TCI_CTRL_GET_SAMPLE_RATE 0x31
> +#define TCI_CTRL_SET_SAMPLE_RATE 0x32
> +#define TCI_CTRL_GET_CLOCK_SOURCE 0x33
…
Would you like to replace more defines for constant values by enumerations
to stress their relationships?
Regards,
Markus
next prev parent reply other threads:[~2026-08-21 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 8:36 [RFC PATCH 0/1] ALSA: add PreSonus Quantum PCI driver Nicholas Johnson
2026-08-20 8:36 ` [RFC PATCH 1/1] ALSA: pci: " Nicholas Johnson
2026-08-21 12:44 ` [RFC PATCH] " Markus Elfring
2026-08-21 13:00 ` Markus Elfring [this message]
2026-08-21 13:34 ` [RFC PATCH 1/1] " Markus Elfring
2026-08-21 14:24 ` [RFC PATCH] " Markus Elfring
2026-08-21 18:10 ` Markus Elfring
2026-08-22 14:20 ` Markus Elfring
2026-08-22 15:21 ` [RFC PATCH 1/1] " Matthew Wilcox
2026-09-18 18:34 ` [RFC] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040bab74-5f8c-4054-9b93-4a5e9845d4f8@web.de \
--to=markus.elfring@web.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=perex@perex.cz \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.