All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Israel Cepeda <israel.a.cepeda.lopez@intel.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver
Date: Tue, 7 Oct 2025 11:59:04 +0200	[thread overview]
Message-ID: <041e461f-8fec-41ca-a971-2c8a46cbfbbc@kernel.org> (raw)
In-Reply-To: <20251006213957.15668-1-pbrobinson@gmail.com>

Hi,

On 6-Oct-25 11:39 PM, Peter Robinson wrote:
> The Intel USBIO driver is x86 only, other architectures have ACPI
> so add an appropriate depenecy plus compile test.
> 
> Fixes: 121a0f839dbb3 ("usb: misc: Add Intel USBIO bridge driver")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Technically the chip could also be used on other platforms,
but yes in practice it is only used on x86 platforms so
no objections from me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans



> ---
>  drivers/usb/misc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 09ac6f1c985fd..0b56b773dbdf7 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -182,6 +182,7 @@ config USB_LJCA
>  config USB_USBIO
>  	tristate "Intel USBIO Bridge support"
>  	depends on USB && ACPI
> +	depends on X86 || COMPILE_TEST
>  	select AUXILIARY_BUS
>  	help
>  	  This adds support for Intel USBIO drivers.


  reply	other threads:[~2025-10-07  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 21:39 [PATCH] usb: misc: Add x86 dependency for Intel USBIO driver Peter Robinson
2025-10-07  9:59 ` Hans de Goede [this message]
2025-10-09  1:45   ` Cepeda Lopez, Israel A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=041e461f-8fec-41ca-a971-2c8a46cbfbbc@kernel.org \
    --to=hansg@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=israel.a.cepeda.lopez@intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.