From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<Jose.Abreu@synopsys.com>, <rmk+kernel@armlinux.org.uk>,
<mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v3 7/8] net: txgbe: support copper NIC with external PHY
Date: Fri, 25 Aug 2023 15:46:56 +0800 [thread overview]
Message-ID: <042201d9d728$52af63b0$f80e2b10$@trustnetic.com> (raw)
In-Reply-To: <8b142b43-65fa-465b-aa41-bd2200e71c63@lunn.ch>
On Thursday, August 24, 2023 9:02 PM, Andrew Lunn wrote:
> On Thu, Aug 24, 2023 at 10:00:41AM +0800, Jiawen Wu wrote:
> > On Wednesday, August 23, 2023 11:36 PM, Andrew Lunn wrote:
> > > > +static int txgbe_phy_read(struct mii_bus *bus, int phy_addr,
> > > > + int devnum, int regnum)
> > >
> > > There is a general pattern to use the postfix _c45 for the method that
> > > implements C45 access. Not a must, just a nice to have.
> > >
> > > Does this bus master not support C22 at all?
> >
> > It supports C22.
>
> I was looking at how the two MDIO bus master implementations
> differ. Once difference is a register write to set C22/C45, which this
> code does not have. The second change appears to be a clock setting.
>
> If you added C22, do the two become more similar? Should this actually
> be one implementation in the library?
Yes, it could be moved to libwx for txgbe/ngbe. I will send a patch later to implement it.
next prev parent reply other threads:[~2023-08-25 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 6:19 [PATCH net-next v3 0/8] support more link mode for TXGBE Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 1/8] net: pcs: xpcs: add specific vendor supoprt for Wangxun 10Gb NICs Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 2/8] net: pcs: xpcs: support to switch mode for Wangxun NICs Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 3/8] net: pcs: xpcs: add 1000BASE-X AN interrupt support Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 4/8] net: pcs: xpcs: adapt Wangxun NICs for SGMII mode Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 5/8] net: txgbe: add FW version warning Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 6/8] net: txgbe: support switching mode to 1000BASE-X and SGMII Jiawen Wu
2023-08-23 6:19 ` [PATCH net-next v3 7/8] net: txgbe: support copper NIC with external PHY Jiawen Wu
2023-08-23 15:35 ` Andrew Lunn
2023-08-24 2:00 ` Jiawen Wu
2023-08-24 13:02 ` Andrew Lunn
2023-08-25 7:46 ` Jiawen Wu [this message]
2023-08-23 6:19 ` [PATCH net-next v3 8/8] net: ngbe: move mdio access registers to libwx Jiawen Wu
2023-08-25 6:50 ` [PATCH net-next v3 0/8] support more link mode for TXGBE patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='042201d9d728$52af63b0$f80e2b10$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.