From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from motgate4.mot.com (motgate4.mot.com [144.189.100.102]) by ozlabs.org (Postfix) with ESMTP id 571B82BDF2 for ; Thu, 2 Dec 2004 09:19:56 +1100 (EST) In-Reply-To: <200412011707.14693.g.jaeger@sysgo.com> References: <200412011707.14693.g.jaeger@sysgo.com> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Message-Id: <0429B8F6-43E7-11D9-A6C5-000393DBC2E8@freescale.com> From: Kumar Gala Date: Wed, 1 Dec 2004 16:19:07 -0600 To: "Gerhard Jaeger" Cc: Embedded PPC Linux list Subject: Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp... List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , There is some belief that the following patch should fix the issue: http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?=20 nav=3Dindex.html|ChangeSet@-3d I would be interested to know if this helps w/o your patch. - kumar On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote: > Hi, > > this patch fixes an issue, that occurs on my MPC8541CDS, when trying = to > use bootp to get the IP parameters. It seems, that the patch only =20 > cures > the symptom but obviously not the cause ;) > > Signed-off-by: Gerhard Jaeger > > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0 = 2004-11-15 =20 > 02:26:34.000000000 +0100 > +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01 =20 > 17:00:19.000000000 +0100 > @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data) > =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv(dev); > =A0=A0=A0=A0=A0=A0=A0 int result =3D 0; > =A0 > +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo ) > +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return; > + > =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to change the > =A0=A0=A0=A0=A0=A0=A0=A0 * register state */ > =A0=A0=A0=A0=A0=A0=A0 msleep(1);