From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50672EB64D9 for ; Wed, 12 Jul 2023 13:06:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 150A4869B4; Wed, 12 Jul 2023 15:06:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="NQufwik1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BFE01869B6; Wed, 12 Jul 2023 15:06:38 +0200 (CEST) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F22C869AF for ; Wed, 12 Jul 2023 15:06:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mchitale@ventanamicro.com Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-78666f06691so241053939f.0 for ; Wed, 12 Jul 2023 06:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1689167195; x=1691759195; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=4PVpR0MvnOb2Wc8KRvtLB/9WtzAFemGTBCM1Ytmr2bA=; b=NQufwik1f0sDMop/9umu0Ug+J2d9ElZO6wg5ccaIlroVbY6repXtCNsmcB/O0ijlXY 56bnMEaDp6RycUNngzjvg7XuoG8eJ/fRvFnluQDNh4ipz7jPC8gBB3aWFUd32qd8cRFm QlsK+3vnXHZqJ+9vygrkMPg1tpg/nyDArSg2gMnJJqgLmbIvuhddnEzNbnWrJSz+caqM K9ZyUjzEKdgvwqbTOz0vlnTJC88ScV0WGegPrSLtdZfyKD8+ZR8d4UMBu+v01Kz0QI8r RzYD2uDzqsHjDTjCVthwewg+vnwcZAm8rRiv3AT9J1j8VWLQD26ZpQqCrvGd33kUzkvR QS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689167195; x=1691759195; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4PVpR0MvnOb2Wc8KRvtLB/9WtzAFemGTBCM1Ytmr2bA=; b=d7xuybxIJ4n/7aj9DJ2i65QfZcOSVtU+PsThipmBIOuYF0WZJiKmoqiYo2/GBEOJpI VVh5VsUKj8EvkA4GJ+8w/548ndyUzHxnpxSLbS5iRNtqr4cv1l5B3ozRynVGxxoBvMaV H2WfMFlysRzX2fAsVuaWR5jY1vW3OkG+VpVDYHsT4pBPayeKC5qieYKw4y6nKDRTZNmL ztPINhfnCKQIWcbZKmlLv2FsvNvWbUCSgqjM0fSbUEuhzynSt6ToT5bA3F9+VauNgCQC iAj8gJ6c8IANVvWNlpGVqXsa1/KZ3CWAn87y8qLpBI4G0Fy/1iwTQL/RAKTD/TxPtt/+ DOkw== X-Gm-Message-State: ABy/qLalVpk6sCiejZsVkj6WaD+ftJcRjx+Eb7kRSkJWYE5eog/ejM1k /cxyhN1Za93pKqNF+n2jfcZHNw== X-Google-Smtp-Source: APBJJlG+evpmv58w1K9Z1uRobUVNMySwomGVHLTcmB5C9UZCLr34NuBF45h3AlJsM38xWVipkX6Dgw== X-Received: by 2002:a5d:8e0d:0:b0:785:d06d:7b04 with SMTP id e13-20020a5d8e0d000000b00785d06d7b04mr16075522iod.1.1689167194899; Wed, 12 Jul 2023 06:06:34 -0700 (PDT) Received: from ?IPv6:2401:4900:562b:4696:ed72:b71b:8609:75c3? ([2401:4900:562b:4696:ed72:b71b:8609:75c3]) by smtp.gmail.com with ESMTPSA id s23-20020a02cc97000000b0042b3e86dfd8sm1182052jap.141.2023.07.12.06.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 06:06:34 -0700 (PDT) Message-ID: <042cf19a45191fb36e5fc00662273d84fc60c217.camel@ventanamicro.com> Subject: Re: [PATCH v4 0/4] SPL NVMe support From: mchitale@ventanamicro.com To: Tom Rini , u-boot@lists.denx.de Cc: Heinrich Schuchardt , Rick Chen , Leo , Bin Meng , Simon Glass Date: Wed, 12 Jul 2023 18:36:27 +0530 In-Reply-To: <168726816209.294140.1474019151902272300.b4-ty@konsulko.com> References: <20230603140256.2443518-1-mchitale@ventanamicro.com> <168726816209.294140.1474019151902272300.b4-ty@konsulko.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Tue, 2023-06-20 at 09:37 -0400, Tom Rini wrote: > On Sat, 03 Jun 2023 19:32:52 +0530, Mayuresh Chitale wrote: > > > This patchset adds support to load images of the SPL's next booting > > stage from a NVMe device. > > > > Changes in v4: > > - Drop patch 4 > > - Modify patch 2 to use generic fs.h APIs > > > > [...] > > With one change, which is that the "disk/part.c" in 4/4 were not > required for > any platform in tree and also broke testcases, and so was dropped, > this has now > been applied to u-boot/next. If you can explain a bit more what the > problem you > had was, we can look in to it. I suspect you need to test for not > SPL_ENV_SUPPORT but ENV_SUPPORT itself. > Thanks. When SPL_NVME is enabled the build breaks with the following error: riscv64-unknown-linux-gnu-ld.bfd: disk/part.o: in function `blk_get_device_part_str': u-boot/disk/part.c:473: undefined reference to `env_get' make[2]: *** [u-boot/scripts/Makefile.spl:527: spl/u-boot-spl] Error 1 make[1]: *** [/u-boot/Makefile:2053: spl/u-boot-spl] Error 2 One possible fix is: if ((!IS_ENABLED(CONFIG_SPL) && IS_ENABLED(CONFIG_ENV_SUPPORT)) || (IS_ENABLED(CONFIG_SPL) && IS_ENABLED(CONFIG_SPL_ENV_SUPPORT))) if (!dev_part_str || !strlen(dev_part_str) || !strcmp(dev_part_str, "-")) dev_part_str = env_get("bootdevice");