From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Jon Smirl" <jonsmirl@gmail.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH] of: i2c: improve last resort compatible entry selection
Date: Mon, 28 Jul 2008 09:47:21 +0200 [thread overview]
Message-ID: <043095cdcd52bb7af5cf4373b249b302@kernel.crashing.org> (raw)
In-Reply-To: <9e4733910807271500l23fd2b12n940197474a5291df@mail.gmail.com>
>> A reasonable "compatible" value would be something like
>> "serial-eeprom-24c32".
>> You can go a little bit more generic than that, if you write up in
>> your binding how the driver should figure out the device size and
>> the protocol used.
>
> Matching on "serial-eeprom-24c32" requires me to convince the at24
> authors to add that string as an alias binding for their driver.
No, it requires the IIC subsystem to get fixed and not use OF
"compatible" values as module alias names.
> How
> about "serial-eeprom,24c32" or "generic,24x32"?
Neither "serial-eeprom" nor "generic" is the name of a vendor, so
no. The comma has a well-defined meaning. Why would a comma be
easier than a dash for your device matching code, anyway?
Segher
next prev parent reply other threads:[~2008-07-28 7:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 17:54 [PATCH] of: i2c: improve last resort compatible entry selection Anton Vorontsov
2008-07-15 10:44 ` Jochen Friedrich
2008-07-15 13:40 ` Jon Smirl
2008-07-15 14:05 ` Jean Delvare
2008-07-15 14:52 ` Jochen Friedrich
2008-07-15 15:39 ` Jean Delvare
2008-07-27 0:11 ` Grant Likely
2008-07-27 5:05 ` Jon Smirl
2008-07-27 5:35 ` Grant Likely
2008-07-27 14:21 ` Jon Smirl
2008-07-27 21:52 ` Segher Boessenkool
2008-07-27 22:00 ` Jon Smirl
2008-07-28 4:16 ` M. Warner Losh
2008-07-28 7:47 ` Segher Boessenkool [this message]
2008-07-30 14:42 ` Grant Likely
2008-07-30 14:42 ` Grant Likely
2008-07-30 20:20 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=043095cdcd52bb7af5cf4373b249b302@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=devicetree-discuss@ozlabs.org \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.