Re: [PATCH/RFC v1 1/9] media: dt-bindings: media: i2c: Add AR0144 camera sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/06/2024 16:17, Laurent Pinchart wrote:
> Add device tree binding for the onsemi AR0144 CMOS camera sensor. The
> binding supports both the monochrome and color sensor versions.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  .../bindings/media/i2c/onnn,ar0144.yaml       | 166 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 172 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml
> 

> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - onnn,ar0144c  # Color version
> +      - onnn,ar0144m  # Monochrome version
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: extclk

This seems redundant. Drop clock-names.


> +
> +  vaa-supply:
> +    description:
> +      Supply for the VAA and VAA_PIX analog power rails (2.8V).
> +
> +  vdd-supply:
> +    description:
> +      Supply for the VDD and VDD_PHY digital power rails (1.2V).
> +
> +  vdd_io-supply:

No underscores.

> +    description:
> +      Supply for the VDD_IO digital I/O power rail (1.8V or 2.8V).
> +
> +  reset-gpios:
> +    description: Reset GPIO, active low.
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +    description: |

Do not need '|' unless you need to preserve formatting.



Best regards,
Krzysztof