Re: [PATCH v4 1/1] environment: move excludes_file into repo_config_values

[Tian Yuchen <cat@malon.dev>]

On 7/1/26 00:20, Tian Yuchen wrote:
> 
> Thank you both for paving a clear way forward.
> 
> For the upcoming V5 patch, I will implement:
> 
> 1. Revert to the shields ('return NULL' for the getter, and bypassing 
> 'repo != repository' for the _clear()).
> 2. Add 'NEEDSWORK' comments above them documenting that these are 
> temporary changes.
> 3. Update the commit message to reflect this.
> 
> Once this initial migration safely lands, the next goal will be to 
> investigate those failing CI tests.
> 
> Will send out V5 shortly.
> 
> Regards, yuchen
> 

Sorry, I forgot to test the repo_excludes_file() and 
repo_config_values_clear() with/without checks separately earlier. As 
for repo_excludes_files(), I found that the check wasn't necessary, so I 
removed it in v6.

In other words, we're now only filtering out calls that aren't passing 
'the_repository' to _clear(), which is still a task to be addressed in 
the future. I think the current situation should be fairly satisfactory.

Hope this helps.

Regards, yuchen