Re: [PATCH liburing 3/3] examples/zcrx: add refill queue allocation modes

[Pavel Begunkov <asml.silence@gmail.com>]

On 4/21/25 01:28, David Wei wrote:
> On 2025-04-20 04:24, Pavel Begunkov wrote:
>> Refill queue creating is backed by the region api, which can either be
>> user or kernel allocated. Add an option to switch between the modes.
>>
>> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
>> ---
>>   examples/zcrx.c | 46 ++++++++++++++++++++++++++++++++++++----------
>>   1 file changed, 36 insertions(+), 10 deletions(-)
>>
>> diff --git a/examples/zcrx.c b/examples/zcrx.c
>> index 8989c9a4..eafe1969 100644
>> --- a/examples/zcrx.c
>> +++ b/examples/zcrx.c
>> @@ -39,6 +39,13 @@
> [...]
>> @@ -128,6 +140,15 @@ static void setup_zcrx(struct io_uring *ring)
>>   	if (ret)
>>   		t_error(1, 0, "io_uring_register_ifq(): %d", ret);
>>   
>> +	if (cfg_rq_alloc_mode == RQ_ALLOC_USER) {
> 
> cfg_rq_alloc_mode == RQ_ALLOC_KERNEL?

Good catch! I found it during testing but apparently forgot to
commit.

> 
>> +		ring_ptr = mmap(NULL, ring_size,
>> +				PROT_READ | PROT_WRITE,
>> +				MAP_SHARED | MAP_POPULATE,
>> +				ring->ring_fd, region_reg.mmap_offset);
>> +		if (ring_ptr == MAP_FAILED)
>> +			t_error(1, 0, "mmap(): refill ring");
>> +	}
>> +
>>   	rq_ring.khead = (unsigned int *)((char *)ring_ptr + reg.offsets.head);
>>   	rq_ring.ktail = (unsigned int *)((char *)ring_ptr + reg.offsets.tail);
>>   	rq_ring.rqes = (struct io_uring_zcrx_rqe *)((char *)ring_ptr + reg.offsets.rqes);
> 

-- 
Pavel Begunkov