From: Gal Pressman <gal.pressman@linux.dev>
To: Yonatan Nachum <ynachum@amazon.com>,
jgg@nvidia.com, leon@kernel.org, linux-rdma@vger.kernel.org
Cc: mrgolin@amazon.com, sleybo@amazon.com, matua@amazon.com,
Tom Sela <tomsela@amazon.com>
Subject: Re: [PATCH for-next 2/2] RDMA/efa: Expose 64-bit send WR ID support to userspace
Date: Wed, 22 Jul 2026 09:04:36 +0300 [thread overview]
Message-ID: <047c1566-905f-4d22-97fa-66945278a6dc@linux.dev> (raw)
In-Reply-To: <20260721070026.1635441-3-ynachum@amazon.com>
On 21/07/2026 10:00, Yonatan Nachum wrote:
> Currently EFA WRs support 16-bit request ID, this requires EFA to manage
> a translation table to translate the IB WR ID from 64-bits to 16-bits
> and translating it back on CQ completion.
> Expose a new device capability to handle 64-bit request ID for SQ WRs
> allowing userspace to directly post the 64-bit ID to the device.
>
> Reviewed-by: Michael Margolin <mrgolin@amazon.com>
> Reviewed-by: Tom Sela <tomsela@amazon.com>
> Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
> ---
> drivers/infiniband/hw/efa/efa_verbs.c | 3 +++
> include/uapi/rdma/efa-abi.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
> index 001bd8cb4f66..85e32a7c76c3 100644
> --- a/drivers/infiniband/hw/efa/efa_verbs.c
> +++ b/drivers/infiniband/hw/efa/efa_verbs.c
> @@ -264,6 +264,9 @@ int efa_query_device(struct ib_device *ibdev,
> if (EFA_DEV_CAP(dev, UNSOLICITED_WRITE_RECV))
> resp.device_caps |= EFA_QUERY_DEVICE_CAPS_UNSOLICITED_WRITE_RECV;
>
> + if (EFA_DEV_CAP(dev, SQ_64_BIT_REQ_ID))
> + resp.device_caps |= EFA_QUERY_DEVICE_CAPS_SQ_64_BIT_REQ_ID;
> +
> if (dev->neqs)
> resp.device_caps |= EFA_QUERY_DEVICE_CAPS_CQ_NOTIFICATIONS;
>
> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h
> index fc4b2eb903c9..1e371bfef6d8 100644
> --- a/include/uapi/rdma/efa-abi.h
> +++ b/include/uapi/rdma/efa-abi.h
> @@ -135,6 +135,7 @@ enum {
> EFA_QUERY_DEVICE_CAPS_RDMA_WRITE = 1 << 5,
> EFA_QUERY_DEVICE_CAPS_UNSOLICITED_WRITE_RECV = 1 << 6,
> EFA_QUERY_DEVICE_CAPS_CQ_WITH_EXT_MEM = 1 << 7,
> + EFA_QUERY_DEVICE_CAPS_SQ_64_BIT_REQ_ID = 1 << 9,
What happened to 8?
next prev parent reply other threads:[~2026-07-22 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 7:00 [PATCH for-next 0/2] RDMA/efa: Add 64-bit SQ request ID support Yonatan Nachum
2026-07-21 7:00 ` [PATCH for-next 1/2] RDMA/efa: Add CQ/QP creation with 64-bit SQ req " Yonatan Nachum
2026-07-21 7:00 ` [PATCH for-next 2/2] RDMA/efa: Expose 64-bit send WR ID support to userspace Yonatan Nachum
2026-07-22 6:04 ` Gal Pressman [this message]
2026-07-22 6:34 ` Yonatan Nachum
2026-07-22 6:37 ` Yonatan Nachum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047c1566-905f-4d22-97fa-66945278a6dc@linux.dev \
--to=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=tomsela@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.