From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F4DC2D0DB for ; Tue, 28 Jan 2020 17:43:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E91922522 for ; Tue, 28 Jan 2020 17:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Za7hLFCv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tpgv1oHC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E91922522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D04E1616; Tue, 28 Jan 2020 18:42:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D04E1616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580233424; bh=Jd4jqvIFMMLRJmYD2AhyfbwBW7vpwreAiEczfk69WtU=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Za7hLFCvqacglOmVgE0/RifpUg6QBculTymcmqTmPU8+ch59bLqoA7BMGXeZlLpYN 6KYmPXobI48nA5/m7CwmX4kGKueaDzOfcIafi0It05rOK1HxpAcO47hdwBRPbeYdMm jSejiMUDdMxi5AJeSIkan3X3yikmMQ+mt0l4Z8W8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DD5FDF8014B; Tue, 28 Jan 2020 18:42:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29BA6F80150; Tue, 28 Jan 2020 18:42:52 +0100 (CET) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 47DB4F80123 for ; Tue, 28 Jan 2020 18:42:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 47DB4F80123 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tpgv1oHC" Received: by mail-lj1-x241.google.com with SMTP id f25so2718027ljg.12 for ; Tue, 28 Jan 2020 09:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hJoKIthAQFgZ7VR2m6M6xS8oQ/leqVcDe3VXNddw08E=; b=Tpgv1oHC5fsFg38MGKhsMLe2NCpsEnmpQIhN8yMYDthBd1rlr4s7CzBSetMdZpdTCo oouNzsNas9HCdMpmfquipE7uaqZg+8zFXJYv0cAqpDxOuTsq5IkpUCTJ1D8oMvyBrqri x6T26ghLW7GgXqsD/zCx9q1rvA2DbVGx7L9qiRnG4E6lkdq1Glytx8VAzs/A1pAl2dLw pjg2rw1nTOdrqNHPYAvyiFoCO45A/QFvfxFKX3GrsOh7doA0nu50l27nVR10vvwf+Woz ouxslrwu0RuGfS/TjlvCWmbC/FhJeX9d834GZ3Ys9Vm8XTK24PLTDoPXM0Vh2e54debO C+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hJoKIthAQFgZ7VR2m6M6xS8oQ/leqVcDe3VXNddw08E=; b=a5mLiUiFo1v9S7ie8VYQWL2KFrW26pTM2PQfiL4r4mcEN9fEqWHCvtmpKrE+tZBy8B E8kYoPsExIfZYOFFiByqXxSq1IWN8BD+bKTSBrBu07+vQ9o1kmMqkG379Qm5YAe16Sun xaXJ/ijtYwCh0GF1/35yuoAyZcu4EujmV5X7WZuEomJMsCITt1xz6bNszEkMuXJA0eWB R6pwmTAPHSGIej9ujfCI6TzL2/GBwL4xKnQlLKU4yVuuo6zZeEmZ83RHO7hIAIpFsXJJ QuhFIctWyrify4ZJONblePdAXEBpsjxxmeyMD20Z9vetURqd7dnZHWrKF/EX1tvoiHIv IzOg== X-Gm-Message-State: APjAAAUCsl63EuuQBskfYLsmWMiTRpxRDojYGXzHBNPSXiSYLDllKwjX yvm4lenOeg99p/wvbCQ9Bws= X-Google-Smtp-Source: APXvYqyu2ANQ51DyRAxl3hdd6sedoyacUos5bCBdEnZzcwVoSWTByw15S6I7Z2+SlhHytv14NvEF8Q== X-Received: by 2002:a2e:7c08:: with SMTP id x8mr13801161ljc.185.1580233367895; Tue, 28 Jan 2020 09:42:47 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id f29sm4724370ljo.76.2020.01.28.09.42.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 09:42:47 -0800 (PST) To: Mark Brown References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <20200128121315.GD4689@sirena.org.uk> From: Dmitry Osipenko Message-ID: <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> Date: Tue, 28 Jan 2020 20:42:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200128121315.GD4689@sirena.org.uk> Content-Language: en-US Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Ben Dooks , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org, Jon Hunter Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjguMDEuMjAyMCAxNToxMywgTWFyayBCcm93biDQv9C40YjQtdGCOgo+IE9uIE1vbiwgSmFuIDI3 LCAyMDIwIGF0IDEwOjIwOjI1UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4gMjQu MDEuMjAyMCAxOTo1MCwgSm9uIEh1bnRlciDQv9C40YjQtdGCOgo+IAo+Pj4gICAgICAgICAgICAg ICAgIC5yYXRlcyA9IFNORFJWX1BDTV9SQVRFXzgwMDBfOTYwMDAsCj4+PiAgICAgICAgICAgICAg ICAgLmZvcm1hdHMgPSBTTkRSVl9QQ01fRk1UQklUX1MzMl9MRSB8Cj4+PiAtICAgICAgICAgICAg ICAgICAgICAgICAgICBTTkRSVl9QQ01fRk1UQklUX1MyNF9MRSB8Cj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICBTTkRSVl9QQ01fRk1UQklUX1MyNF8zTEUgfAo+IAo+PiBJdCBzaG91bGQg c29sdmUgdGhlIHByb2JsZW0gaW4gbXkgcGFydGljdWxhciBjYXNlLCBidXQgSSdtIG5vdCBzdXJl IHRoYXQKPj4gdGhlIHNvbHV0aW9uIGlzIGNvcnJlY3QuCj4gCj4gSWYgdGhlIGZvcm1hdCBpbXBs ZW1lbnRlZCBieSB0aGUgZHJpdmVyIGlzIFMyNF8zTEUgdGhlIGRyaXZlciBzaG91bGQKPiBhZHZl cnRpc2UgUzI0XzNMRS4KCkl0IHNob3VsZCBiZSBTMjRfTEUsIGJ1dCBzZWVtcyB3ZSBzdGlsbCBk b24ndCBrbm93IGZvciBzdXJlLgoKPj4gVGhlIHY1LjUga2VybmVsIGlzIHJlbGVhc2VkIG5vdyB3 aXRoIHRoZSBicm9rZW4gYXVkaW8gYW5kIGFwcGFyZW50bHkKPj4gZ2V0dGluZyAyNGJpdCB0byB3 b3JrIHdvbid0IGJlIHRyaXZpYWwgKGlmIHBvc3NpYmxlIGF0IGFsbCkuIEJlbiwgY291bGQKPj4g eW91IHBsZWFzZSBzZW5kIGEgcGF0Y2ggdG8gZml4IHY1LjUgYnkgcmVtb3ZpbmcgdGhlIFMyNCBz dXBwb3J0Cj4+IGFkdmVydGlzZW1lbnQgZnJvbSB0aGUgZHJpdmVyPwo+IAo+IFdoeSBpcyB0aGF0 IHRoZSBiZXN0IGZpeCByYXRoZXIgdGhhbiBqdXN0IGFkdmVydGlzaW5nIHRoZSBmb3JtYXQKPiBp bXBsZW1lbnRlZCBieSB0aGUgZHJpdmVyPwoKVGhlIGN1cnJlbnRseSBzdXBwb3J0ZWQgZm9ybWF0 IHRoYXQgaXMga25vd24gdG8gd29yayB3ZWxsIGlzIFMxNl9MRS4KCkknbSBzdWdnZXN0aW5nIHRv IGRyb3AgdGhlIFMyNF9MRSBhbmQgUzMyX0xFIHRoYXQgd2VyZSBhZGRlZCBieSB0aGUKYXBwbGll ZCBwYXRjaGVzIHNpbXBseSBiZWNhdXNlIHRoaXMgc2VyaWVzIHdhc24ndCB0ZXN0ZWQgcHJvcGVy bHkgYmVmb3JlCml0IHdhcyBzZW50IG91dCBhbmQgdHVybmVkIG91dCB0aGF0IGl0IGRvZXNuJ3Qg d29yayB3ZWxsLgoKPiBJIHJlYWxseSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlzIGlzIGFsbCB0 YWtpbmcgc28gbG9uZywgdGhpcyB0aHJlYWQKPiBqdXN0IHNlZW1zIHRvIGJlIGdvaW5nIHJvdW5k IGluIGludGVybWluYWJsZSBjaXJjbGVzIGxvbmcgYWZ0ZXIgaXQKPiBsb29rZWQgbGlrZSB0aGUg aXNzdWUgd2FzIHVuZGVyc3Rvb2QuICBJIGhhdmUgdG8gYWRtaXQgSSd2ZSBub3QgcmVhZAo+IGV2 ZXJ5IHNpbmdsZSBtZXNzYWdlIGluIHRoZSB0aHJlYWQgYnV0IGl0J3MgZGlmZmljdWx0IHRvIHNl ZSB3aHkgaXQKPiBkb2Vzbid0IHNlZW0gdG8gYmUgbWFraW5nIGFueSBwcm9ncmVzcy4KCkJlbiB3 YXMgdHJ5aW5nIHRvIG1ha2UgYSBmaXggZm9yIHRoZSBpbnRyb2R1Y2VkIHByb2JsZW0sIGJ1dCBp dCdzIG5vdAplYXN5IGFzIHdlIHNlZSBub3cuCgpQZXJoYXBzIHRoZSBiZXN0IHNvbHV0aW9uIHNo b3VsZCBiZSB0byByZXZlcnQgYWxsIG9mIHRoZSB0aHJlZSBhcHBsaWVkCnBhdGNoZXMgYW5kIHRy eSBhZ2FpbiBsYXRlciBvbiwgb25jZSBhbGwgY3VycmVudCBwcm9ibGVtcyB3aWxsIGJlIHJlc29s dmVkLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNh LWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9t YWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Tue, 28 Jan 2020 20:42:43 +0300 Message-ID: <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> <20200128121315.GD4689@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200128121315.GD4689-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Jon Hunter , Ben Dooks , linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Liam Girdwood , Takashi Iwai , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 28.01.2020 15:13, Mark Brown пишет: > On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote: >> 24.01.2020 19:50, Jon Hunter пишет: > >>> .rates = SNDRV_PCM_RATE_8000_96000, >>> .formats = SNDRV_PCM_FMTBIT_S32_LE | >>> - SNDRV_PCM_FMTBIT_S24_LE | >>> + SNDRV_PCM_FMTBIT_S24_3LE | > >> It should solve the problem in my particular case, but I'm not sure that >> the solution is correct. > > If the format implemented by the driver is S24_3LE the driver should > advertise S24_3LE. It should be S24_LE, but seems we still don't know for sure. >> The v5.5 kernel is released now with the broken audio and apparently >> getting 24bit to work won't be trivial (if possible at all). Ben, could >> you please send a patch to fix v5.5 by removing the S24 support >> advertisement from the driver? > > Why is that the best fix rather than just advertising the format > implemented by the driver? The currently supported format that is known to work well is S16_LE. I'm suggesting to drop the S24_LE and S32_LE that were added by the applied patches simply because this series wasn't tested properly before it was sent out and turned out that it doesn't work well. > I really don't understand why this is all taking so long, this thread > just seems to be going round in interminable circles long after it > looked like the issue was understood. I have to admit I've not read > every single message in the thread but it's difficult to see why it > doesn't seem to be making any progress. Ben was trying to make a fix for the introduced problem, but it's not easy as we see now. Perhaps the best solution should be to revert all of the three applied patches and try again later on, once all current problems will be resolved.