From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, LKML <linux-kernel@vger.kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection
Date: Mon, 6 May 2019 17:03:20 +0300 [thread overview]
Message-ID: <04843f27-bb0f-d631-32c8-80cd122b7399@linux.intel.com> (raw)
In-Reply-To: <20190506151656.47494e56@endymion>
On 5/6/19 4:16 PM, Jean Delvare wrote:
> Some EE1004 implementations will not properly ack page selection
> commands. They still set the page correctly, so there is no actual
> error. Deal with this case gracefully by checking the currently
> selected page after we receive a nack. If the page is set right then
> we can continue.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/misc/eeprom/ee1004.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
Does Dreamcat4 deserve reported and tested by tags here? I guess
anonymous address is fine with those tags?
(I re-tested these two patches on top of v5.1 and they make decode-dimms
working on a machine with 2-4 * Crucial DD4 dimms)
--
Jarkko
next prev parent reply other threads:[~2019-05-06 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 13:15 [PATCH 1/2] eeprom: ee1004: Move selected page detection to a separate function Jean Delvare
2019-05-06 13:16 ` [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection Jean Delvare
2019-05-06 14:03 ` Jarkko Nikula [this message]
2019-05-06 14:30 ` Dreamcat4
2019-05-06 15:16 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04843f27-bb0f-d631-32c8-80cd122b7399@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.