Re: [PATCH] iomap: only follow dio alignment requirement if specified

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2026/10/27 20:37, Pankaj Raghav 写道:
> 
> 
[...]
>>>> Cc: stable@vger.kernel.org
> 
> FYI, your patches are not in 7.3 and only in linux-next. So we don't 
> need to cc stable?

Unfortunately, it's already upstreamed.

The commit hash, 4025185cf953 ("iomap: follow the alignment requirement 
for iomap_dio_hole_iter()"), is already in the upstream.

Thanks,
Qu

>>>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>>>> ---
>>>>   fs/iomap/direct-io.c | 26 ++++++++++++++++----------
>>>>   1 file changed, 16 insertions(+), 10 deletions(-)
>>>>
>>>
>>> Ignore my previous question (I had a old version of xfstests).
>>> I was able to reproduce the error on XFS, ext4 and this patch fixes it.
>>>
>>> One small nit: should we update the IOMAP_DIO_FSBLOCK_ALIGNED flag
>>> documentation to reflect this?
>>>
>>> At the moment the document says "Ensure each bio is aligned to fs block
>>> size". Should we expand it to say "Ensure each bio and any progress
>>> reported for hole/unwritten extents is aligned to fs block size"?
>>
>> I'll change it to something like "Ensure every operation, including 
>> bio and folio zeroing, is aligned to fs block size".
>>
> 
> This is better.
>> Will be included in the next update.
>>
> 
> And for the b4 error, feel free to use:
> Reviewed-by: Pankaj Raghav(Samsung) <pankaj.raghav@linux.dev>
> 
> -- 
> Pankaj