All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Joe Perches' <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
	'Steve Wise' <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Cc: 'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	'Sean Hefty' <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	'Hal Rosenstock'
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH 3/4] cxgb4: Use more common logging style
Date: Thu, 9 Feb 2017 16:36:28 -0600	[thread overview]
Message-ID: <04cc01d28324$f45bbd80$dd133880$@opengridcomputing.com> (raw)
In-Reply-To: <d054cd530aeef452c7c252504f7d4d6ebba31ae3.1486678686.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>

> 
> Convert printks to pr_<level>
> 
> Miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c       | 84
+++++++++++++++-------------------
>  drivers/infiniband/hw/cxgb4/cq.c       |  8 ++--
>  drivers/infiniband/hw/cxgb4/device.c   | 83 ++++++++++++++-------------------
>  drivers/infiniband/hw/cxgb4/ev.c       | 10 ++--
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h |  6 +++
>  drivers/infiniband/hw/cxgb4/mem.c      |  6 +--
>  drivers/infiniband/hw/cxgb4/provider.c |  4 +-
>  drivers/infiniband/hw/cxgb4/qp.c       |  5 +-
>  drivers/infiniband/hw/cxgb4/resource.c | 18 +++-----
>  drivers/infiniband/hw/cxgb4/t4.h       |  2 +-
>  10 files changed, 97 insertions(+), 129 deletions(-)
>

Looks good (and thanks).

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Joe Perches'" <joe@perches.com>, "'Steve Wise'" <swise@chelsio.com>
Cc: "'Doug Ledford'" <dledford@redhat.com>,
	"'Sean Hefty'" <sean.hefty@intel.com>,
	"'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
	<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] cxgb4: Use more common logging style
Date: Thu, 9 Feb 2017 16:36:28 -0600	[thread overview]
Message-ID: <04cc01d28324$f45bbd80$dd133880$@opengridcomputing.com> (raw)
In-Reply-To: <d054cd530aeef452c7c252504f7d4d6ebba31ae3.1486678686.git.joe@perches.com>

> 
> Convert printks to pr_<level>
> 
> Miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c       | 84
+++++++++++++++-------------------
>  drivers/infiniband/hw/cxgb4/cq.c       |  8 ++--
>  drivers/infiniband/hw/cxgb4/device.c   | 83 ++++++++++++++-------------------
>  drivers/infiniband/hw/cxgb4/ev.c       | 10 ++--
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h |  6 +++
>  drivers/infiniband/hw/cxgb4/mem.c      |  6 +--
>  drivers/infiniband/hw/cxgb4/provider.c |  4 +-
>  drivers/infiniband/hw/cxgb4/qp.c       |  5 +-
>  drivers/infiniband/hw/cxgb4/resource.c | 18 +++-----
>  drivers/infiniband/hw/cxgb4/t4.h       |  2 +-
>  10 files changed, 97 insertions(+), 129 deletions(-)
>

Looks good (and thanks).

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

  parent reply	other threads:[~2017-02-09 22:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 22:23 [PATCH 0/4] infiniband: chelsio Joe Perches
2017-02-09 22:23 ` Joe Perches
2017-02-09 22:23 ` [PATCH 1/4] cxgb3: Use more common logging style Joe Perches
2017-02-09 22:34   ` Steve Wise
2017-02-09 22:34     ` Steve Wise
2017-02-09 22:39     ` Joe Perches
2017-02-09 22:39       ` Joe Perches
2017-02-09 22:23 ` [PATCH 2/4] cxgb3: Convert PDBG to pr_debug Joe Perches
     [not found]   ` <41a74ceecd35cf2f38e2a1a1a394c7718547deb6.1486678686.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-02-09 22:35     ` Steve Wise
2017-02-09 22:35       ` Steve Wise
2017-02-09 22:23 ` [PATCH 3/4] cxgb4: Use more common logging style Joe Perches
     [not found]   ` <d054cd530aeef452c7c252504f7d4d6ebba31ae3.1486678686.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-02-09 22:36     ` Steve Wise [this message]
2017-02-09 22:36       ` Steve Wise
2017-02-09 22:23 ` [PATCH 4/4] cxgb4: Convert PDBG to pr_debug Joe Perches
     [not found]   ` <747edc68212781296de30dd2b4e63711240da7a9.1486678686.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-02-09 22:37     ` Steve Wise
2017-02-09 22:37       ` Steve Wise
     [not found] ` <cover.1486678686.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-04-20 20:14   ` [PATCH 0/4] infiniband: chelsio Doug Ledford
2017-04-20 20:14     ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='04cc01d28324$f45bbd80$dd133880$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.