From: Namjae Jeon <namjae.jeon@samsung.com>
To: 'Theodore Ts'o' <tytso@mit.edu>, 'Dave Chinner' <david@fromorbit.com>
Cc: 'Eric Whitney' <enwlinux@gmail.com>,
a.sangwan@samsung.com, linux-ext4@vger.kernel.org,
fstests@vger.kernel.org
Subject: RE: generic/064 test failures on ext4 (4.2-rc*)
Date: Mon, 03 Aug 2015 11:01:46 +0900 [thread overview]
Message-ID: <04d101d0cd90$5ac2b980$10482c80$@samsung.com> (raw)
In-Reply-To: <20150728030913.GC2851@thunk.org>
Hi,
Sorry for late response.
I am on vacation. I will check this issue as soon as getting back.
Thanks!
> Yes, that's what is going on. If delayed allocation is disabled (as
> it is in some configuration scenarios), ext4's block allocator doesn't
> do as well, and in some cases it will pick a starting block number for
> the file that ends up splitting the initial file across block groups'
> meta data blocks.
>
> > Really, the number of extents or holes at the intermediate stage
> > doesn't matter. What matters is that after collapsing the holes back
> > out of the file, then number of extents is identical to the original
> > file (i.e. that fcollapse() undoes finsert() exactly).
>
> Yup.
>
> > So changing this code to use _within_tolerance to say that 100 >=
> > num_extents >= 105 is ok would probably be better:
> >
> > _within_tolerance "Extent count" $nextents 100 0 5%
> >
> > This will output a standard pass/fail message rather than an exact
> > count. This allows some wiggle room for filesystem configurations
> > that have unexpected non-contiguous baseline allocation behaviour to
> > pass the test.
>
> Works for me.
>
> Thanks,
>
> - Ted
prev parent reply other threads:[~2015-08-03 2:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 19:10 generic/064 test failures on ext4 (4.2-rc*) Eric Whitney
2015-07-27 21:51 ` Dave Chinner
2015-07-28 3:09 ` Theodore Ts'o
2015-08-03 2:01 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04d101d0cd90$5ac2b980$10482c80$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=a.sangwan@samsung.com \
--cc=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.