All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 2/2] ice: Fix promiscuous mode not turning off
Date: Fri, 1 Jul 2022 17:20:31 +0200	[thread overview]
Message-ID: <04da412c-2ed2-be50-e33f-b20164625b7e@intel.com> (raw)
In-Reply-To: <30eee1c9-5cb0-4c30-b4e7-fb801fcccd3d@intel.com>

Hi,

Thank for your review

On 6/29/2022 12:09 AM, Tony Nguyen wrote:
>
>
> On 6/24/2022 3:16 AM, Michal Wilczynski wrote:
>> When trust is turned off for the VF, the expectation is that
>> promiscuous and allmulticast filters are removed.
>> Currently default VSI filter is not getting cleared in this
>> flow.
>>
>> Example:
>>
>> ip link set enp236s0f0 vf 0 trust on
>> ip link set enp236s0f0v0 promisc on
>> ip link set enp236s0f0 vf 0 trust off
>> /* promiscuous mode is still enabled on VF0 */
>
> Why not net?


I felt like maybe these changes are too broad for net, but as you 
noticed this can be treated

as a bug fix, so changed to net in v2


>
>> Remove switch filters for both cases.
>> This commit fixes above behavior by removing default VSI filters
>> and allmulticast filters when vf-true-promisc-support is OFF.
>>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

      reply	other threads:[~2022-07-01 15:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 10:16 [Intel-wired-lan] [PATCH net-next v1 0/2] Improvements for default VSI filter handling Michal Wilczynski
2022-06-24 10:16 ` [Intel-wired-lan] [PATCH net-next v1 1/2] ice: Introduce enabling promiscuous mode on multiple VF's Michal Wilczynski
2022-06-28 22:06   ` Tony Nguyen
2022-07-01 15:21     ` Wilczynski, Michal
2022-06-24 10:16 ` [Intel-wired-lan] [PATCH net-next v1 2/2] ice: Fix promiscuous mode not turning off Michal Wilczynski
2022-06-28 22:09   ` Tony Nguyen
2022-07-01 15:20     ` Wilczynski, Michal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04da412c-2ed2-be50-e33f-b20164625b7e@intel.com \
    --to=michal.wilczynski@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.