From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1B3EC87FCF for ; Sun, 10 Aug 2025 12:47:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ul5RR-0001lW-Tk; Sun, 10 Aug 2025 08:46:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ul5RM-0001ZT-97 for qemu-devel@nongnu.org; Sun, 10 Aug 2025 08:46:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ul5RJ-0006or-MW for qemu-devel@nongnu.org; Sun, 10 Aug 2025 08:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754829975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DvZHVHXKMWTJaAiZArleZjT9oNCBUUtRUnniAqWNuqM=; b=TKvmCcdsCc2z7MQQ0QJfyI2ZcxhtikWUh7AFfcSt6jO3EmeYJ/9YOrkJlkZhFrtowNgOEf 50rVP4Q0M1AVvkIceATwQTQ037Ow6RFivEmBtUGKGQh1PSie2IK4pTx0DUxtXusf1gHZYq OvPFFT0lb72X1jN9+D4FNEdRJBlrN6Q= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-ecB_UNIyOeSHmkbOIvUb8Q-1; Sun, 10 Aug 2025 08:46:12 -0400 X-MC-Unique: ecB_UNIyOeSHmkbOIvUb8Q-1 X-Mimecast-MFC-AGG-ID: ecB_UNIyOeSHmkbOIvUb8Q_1754829972 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3b7886bfc16so2239229f8f.1 for ; Sun, 10 Aug 2025 05:46:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754829972; x=1755434772; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DvZHVHXKMWTJaAiZArleZjT9oNCBUUtRUnniAqWNuqM=; b=FArQm0pA9f1U9R9qpXcr8ywZJK82JweByn4mKzT0lCQKN8ocv1k+OD//uhaALhEOPj knpDyW+pugFxYqKZTOko8VajuIZ2ADPAXeZ9/NjKzvyD4w9JUjapjPgfKzaAwTdUN9oQ +3XpowumovtmC/r4NhA/Qorsi8WVsRHYZucx7JuKIjJLA6H2RFBCtCQw7Jo50aWpb8Vh mNjHxwxR9MINySEBeDeG/8GwbdTnjUPi9CVgdyQtnFGD8Adc4F70f/v7YYYHuNTNXHR0 29GnAttHBCEK4O/BPmvA5ki3G4pxvtEGtNQd0VUfVOXiE1LtIvBwBnFiyUhVvqeBovkA /zhA== X-Forwarded-Encrypted: i=1; AJvYcCUbwceEDZ12gS/lwBLWf5OiA9Sh7+5+V43XpBIAXFgK/azOEgEzsM2no0fQk0+1hT8PCOYjnF6X1out@nongnu.org X-Gm-Message-State: AOJu0YxXn5URm4cbaINWjb1hbwvC0CuX8sjorU8hXrpB6IzfzcOmOCHT Tjkonu7ppda2Q3noKh/Jf/Z9gLAihwg1STHngy7gop4fwXdHskx5UMKQC/BmSkwvT+TgVHXKMxz Xo1cdy24z+OU7xuWzdVHZaOz6/XIw+BH3f0a6Kk8KK7SpU3gi2wL+FYZE X-Gm-Gg: ASbGnct3VxRyEt5596wBwTLndLSuNWkdfJHW1EvCGcCsjwS8/z9xda0TwEjPHViDh5G WVEoCN9c2ibk8U+7MwVJ+4JT3FwofNyucrNBFALUWrsoXSrDDOM6vJ001N2A12ffn3QXblJrnLS tW7S7BM3R6AvvdygS1GZYZHH5+V+swWUK+cgaAGbY9YXtvD839L4IbCZjuLsX5oN+ziBlhcsMvF jMUexHtohucOYyB2YxBpihESfUgjsl+mWdvx1hEDOagCUGJMFuynAkzd2/HQzItTUbaw0theytE OhpGPjzolzTYSDOjtlcyY0q/ZCtLaT7O2v0daseGIOc2S/yWRtawvzlWLhlHc+6bblBPz/2GYgq 2vg== X-Received: by 2002:a05:6000:240b:b0:3b7:6205:25c7 with SMTP id ffacd0b85a97d-3b900b4cae9mr7636135f8f.13.1754829971326; Sun, 10 Aug 2025 05:46:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWo7zH+w8s+5+nVdGAyBrKdmVa+SdjSglMuPLx0KylaoOLPea31z4tsxF9PUSe1+fPQbKofg== X-Received: by 2002:a05:6000:240b:b0:3b7:6205:25c7 with SMTP id ffacd0b85a97d-3b900b4cae9mr7636111f8f.13.1754829970842; Sun, 10 Aug 2025 05:46:10 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e5853104sm212693855e9.8.2025.08.10.05.46.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Aug 2025 05:46:10 -0700 (PDT) Message-ID: <04eb08b6-b787-47f3-86b7-b2d3a0f50ed6@redhat.com> Date: Sun, 10 Aug 2025 14:46:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Access to remote XIVE2 units (was Re: [PATCH v9 0/7] Power11 support for QEMU [PowerNV]) To: Aditya Gupta Cc: Nicholas Piggin , Harsh Prateek Bora , Mahesh J Salgaonkar , Madhavan Srinivasan , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Glenn Miles , gautam@linux.ibm.com References: <20250808115929.1073910-1-adityag@linux.ibm.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org + Glenn + Gautam On 8/10/25 12:45, Aditya Gupta wrote: > On 25/08/10 12:26PM, Aditya Gupta wrote: >>> <...snip...> >> >> About the error, seems xive2 always expecting powernv10 chip, I will >> have to rethink how should I use the same xive2 for powernv11. >> > > There's a type cast to Pnv10Chip in 'pnv_xive2_get_remote'. > The cast is only temporarily used to get the 'PnvXive2' object in the > Pnv10Chip. > It's the only place in hw/intc/pnv_xive2.c assuming Pnv10Chip object. > > Thinking to have a helper function to just return the 'PnvXive2' object > inside the chip, given a 'PnvChip'. > > Or the below change where we are adding another pointer in PnvChipClass: > > diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c > index e019cad5c14c..9832be5fd297 100644 > --- a/hw/intc/pnv_xive2.c > +++ b/hw/intc/pnv_xive2.c > @@ -110,8 +110,8 @@ static PnvXive2 *pnv_xive2_get_remote(uint32_t vsd_type, hwaddr fwd_addr) > int i; > > for (i = 0; i < pnv->num_chips; i++) { > - Pnv10Chip *chip10 = PNV10_CHIP(pnv->chips[i]); > - PnvXive2 *xive = &chip10->xive; > + PnvChipClass *k = PNV_CHIP_GET_CLASS(pnv->chips[i]); > + PnvXive2 *xive = k->intc_get(pnv->chips[i]); > > /* > * Is this the XIVE matching the forwarded VSD address is for this > > Which one do you suggest ? Or should I look for another way ? > > I am preferring the first way to have a helper, but both ways look hacky. Any call to qdev_get_machine() in device model is at best a modeling shortcut, most likely it is a hack : /* * Remote access to INT controllers. HW uses MMIOs(?). For now, a simple * scan of all the chips INT controller is good enough. */ So all these calls are suspicious : $ git grep qdev_get_machine hw/*/*pnv* hw/intc/pnv_xive2.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/pci-host/pnv_phb.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/pci-host/pnv_phb3.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/ppc/pnv.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/ppc/pnv.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/ppc/pnv_chiptod.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/ppc/pnv_chiptod.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); hw/ppc/pnv_lpc.c: PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); In the particular case of XIVE2, the solution is to rework pnv_xive2_get_remote() like it was for P9. See b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs"). Thanks, C.