From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <linux@armlinux.org.uk>,
<horms@kernel.org>, <jacob.e.keller@intel.com>,
<netdev@vger.kernel.org>, <vadim.fedorenko@linux.dev>,
<mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v7 0/4] Support PTP clock for Wangxun NICs
Date: Mon, 17 Feb 2025 09:47:51 +0800 [thread overview]
Message-ID: <050201db80dd$f4b45bb0$de1d1310$@trustnetic.com> (raw)
In-Reply-To: <20250214165218.5bce48c3@kernel.org>
On Sat, Feb 15, 2025 8:52 AM, Jakub Kicinski wrote:
> On Thu, 13 Feb 2025 16:30:37 +0800 Jiawen Wu wrote:
> > Implement support for PTP clock on Wangxun NICs.
>
> Please run:
>
> ./scripts/kernel-doc -none -Wall drivers/net/ethernet/wangxun/*/*
>
> Existing errors are fine, but you shouldn't be adding new ones.
> You're missing documentation for return values for a lot of functions.
>
> Note that adding kdoc is not required, you can just remove it where
> it doesn't add value. But if you add kdoc comments they need to be
> fully specified.
OK, I'll fix it in the V8 patch set.
So what is the conclusion about the "work" item. Should I revert it to V6?
next prev parent reply other threads:[~2025-02-17 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 8:30 [PATCH net-next v7 0/4] Support PTP clock for Wangxun NICs Jiawen Wu
2025-02-13 8:30 ` [PATCH net-next v7 1/4] net: wangxun: Add support for PTP clock Jiawen Wu
2025-02-13 8:30 ` [PATCH net-next v7 2/4] net: wangxun: Support to get ts info Jiawen Wu
2025-02-13 8:30 ` [PATCH net-next v7 3/4] net: wangxun: Add periodic checks for overflow and errors Jiawen Wu
2025-02-13 8:30 ` [PATCH net-next v7 4/4] net: ngbe: Add support for 1PPS and TOD Jiawen Wu
2025-02-15 0:52 ` [PATCH net-next v7 0/4] Support PTP clock for Wangxun NICs Jakub Kicinski
2025-02-17 1:47 ` Jiawen Wu [this message]
2025-02-17 22:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='050201db80dd$f4b45bb0$de1d1310$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.