From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Logan Gunthorpe <logang@deltatee.com>, song@kernel.org
Cc: linux-raid@vger.kernel.org, buczek@molgen.mpg.de
Subject: Re: [PATCH] md: only unlock mddev from action_store
Date: Tue, 7 Jun 2022 09:20:36 +0800 [thread overview]
Message-ID: <050d869e-07a8-18b2-7a77-4a459e93dab3@linux.dev> (raw)
In-Reply-To: <2e8ae871-8349-2253-fcce-2722b03fe21d@deltatee.com>
On 6/6/22 11:48 PM, Logan Gunthorpe wrote:
>> After move "md_unregister_thread(&mddev->sync_thread)", then we need to
>> rename md_reap_sync_thread given it doesn't unregister sync_thread, any
>> suggestion about the new name? md_behind_reap_sync_thread?
> I don't like the "behind"... Which would be a name suggesting when the
> function should be called, not what the function does.
Right, naming is hard.
> I'd maybe go with something like md_cleanup_sync_thread()
It is confusing since it doesn't related with sync_thread anymore after
the pull.
I will keep the name unchanged for now.
Thanks,
Guoqing
next prev parent reply other threads:[~2022-06-07 1:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:45 [PATCH] md: only unlock mddev from action_store Guoqing Jiang
2022-06-02 18:03 ` Logan Gunthorpe
2022-06-06 3:08 ` Guoqing Jiang
2022-06-06 8:39 ` Xiao Ni
2022-06-06 9:00 ` Guoqing Jiang
2022-06-06 9:36 ` Xiao Ni
2022-06-06 9:55 ` Guoqing Jiang
2022-06-06 11:54 ` Xiao Ni
2022-06-06 3:29 ` Guoqing Jiang
2022-06-06 15:48 ` Logan Gunthorpe
2022-06-07 1:20 ` Guoqing Jiang [this message]
2022-06-03 6:24 ` Donald Buczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050d869e-07a8-18b2-7a77-4a459e93dab3@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=buczek@molgen.mpg.de \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.